Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/s3_bucket_versioning: backport resource #23432

Merged
merged 6 commits into from
Mar 15, 2022

Conversation

anGie44
Copy link
Contributor

@anGie44 anGie44 commented Mar 1, 2022

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #23106

Output from acceptance testing:

--- PASS: TestAccS3BucketVersioning_disappears (226.52s)
--- PASS: TestAccS3BucketVersioning_basic (248.57s)
--- PASS: TestAccS3BucketVersioning_MFADelete (248.68s)
--- PASS: TestAccS3BucketVersioning_update (540.47s)

--- PASS: TestAccS3Bucket_Manage_MfaDeleteDisabled (33.96s)
--- PASS: TestAccS3Bucket_Manage_versioningAndMfaDeleteDisabled (34.05s)
--- PASS: TestAccS3Bucket_Basic_basic (34.07s)
--- PASS: TestAccS3Bucket_Manage_versioningDisabled (38.62s)
--- PASS: TestAccS3Bucket_Basic_shouldFailNotFound (17.18s)
--- PASS: TestAccS3Bucket_Basic_keyEnabled (35.52s)
--- PASS: TestAccS3Bucket_Security_enableDefaultEncryptionWhenAES256IsUsed (31.71s)
--- PASS: TestAccS3Bucket_Replication_ruleDestinationAccessControlTranslation (90.51s)
--- PASS: TestAccS3Bucket_Security_disableDefaultEncryptionWhenDefaultEncryptionIsEnabled (58.31s)
--- PASS: TestAccS3Bucket_Manage_versioning (64.63s)
--- PASS: TestAccS3Bucket_Security_enableDefaultEncryptionWhenTypical (34.75s)
--- PASS: TestAccS3Bucket_Basic_forceDestroyWithObjectLockEnabled (29.20s)
--- PASS: TestAccS3Bucket_Web_routingRules (62.55s)
--- PASS: TestAccS3Bucket_Security_grantToACL (52.66s)
--- PASS: TestAccS3Bucket_Web_redirect (83.88s)
--- PASS: TestAccS3Bucket_Security_aclToGrant (52.45s)
--- PASS: TestAccS3Bucket_Web_simple (84.12s)
--- PASS: TestAccS3Bucket_Basic_forceDestroyWithEmptyPrefixes (26.37s)
--- PASS: TestAccS3Bucket_Basic_forceDestroy (26.80s)
--- PASS: TestAccS3Bucket_Security_updateACL (56.21s)
--- PASS: TestAccS3Bucket_Security_updateGrant (91.58s)
--- PASS: TestAccS3Bucket_Manage_objectLock (58.92s)
--- PASS: TestAccS3Bucket_Replication_schemaV2SameRegion (47.66s)
--- PASS: TestAccS3Bucket_Replication_expectVersioningValidationError (13.60s)
--- PASS: TestAccS3Bucket_Replication_withoutPrefix (43.82s)
--- PASS: TestAccS3Bucket_Replication_withoutStorageClass (42.77s)
--- PASS: TestAccS3Bucket_Tags_basic (35.82s)
--- PASS: TestAccS3Bucket_Replication_ruleDestinationAddAccessControlTranslation (77.35s)
--- PASS: TestAccS3Bucket_Basic_requestPayer (62.37s)
--- PASS: TestAccS3Bucket_Basic_generatedName (32.78s)
--- PASS: TestAccS3Bucket_Replication_RTC_valid (192.00s)
--- PASS: TestAccS3Bucket_Basic_acceleration (63.05s)
--- PASS: TestAccS3Bucket_Basic_namePrefix (29.74s)
--- PASS: TestAccS3Bucket_Manage_lifecycleRuleExpirationEmptyBlock (23.11s)
--- PASS: TestAccS3Bucket_Replication_schemaV2 (234.37s)
--- PASS: TestAccS3Bucket_Replication_twoDestination (126.43s)
--- PASS: TestAccS3Bucket_Replication_multipleDestinationsNonEmptyFilter (132.02s)
--- PASS: TestAccS3Bucket_Replication_multipleDestinationsEmptyFilter (177.86s)
--- PASS: TestAccS3Bucket_Manage_lifecycleRuleAbortIncompleteMultipartUploadDaysNoExpiration (109.28s)
--- PASS: TestAccS3Bucket_Security_logging (156.88s)
--- PASS: TestAccS3Bucket_Tags_ignoreTags (208.78s)
--- PASS: TestAccS3Bucket_Manage_lifecycleBasic (329.18s)
--- PASS: TestAccS3Bucket_Manage_lifecycleExpireMarkerOnly (252.12s)
--- PASS: TestAccS3Bucket_Replication_basic (554.26s)
--- PASS: TestAccS3Bucket_Basic_emptyString (129.41s)
--- PASS: TestAccS3Bucket_Security_corsDelete (92.94s)
--- PASS: TestAccS3Bucket_Security_corsEmptyOrigin (119.55s)
--- PASS: TestAccS3Bucket_Tags_withSystemTags (519.84s)
--- PASS: TestAccS3Bucket_Security_corsUpdate (180.67s)
--- PASS: TestAccS3Bucket_Tags_withNoSystemTags (383.47s)
--- PASS: TestAccS3Bucket_Security_policy (188.24s)

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/s3 Issues and PRs that pertain to the s3 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/XL Managed by automation to categorize the size of a PR. labels Mar 1, 2022
anGie44 added a commit that referenced this pull request Mar 1, 2022
@gdavison gdavison added this to the v3.75.0 milestone Mar 2, 2022
@anGie44 anGie44 force-pushed the f-s3-bucket-versioning-new-resource branch from 450c85d to 651a745 Compare March 10, 2022 23:16
@anGie44
Copy link
Contributor Author

anGie44 commented Mar 10, 2022

Depends on #23419

@anGie44 anGie44 marked this pull request as ready for review March 10, 2022 23:17
@anGie44 anGie44 added the new-resource Introduces a new resource. label Mar 14, 2022
@anGie44 anGie44 changed the title r/s3_bucket_versioning: new resource r/s3_bucket_versioning: backport resource Mar 14, 2022
@anGie44
Copy link
Contributor Author

anGie44 commented Mar 15, 2022

Output of acceptance tests after changes:

--- PASS: TestAccS3BucketVersioning_disappears (31.52s)
--- PASS: TestAccS3BucketVersioning_basic (34.67s)
--- PASS: TestAccS3BucketVersioning_MFADelete (34.84s)
--- PASS: TestAccS3BucketVersioning_migrate_mfaDeleteNoChange (49.34s)
--- PASS: TestAccS3BucketVersioning_migrate_versioningEnabledWithChange (49.98s)
--- PASS: TestAccS3BucketVersioning_migrate_versioningEnabledNoChange (51.18s)
--- PASS: TestAccS3BucketVersioning_update (85.93s)

@anGie44 anGie44 merged commit c468bca into release/3.x Mar 15, 2022
@anGie44 anGie44 deleted the f-s3-bucket-versioning-new-resource branch March 15, 2022 03:07
github-actions bot pushed a commit that referenced this pull request Mar 15, 2022
@github-actions
Copy link

This functionality has been released in v3.75.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. new-resource Introduces a new resource. provider Pertains to the provider itself, rather than any interaction with AWS. service/s3 Issues and PRs that pertain to the s3 service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants