Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update v4 migration guide with more info on imports #23324

Merged
merged 4 commits into from
Feb 28, 2022

Conversation

justinretzolk
Copy link
Member

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #23106

Output from acceptance testing:

N/a, docs

Information

This PR aims to provide additional clarifying information in the migration guide around the new aws_s3_bucket_* resources introduced in AWS Provider v4.0.0. The aim is to provide a better idea of when terraform import is required for these new resources with the hopes of easing operator burden when upgrading.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. size/XS Managed by automation to categorize the size of a PR. labels Feb 22, 2022
@justinretzolk justinretzolk changed the title Update guide with more info on imports Update v4 migration guide with more info on imports Feb 22, 2022
Copy link
Contributor

@anGie44 anGie44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a couple comments left for review

website/docs/guides/version-4-upgrade.html.md Outdated Show resolved Hide resolved
website/docs/guides/version-4-upgrade.html.md Outdated Show resolved Hide resolved
Co-authored-by: angie pinilla <[email protected]>
@gdavison gdavison added this to the v4.3.0 milestone Feb 28, 2022
Copy link
Contributor

@gdavison gdavison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🚀

Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

@gdavison gdavison merged commit c617423 into main Feb 28, 2022
@gdavison gdavison deleted the justin/migration-guide-update branch February 28, 2022 22:33
@github-actions
Copy link

github-actions bot commented Mar 1, 2022

This functionality has been released in v4.3.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants