Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

t/lb_target_group: Add missing matcher in acc test #2315

Merged
merged 1 commit into from
Nov 16, 2017

Conversation

radeksimko
Copy link
Member

@radeksimko radeksimko commented Nov 16, 2017

We no longer set default matcher b/c there's no matcher for network LBs.
The following test started failing after merging #2251

=== RUN   TestAccAWSAutoScalingGroup_ALB_TargetGroups_ELBCapacity
--- FAIL: TestAccAWSAutoScalingGroup_ALB_TargetGroups_ELBCapacity (154.65s)
    testing.go:503: Step 0 error: Error applying: 1 error(s) occurred:
        
        * aws_lb_target_group.test: 1 error(s) occurred:
        
        * aws_lb_target_group.test: Error creating LB Target Group: ValidationError: Health check matcher HTTP code cannot be empty
            status code: 400, request id: 0fe27fc2-ca91-11e7-beee-571c8f0de551

I would not treat this as a breaking change per say, because it only affects new target groups. Existing ones will already have matchers in the state, so the removal of Default won't affect them.

That said I think we should document this in the NOTES section of changelog, e.g.

  • resource/aws_lb_target_group: We no longer provide defaults for health_check's path nor matcher in order to support network load balancers where these arguments aren't valid. Creating new ALB will therefore require you to specify these two arguments. Existing deployments are unaffected.

Test Results (after patch)

TF_ACC=1 go test ./aws -v -run=TestAccAWSAutoScalingGroup_ALB_TargetGroups_ELBCapacity -timeout 120m
=== RUN   TestAccAWSAutoScalingGroup_ALB_TargetGroups_ELBCapacity
--- PASS: TestAccAWSAutoScalingGroup_ALB_TargetGroups_ELBCapacity (381.21s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	381.242s

We no longer set default matcher b/c there's no matcher for network LBs
@radeksimko radeksimko added the bug Addresses a defect in current functionality. label Nov 16, 2017
@radeksimko radeksimko added this to the v1.3.0 milestone Nov 16, 2017
@radeksimko radeksimko requested a review from catsby November 16, 2017 09:17
@radeksimko radeksimko removed this from the v1.3.0 milestone Nov 16, 2017
Copy link
Contributor

@catsby catsby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@radeksimko radeksimko merged commit 57ab3e1 into master Nov 16, 2017
@radeksimko radeksimko deleted the b-lb-tf-add-missing-matcher branch November 16, 2017 19:48
@ghost
Copy link

ghost commented Apr 10, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants