Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests/emr: update to aws_s3_bucket_acl #23048

Merged
merged 1 commit into from
Feb 9, 2022
Merged

tests/emr: update to aws_s3_bucket_acl #23048

merged 1 commit into from
Feb 9, 2022

Conversation

anGie44
Copy link
Contributor

@anGie44 anGie44 commented Feb 9, 2022 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #22997
Relates #22537
Relates #20433
Output from acceptance testing:

--- FAIL: TestAccEMRCluster_visibleToAllUsers (748.82s) <--- history of failures for quite some time in main as well
--- PASS: TestAccEMRCluster_Bootstrap_ordering (1276.75s)
--- PASS: TestAccEMRCluster_CoreInstanceGroup_autoScalingPolicy (619.69s)
--- PASS: TestAccEMRCluster_CoreInstanceGroup_bidPrice (1004.02s)
--- PASS: TestAccEMRCluster_CoreInstanceGroup_instanceCount (519.02s)
--- PASS: TestAccEMRCluster_CoreInstanceGroup_instanceType (945.13s)
--- PASS: TestAccEMRCluster_CoreInstanceGroup_name (1050.56s)
--- PASS: TestAccEMRCluster_CustomAMI_id (494.95s)
--- PASS: TestAccEMRCluster_EC2Attributes_defaultManagedSecurityGroups (881.56s)
--- PASS: TestAccEMRCluster_InstanceFleetMaster_only (527.47s)
--- PASS: TestAccEMRCluster_InstanceFleet_basic (1231.38s)
--- PASS: TestAccEMRCluster_Kerberos_clusterDedicatedKdc (411.96s)
--- PASS: TestAccEMRCluster_MasterInstanceGroup_bidPrice (881.28s)
--- PASS: TestAccEMRCluster_MasterInstanceGroup_instanceCount (1212.28s)
--- PASS: TestAccEMRCluster_MasterInstanceGroup_instanceType (780.10s)
--- PASS: TestAccEMRCluster_MasterInstanceGroup_name (810.67s)
--- PASS: TestAccEMRCluster_RootVolume_size (745.64s)
--- PASS: TestAccEMRCluster_StepConcurrency_level (467.31s)
--- PASS: TestAccEMRCluster_Step_basic (415.94s)
--- PASS: TestAccEMRCluster_Step_mode (815.36s)
--- PASS: TestAccEMRCluster_Step_multiple (446.22s)
--- PASS: TestAccEMRCluster_additionalInfo (463.66s)
--- PASS: TestAccEMRCluster_autoTerminationPolicy (671.48s)
--- PASS: TestAccEMRCluster_basic (440.50s)
--- PASS: TestAccEMRCluster_disappears (400.30s)
--- PASS: TestAccEMRCluster_ebs (496.86s)
--- PASS: TestAccEMRCluster_keepJob (468.48s)
--- PASS: TestAccEMRCluster_s3LogEncryption (701.12s)
--- PASS: TestAccEMRCluster_s3Logging (572.31s)
--- PASS: TestAccEMRCluster_sJSON (422.91s)
--- PASS: TestAccEMRCluster_security (400.23s)
--- PASS: TestAccEMRCluster_tags (786.12s)
--- PASS: TestAccEMRCluster_terminationProtected (356.97s)
--- PASS: TestAccEMRStudio_iam (25.06s)
--- SKIP: TestAccEMRStudio_disappears (25.03s)
--- SKIP: TestAccEMRStudio_sso (25.99s)
--- SKIP: TestAccEMRStudio_tags (17.15s)

@github-actions github-actions bot added service/emr Issues and PRs that pertain to the emr service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/XS Managed by automation to categorize the size of a PR. labels Feb 9, 2022
@anGie44 anGie44 marked this pull request as ready for review February 9, 2022 16:58
@anGie44 anGie44 added this to the v4.0.0 milestone Feb 9, 2022
ewbankkit
ewbankkit approved these changes Feb 9, 2022
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccEMRCluster_\|TestAccEMRStudio_' PKG=emr
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/emr/... -v -count 1 -parallel 20  -run=TestAccEMRCluster_\|TestAccEMRStudio_ -timeout 180m
=== RUN   TestAccEMRCluster_basic
=== PAUSE TestAccEMRCluster_basic
=== RUN   TestAccEMRCluster_autoTerminationPolicy
=== PAUSE TestAccEMRCluster_autoTerminationPolicy
=== RUN   TestAccEMRCluster_additionalInfo
=== PAUSE TestAccEMRCluster_additionalInfo
=== RUN   TestAccEMRCluster_disappears
=== PAUSE TestAccEMRCluster_disappears
=== RUN   TestAccEMRCluster_sJSON
=== PAUSE TestAccEMRCluster_sJSON
=== RUN   TestAccEMRCluster_CoreInstanceGroup_autoScalingPolicy
=== PAUSE TestAccEMRCluster_CoreInstanceGroup_autoScalingPolicy
=== RUN   TestAccEMRCluster_CoreInstanceGroup_bidPrice
=== PAUSE TestAccEMRCluster_CoreInstanceGroup_bidPrice
=== RUN   TestAccEMRCluster_CoreInstanceGroup_instanceCount
=== PAUSE TestAccEMRCluster_CoreInstanceGroup_instanceCount
=== RUN   TestAccEMRCluster_CoreInstanceGroup_instanceType
=== PAUSE TestAccEMRCluster_CoreInstanceGroup_instanceType
=== RUN   TestAccEMRCluster_CoreInstanceGroup_name
=== PAUSE TestAccEMRCluster_CoreInstanceGroup_name
=== RUN   TestAccEMRCluster_EC2Attributes_defaultManagedSecurityGroups
=== PAUSE TestAccEMRCluster_EC2Attributes_defaultManagedSecurityGroups
=== RUN   TestAccEMRCluster_Kerberos_clusterDedicatedKdc
=== PAUSE TestAccEMRCluster_Kerberos_clusterDedicatedKdc
=== RUN   TestAccEMRCluster_MasterInstanceGroup_bidPrice
=== PAUSE TestAccEMRCluster_MasterInstanceGroup_bidPrice
=== RUN   TestAccEMRCluster_MasterInstanceGroup_instanceCount
=== PAUSE TestAccEMRCluster_MasterInstanceGroup_instanceCount
=== RUN   TestAccEMRCluster_MasterInstanceGroup_instanceType
=== PAUSE TestAccEMRCluster_MasterInstanceGroup_instanceType
=== RUN   TestAccEMRCluster_MasterInstanceGroup_name
=== PAUSE TestAccEMRCluster_MasterInstanceGroup_name
=== RUN   TestAccEMRCluster_security
=== PAUSE TestAccEMRCluster_security
=== RUN   TestAccEMRCluster_Step_basic
=== PAUSE TestAccEMRCluster_Step_basic
=== RUN   TestAccEMRCluster_Step_mode
=== PAUSE TestAccEMRCluster_Step_mode
=== RUN   TestAccEMRCluster_Step_multiple
=== PAUSE TestAccEMRCluster_Step_multiple
=== RUN   TestAccEMRCluster_Bootstrap_ordering
=== PAUSE TestAccEMRCluster_Bootstrap_ordering
=== RUN   TestAccEMRCluster_terminationProtected
=== PAUSE TestAccEMRCluster_terminationProtected
=== RUN   TestAccEMRCluster_keepJob
=== PAUSE TestAccEMRCluster_keepJob
=== RUN   TestAccEMRCluster_visibleToAllUsers
=== PAUSE TestAccEMRCluster_visibleToAllUsers
=== RUN   TestAccEMRCluster_s3Logging
=== PAUSE TestAccEMRCluster_s3Logging
=== RUN   TestAccEMRCluster_s3LogEncryption
=== PAUSE TestAccEMRCluster_s3LogEncryption
=== RUN   TestAccEMRCluster_tags
=== PAUSE TestAccEMRCluster_tags
=== RUN   TestAccEMRCluster_RootVolume_size
=== PAUSE TestAccEMRCluster_RootVolume_size
=== RUN   TestAccEMRCluster_StepConcurrency_level
=== PAUSE TestAccEMRCluster_StepConcurrency_level
=== RUN   TestAccEMRCluster_ebs
=== PAUSE TestAccEMRCluster_ebs
=== RUN   TestAccEMRCluster_CustomAMI_id
=== PAUSE TestAccEMRCluster_CustomAMI_id
=== RUN   TestAccEMRCluster_InstanceFleet_basic
=== PAUSE TestAccEMRCluster_InstanceFleet_basic
=== RUN   TestAccEMRCluster_InstanceFleetMaster_only
=== PAUSE TestAccEMRCluster_InstanceFleetMaster_only
=== RUN   TestAccEMRStudio_sso
=== PAUSE TestAccEMRStudio_sso
=== RUN   TestAccEMRStudio_iam
=== PAUSE TestAccEMRStudio_iam
=== RUN   TestAccEMRStudio_disappears
=== PAUSE TestAccEMRStudio_disappears
=== RUN   TestAccEMRStudio_tags
=== PAUSE TestAccEMRStudio_tags
=== CONT  TestAccEMRCluster_basic
=== CONT  TestAccEMRCluster_Step_multiple
=== CONT  TestAccEMRCluster_StepConcurrency_level
=== CONT  TestAccEMRStudio_tags
=== CONT  TestAccEMRStudio_disappears
=== CONT  TestAccEMRStudio_iam
=== CONT  TestAccEMRStudio_sso
=== CONT  TestAccEMRCluster_InstanceFleetMaster_only
=== CONT  TestAccEMRCluster_InstanceFleet_basic
=== CONT  TestAccEMRCluster_CustomAMI_id
=== CONT  TestAccEMRCluster_EC2Attributes_defaultManagedSecurityGroups
=== CONT  TestAccEMRCluster_Step_mode
=== CONT  TestAccEMRCluster_Step_basic
=== CONT  TestAccEMRCluster_security
=== CONT  TestAccEMRCluster_MasterInstanceGroup_name
=== CONT  TestAccEMRCluster_ebs
=== CONT  TestAccEMRCluster_MasterInstanceGroup_instanceType
=== CONT  TestAccEMRCluster_s3Logging
=== CONT  TestAccEMRCluster_MasterInstanceGroup_instanceCount
=== CONT  TestAccEMRCluster_RootVolume_size
=== CONT  TestAccEMRStudio_sso
    acctest.go:974: skipping test for aws/us-west-2: Error running apply: exit status 1
        
        Error: error creating EMR Studio: InvalidRequestException: SSO is not enabled (Service: AWSEditors; Status Code: 400; Error Code: InvalidRequestException; Request ID: 15254889-9a76-4768-8396-eb158ae18ec4; Proxy: null)
        {
          RespMetadata: {
            StatusCode: 400,
            RequestID: "ffb913fa-7be2-4ffe-a963-a67ff66b19f9"
          },
          Message_: "SSO is not enabled (Service: AWSEditors; Status Code: 400; Error Code: InvalidRequestException; Request ID: 15254889-9a76-4768-8396-eb158ae18ec4; Proxy: null)"
        }
        
          with aws_emr_studio.test,
          on terraform_plugin_test.tf line 78, in resource "aws_emr_studio" "test":
          78: resource "aws_emr_studio" "test" {
        
=== CONT  TestAccEMRStudio_tags
    acctest.go:974: skipping test for aws/us-west-2: Error running apply: exit status 1
        
        Error: error creating EMR Studio: InvalidRequestException: SSO is not enabled (Service: AWSEditors; Status Code: 400; Error Code: InvalidRequestException; Request ID: 951b4daf-a62f-4f5a-8362-bfa47d7be16b; Proxy: null)
        {
          RespMetadata: {
            StatusCode: 400,
            RequestID: "f607fd25-3c35-4f22-8ccf-4a35194fb65e"
          },
          Message_: "SSO is not enabled (Service: AWSEditors; Status Code: 400; Error Code: InvalidRequestException; Request ID: 951b4daf-a62f-4f5a-8362-bfa47d7be16b; Proxy: null)"
        }
        
          with aws_emr_studio.test,
          on terraform_plugin_test.tf line 78, in resource "aws_emr_studio" "test":
          78: resource "aws_emr_studio" "test" {
        
=== CONT  TestAccEMRStudio_disappears
    acctest.go:974: skipping test for aws/us-west-2: Error running apply: exit status 1
        
        Error: error creating EMR Studio: InvalidRequestException: SSO is not enabled (Service: AWSEditors; Status Code: 400; Error Code: InvalidRequestException; Request ID: fc2378ac-e18e-45d1-b179-43f721f03543; Proxy: null)
        {
          RespMetadata: {
            StatusCode: 400,
            RequestID: "59a1c10a-d388-464b-82db-0c830266c7cc"
          },
          Message_: "SSO is not enabled (Service: AWSEditors; Status Code: 400; Error Code: InvalidRequestException; Request ID: fc2378ac-e18e-45d1-b179-43f721f03543; Proxy: null)"
        }
        
          with aws_emr_studio.test,
          on terraform_plugin_test.tf line 78, in resource "aws_emr_studio" "test":
          78: resource "aws_emr_studio" "test" {
        
--- SKIP: TestAccEMRStudio_sso (45.75s)
=== CONT  TestAccEMRCluster_MasterInstanceGroup_bidPrice
--- SKIP: TestAccEMRStudio_tags (45.84s)
=== CONT  TestAccEMRCluster_Kerberos_clusterDedicatedKdc
--- SKIP: TestAccEMRStudio_disappears (46.12s)
=== CONT  TestAccEMRCluster_CoreInstanceGroup_autoScalingPolicy
--- PASS: TestAccEMRStudio_iam (60.67s)
=== CONT  TestAccEMRCluster_tags
--- PASS: TestAccEMRCluster_Kerberos_clusterDedicatedKdc (412.89s)
=== CONT  TestAccEMRCluster_CoreInstanceGroup_name
--- PASS: TestAccEMRCluster_basic (463.62s)
=== CONT  TestAccEMRCluster_s3LogEncryption
--- PASS: TestAccEMRCluster_Step_basic (488.03s)
=== CONT  TestAccEMRCluster_CoreInstanceGroup_instanceType
--- PASS: TestAccEMRCluster_security (500.30s)
=== CONT  TestAccEMRCluster_disappears
--- PASS: TestAccEMRCluster_ebs (523.28s)
=== CONT  TestAccEMRCluster_sJSON
--- PASS: TestAccEMRCluster_StepConcurrency_level (547.15s)
=== CONT  TestAccEMRCluster_CoreInstanceGroup_bidPrice
--- PASS: TestAccEMRCluster_InstanceFleetMaster_only (576.02s)
=== CONT  TestAccEMRCluster_keepJob
--- PASS: TestAccEMRCluster_CoreInstanceGroup_autoScalingPolicy (618.56s)
=== CONT  TestAccEMRCluster_terminationProtected
--- PASS: TestAccEMRCluster_MasterInstanceGroup_instanceType (800.77s)
=== CONT  TestAccEMRCluster_additionalInfo
--- PASS: TestAccEMRCluster_CustomAMI_id (893.28s)
=== CONT  TestAccEMRCluster_Bootstrap_ordering
--- PASS: TestAccEMRCluster_Step_multiple (917.83s)
=== CONT  TestAccEMRCluster_autoTerminationPolicy
--- PASS: TestAccEMRCluster_s3Logging (919.89s)
=== CONT  TestAccEMRCluster_CoreInstanceGroup_instanceCount
--- PASS: TestAccEMRCluster_EC2Attributes_defaultManagedSecurityGroups (958.50s)
=== CONT  TestAccEMRCluster_visibleToAllUsers
--- PASS: TestAccEMRCluster_sJSON (444.77s)
--- PASS: TestAccEMRCluster_MasterInstanceGroup_name (1024.53s)
--- PASS: TestAccEMRCluster_tags (967.33s)
--- PASS: TestAccEMRCluster_keepJob (458.83s)
--- PASS: TestAccEMRCluster_disappears (603.97s)
--- PASS: TestAccEMRCluster_RootVolume_size (1107.44s)
--- PASS: TestAccEMRCluster_Step_mode (1185.49s)
--- PASS: TestAccEMRCluster_InstanceFleet_basic (1218.68s)
--- PASS: TestAccEMRCluster_s3LogEncryption (758.45s)
--- PASS: TestAccEMRCluster_terminationProtected (597.13s)
--- PASS: TestAccEMRCluster_additionalInfo (477.91s)
--- PASS: TestAccEMRCluster_MasterInstanceGroup_instanceCount (1341.47s)
--- PASS: TestAccEMRCluster_CoreInstanceGroup_name (890.64s)
--- PASS: TestAccEMRCluster_CoreInstanceGroup_instanceType (899.14s)
--- PASS: TestAccEMRCluster_MasterInstanceGroup_bidPrice (1387.86s)
--- PASS: TestAccEMRCluster_CoreInstanceGroup_instanceCount (585.27s)
=== CONT  TestAccEMRCluster_visibleToAllUsers
    cluster_test.go:1144: Step 3/4 error: Check failed: Check 2/2 error: aws_emr_cluster.test: Attribute 'visible_to_all_users' expected "false", got "true"
--- PASS: TestAccEMRCluster_autoTerminationPolicy (721.64s)
--- FAIL: TestAccEMRCluster_visibleToAllUsers (687.42s)
--- PASS: TestAccEMRCluster_CoreInstanceGroup_bidPrice (1157.49s)
--- PASS: TestAccEMRCluster_Bootstrap_ordering (1282.00s)
FAIL
FAIL	github.com/hashicorp/terraform-provider-aws/internal/service/emr	2179.045s
FAIL
make: *** [testacc] Error 1

@anGie44 anGie44 merged commit 058e0ec into main Feb 9, 2022
@anGie44 anGie44 deleted the td-emr-s3-bucket-acl-tests branch February 9, 2022 18:02
@github-actions
Copy link

This functionality has been released in v4.0.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
service/emr Issues and PRs that pertain to the emr service. size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v4.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@anGie44 @ewbankkit