Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix EMR is not valid for managed_scaling_policy #23029

Conversation

ArtsiomAntropau
Copy link
Contributor

Fix aws_emr_managed_scaling_policy for compatibility with the behavior of emr_cluster that was fixed as a part of the next problem

#16924
#7783

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #16924
Relates #7783

Fix aws_emr_managed_scaling_policy for compatibility with the behavior of emr_cluster that was fixed as a part of the next problem:

hashicorp#16924
hashicorp#7783
@github-actions github-actions bot added size/XS Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. service/emr Issues and PRs that pertain to the emr service. labels Feb 8, 2022
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @ArtsiomAntropau 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@ArtsiomAntropau
Copy link
Contributor Author

@shuheiktgw hi, as I understand, you are a maintainer of the EMR modules, can you take a look, please?

@justinretzolk justinretzolk added bug Addresses a defect in current functionality. and removed needs-triage Waiting for first response or review from a maintainer. labels Feb 15, 2022
@ArtsiomAntropau
Copy link
Contributor Author

@justinretzolk hi, do the Team need any help from my side or when we can release we a fix?

@justinretzolk
Copy link
Member

Hey @ArtsiomAntropau 👋 Thank you for your contribution here!. Unfortunately, I'm not able to provide an estimate on when this will be merged due to the potential of shifting priorities. We prioritize work by count of ":+1:" reactions, as well as a few other things. A larger prioritization document is in the works, but in the meantime additional information may be found in the FAQ.

@ArtsiomAntropau ArtsiomAntropau force-pushed the fix/managed_scaling_policy-when-cluster-is-not-valid branch from aae316c to f040b65 Compare June 29, 2023 19:03
@ewbankkit
Copy link
Contributor

@ArtsiomAntropau Thanks for the contribution 🎉 👏.
This worked has been included in #37740.

@ewbankkit ewbankkit closed this pull request by merging all changes into hashicorp:main in 99ca8dd Aug 27, 2024
@github-actions github-actions bot added this to the v5.65.0 milestone Aug 27, 2024
Copy link

This functionality has been released in v5.65.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/emr Issues and PRs that pertain to the emr service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants