-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
r/cloudwatch_event_target: remove launch_type default #22803
r/cloudwatch_event_target: remove launch_type default #22803
Conversation
13942a7
to
e604544
Compare
dba7e70
to
c49cf34
Compare
c49cf34
to
fb9293a
Compare
fb9293a
to
9969917
Compare
9969917
to
2fa711b
Compare
2fa711b
to
2a1d3fc
Compare
2a1d3fc
to
68098a2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccEventsTarget_' PKG=events
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/events/... -v -count 1 -parallel 20 -run=TestAccEventsTarget_ -timeout 180m
=== RUN TestAccEventsTarget_basic
=== PAUSE TestAccEventsTarget_basic
=== RUN TestAccEventsTarget_eventBusName
=== PAUSE TestAccEventsTarget_eventBusName
=== RUN TestAccEventsTarget_eventBusARN
=== PAUSE TestAccEventsTarget_eventBusARN
=== RUN TestAccEventsTarget_generatedTargetID
=== PAUSE TestAccEventsTarget_generatedTargetID
=== RUN TestAccEventsTarget_RetryPolicy_deadLetter
=== PAUSE TestAccEventsTarget_RetryPolicy_deadLetter
=== RUN TestAccEventsTarget_full
=== PAUSE TestAccEventsTarget_full
=== RUN TestAccEventsTarget_disappears
=== PAUSE TestAccEventsTarget_disappears
=== RUN TestAccEventsTarget_ssmDocument
=== PAUSE TestAccEventsTarget_ssmDocument
=== RUN TestAccEventsTarget_http
=== PAUSE TestAccEventsTarget_http
=== RUN TestAccEventsTarget_ecs
=== PAUSE TestAccEventsTarget_ecs
=== RUN TestAccEventsTarget_redshift
=== PAUSE TestAccEventsTarget_redshift
=== RUN TestAccEventsTarget_ecsWithoutLaunchType
=== PAUSE TestAccEventsTarget_ecsWithoutLaunchType
=== RUN TestAccEventsTarget_ecsWithBlankLaunchType
=== PAUSE TestAccEventsTarget_ecsWithBlankLaunchType
=== RUN TestAccEventsTarget_ecsWithBlankTaskCount
=== PAUSE TestAccEventsTarget_ecsWithBlankTaskCount
=== RUN TestAccEventsTarget_ecsFull
=== PAUSE TestAccEventsTarget_ecsFull
=== RUN TestAccEventsTarget_batch
=== PAUSE TestAccEventsTarget_batch
=== RUN TestAccEventsTarget_kinesis
=== PAUSE TestAccEventsTarget_kinesis
=== RUN TestAccEventsTarget_sqs
=== PAUSE TestAccEventsTarget_sqs
=== RUN TestAccEventsTarget_Input_transformer
=== PAUSE TestAccEventsTarget_Input_transformer
=== RUN TestAccEventsTarget_inputTransformerJSONString
=== PAUSE TestAccEventsTarget_inputTransformerJSONString
=== RUN TestAccEventsTarget_partnerEventBus
target_test.go:796: Environment variable EVENT_BRIDGE_PARTNER_EVENT_BUS_NAME is not set
--- SKIP: TestAccEventsTarget_partnerEventBus (0.00s)
=== CONT TestAccEventsTarget_basic
=== CONT TestAccEventsTarget_redshift
=== CONT TestAccEventsTarget_ecsWithBlankTaskCount
=== CONT TestAccEventsTarget_ecsWithoutLaunchType
=== CONT TestAccEventsTarget_generatedTargetID
=== CONT TestAccEventsTarget_batch
=== CONT TestAccEventsTarget_inputTransformerJSONString
=== CONT TestAccEventsTarget_Input_transformer
=== CONT TestAccEventsTarget_sqs
=== CONT TestAccEventsTarget_kinesis
=== CONT TestAccEventsTarget_full
=== CONT TestAccEventsTarget_ssmDocument
=== CONT TestAccEventsTarget_ecs
=== CONT TestAccEventsTarget_http
=== CONT TestAccEventsTarget_disappears
=== CONT TestAccEventsTarget_eventBusARN
=== CONT TestAccEventsTarget_RetryPolicy_deadLetter
=== CONT TestAccEventsTarget_ecsWithBlankLaunchType
=== CONT TestAccEventsTarget_ecsFull
=== CONT TestAccEventsTarget_eventBusName
--- PASS: TestAccEventsTarget_disappears (35.00s)
--- PASS: TestAccEventsTarget_generatedTargetID (39.59s)
--- PASS: TestAccEventsTarget_eventBusARN (40.35s)
--- PASS: TestAccEventsTarget_http (42.89s)
--- PASS: TestAccEventsTarget_ssmDocument (45.47s)
--- PASS: TestAccEventsTarget_inputTransformerJSONString (49.95s)
--- PASS: TestAccEventsTarget_eventBusName (60.03s)
--- PASS: TestAccEventsTarget_Input_transformer (61.43s)
--- PASS: TestAccEventsTarget_sqs (67.72s)
--- PASS: TestAccEventsTarget_basic (69.13s)
--- PASS: TestAccEventsTarget_ecsWithBlankTaskCount (70.47s)
--- PASS: TestAccEventsTarget_full (73.55s)
--- PASS: TestAccEventsTarget_RetryPolicy_deadLetter (73.92s)
--- PASS: TestAccEventsTarget_kinesis (74.43s)
--- PASS: TestAccEventsTarget_ecsFull (77.65s)
--- PASS: TestAccEventsTarget_ecsWithoutLaunchType (101.41s)
--- PASS: TestAccEventsTarget_ecsWithBlankLaunchType (101.62s)
--- PASS: TestAccEventsTarget_batch (148.70s)
--- PASS: TestAccEventsTarget_redshift (219.97s)
--- PASS: TestAccEventsTarget_ecs (303.42s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/events 307.752s
Note: Should probably be mentioned in the upgrade guide #22818 |
722d634
to
99b7f07
Compare
6752037
to
71ae3b3
Compare
This functionality has been released in v4.0.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Community Note
Closes #16078
Relates #22776
Relates #20433
Output from acceptance testing: