Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/s3_bucket_cors_configuration: new resource #22619

Closed
wants to merge 3 commits into from
Closed

r/s3_bucket_cors_configuration: new resource #22619

wants to merge 3 commits into from

Conversation

anGie44
Copy link
Contributor

@anGie44 anGie44 commented Jan 16, 2022

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #4418
Relates #20433

Output from acceptance testing:

--- PASS: TestAccS3BucketCorsConfiguration_disappears (25.91s)
--- PASS: TestAccS3BucketCorsConfiguration_SingleRule (27.93s)
--- PASS: TestAccS3BucketCorsConfiguration_MultipleRules (28.31s)
--- PASS: TestAccS3BucketCorsConfiguration_basic (28.76s)
--- PASS: TestAccS3BucketCorsConfiguration_update (69.97s)

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/s3 Issues and PRs that pertain to the s3 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jan 16, 2022
anGie44 added a commit that referenced this pull request Jan 16, 2022
@anGie44
Update CHANGELOG for #22619
7b6a98b
@anGie44 anGie44 added new-resource Introduces a new resource. and removed documentation Introduces or discusses updates to documentation. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/s3 Issues and PRs that pertain to the s3 service. provider Pertains to the provider itself, rather than any interaction with AWS. labels Jan 16, 2022
@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/s3 Issues and PRs that pertain to the s3 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jan 18, 2022
@anGie44 anGie44 force-pushed the release/4.x branch 3 times, most recently from 1e894e8 to 6623846 Compare January 21, 2022 16:39
@anGie44 anGie44 force-pushed the release/4.x branch 2 times, most recently from 44a00a8 to 5ac8e8c Compare January 26, 2022 18:37
@anGie44 anGie44 force-pushed the f-s3-bucket-cors-resource branch from adfcf19 to 72cdcb7 Compare January 26, 2022 21:45
@anGie44
Copy link
Contributor Author

anGie44 commented Jan 26, 2022

Preceded by #12141

@anGie44 anGie44 mentioned this pull request Jan 27, 2022
Merged
@anGie44 anGie44 closed this Jan 27, 2022
@anGie44 anGie44 deleted the f-s3-bucket-cors-resource branch January 27, 2022 18:28
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. new-resource Introduces a new resource. provider Pertains to the provider itself, rather than any interaction with AWS. service/s3 Issues and PRs that pertain to the s3 service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@anGie44