Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sns/topic: ISO-friendly tagging #22511

Merged
merged 16 commits into from
Jan 12, 2022
Merged

sns/topic: ISO-friendly tagging #22511

merged 16 commits into from
Jan 12, 2022

Conversation

YakDriver
Copy link
Member

@YakDriver YakDriver commented Jan 10, 2022

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #21209
Relates #22532

Output from acceptance testing (us-west-2):

% make testacc TESTS=TestAccSNSTopic_ PKG=sns
--- PASS: TestAccSNSTopic_fifoExpectContentBasedDeduplicationError (4.25s)
--- PASS: TestAccSNSTopic_disappears (17.49s)
--- PASS: TestAccSNSTopic_name (24.78s)
--- PASS: TestAccSNSTopic_NamePrefix_fifoTopic (24.97s)
--- PASS: TestAccSNSTopic_namePrefix (25.12s)
--- PASS: TestAccSNSTopic_Name_fifoTopic (25.13s)
--- PASS: TestAccSNSTopic_policy (25.14s)
--- PASS: TestAccSNSTopic_NameGenerated_fifoTopic (25.14s)
--- PASS: TestAccSNSTopic_withDeliveryPolicy (25.14s)
--- PASS: TestAccSNSTopic_basic (25.18s)
--- PASS: TestAccSNSTopic_withIAMRole (32.51s)
--- PASS: TestAccSNSTopic_fifoWithContentBasedDeduplication (34.85s)
--- PASS: TestAccSNSTopic_encryption (35.21s)
--- PASS: TestAccSNSTopic_deliveryStatus (36.25s)
--- PASS: TestAccSNSTopic_tags (44.99s)
--- PASS: TestAccSNSTopic_withFakeIAMRole (130.83s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/sns	132.191s

Output from acceptance testing (GovCloud):

% make testacc TESTS=TestAccSNSTopic_ PKG=sns
--- PASS: TestAccSNSTopic_fifoExpectContentBasedDeduplicationError (5.28s)
--- SKIP: TestAccSNSTopic_Name_fifoTopic (10.68s)
--- SKIP: TestAccSNSTopic_fifoWithContentBasedDeduplication (10.69s)
--- SKIP: TestAccSNSTopic_NameGenerated_fifoTopic (10.69s)
--- SKIP: TestAccSNSTopic_NamePrefix_fifoTopic (10.70s)
--- PASS: TestAccSNSTopic_disappears (20.55s)
--- PASS: TestAccSNSTopic_withDeliveryPolicy (27.36s)
--- PASS: TestAccSNSTopic_basic (27.42s)
--- PASS: TestAccSNSTopic_name (27.49s)
--- PASS: TestAccSNSTopic_namePrefix (27.54s)
--- PASS: TestAccSNSTopic_policy (27.57s)
--- PASS: TestAccSNSTopic_withIAMRole (33.66s)
--- PASS: TestAccSNSTopic_deliveryStatus (40.43s)
--- PASS: TestAccSNSTopic_encryption (40.64s)
--- PASS: TestAccSNSTopic_tags (53.25s)
--- PASS: TestAccSNSTopic_withFakeIAMRole (133.58s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/sns	134.787s

@github-actions github-actions bot added service/sns Issues and PRs that pertain to the sns service. size/XS Managed by automation to categorize the size of a PR. labels Jan 10, 2022
@YakDriver YakDriver added partition/aws-iso Pertains to the aws-iso partition. partition/aws-iso-b Pertains to the aws-iso-b partition. labels Jan 10, 2022
@github-actions github-actions bot added size/S Managed by automation to categorize the size of a PR. and removed size/XS Managed by automation to categorize the size of a PR. labels Jan 10, 2022
@github-actions github-actions bot added size/XS Managed by automation to categorize the size of a PR. and removed size/S Managed by automation to categorize the size of a PR. labels Jan 11, 2022
@github-actions github-actions bot added size/S Managed by automation to categorize the size of a PR. and removed size/XS Managed by automation to categorize the size of a PR. labels Jan 11, 2022
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTS=TestAccSNSTopic_ PKG=sns
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/sns/... -v -count 1 -parallel 20 -run='TestAccSNSTopic_'  -timeout 180m
=== RUN   TestAccSNSTopic_basic
=== PAUSE TestAccSNSTopic_basic
=== RUN   TestAccSNSTopic_name
=== PAUSE TestAccSNSTopic_name
=== RUN   TestAccSNSTopic_namePrefix
=== PAUSE TestAccSNSTopic_namePrefix
=== RUN   TestAccSNSTopic_policy
=== PAUSE TestAccSNSTopic_policy
=== RUN   TestAccSNSTopic_withIAMRole
=== PAUSE TestAccSNSTopic_withIAMRole
=== RUN   TestAccSNSTopic_withFakeIAMRole
=== PAUSE TestAccSNSTopic_withFakeIAMRole
=== RUN   TestAccSNSTopic_withDeliveryPolicy
=== PAUSE TestAccSNSTopic_withDeliveryPolicy
=== RUN   TestAccSNSTopic_deliveryStatus
=== PAUSE TestAccSNSTopic_deliveryStatus
=== RUN   TestAccSNSTopic_NameGenerated_fifoTopic
=== PAUSE TestAccSNSTopic_NameGenerated_fifoTopic
=== RUN   TestAccSNSTopic_Name_fifoTopic
=== PAUSE TestAccSNSTopic_Name_fifoTopic
=== RUN   TestAccSNSTopic_NamePrefix_fifoTopic
=== PAUSE TestAccSNSTopic_NamePrefix_fifoTopic
=== RUN   TestAccSNSTopic_fifoWithContentBasedDeduplication
=== PAUSE TestAccSNSTopic_fifoWithContentBasedDeduplication
=== RUN   TestAccSNSTopic_fifoExpectContentBasedDeduplicationError
=== PAUSE TestAccSNSTopic_fifoExpectContentBasedDeduplicationError
=== RUN   TestAccSNSTopic_encryption
=== PAUSE TestAccSNSTopic_encryption
=== RUN   TestAccSNSTopic_tags
=== PAUSE TestAccSNSTopic_tags
=== RUN   TestAccSNSTopic_disappears
=== PAUSE TestAccSNSTopic_disappears
=== CONT  TestAccSNSTopic_basic
=== CONT  TestAccSNSTopic_encryption
=== CONT  TestAccSNSTopic_fifoWithContentBasedDeduplication
=== CONT  TestAccSNSTopic_tags
=== CONT  TestAccSNSTopic_Name_fifoTopic
=== CONT  TestAccSNSTopic_withFakeIAMRole
=== CONT  TestAccSNSTopic_NameGenerated_fifoTopic
=== CONT  TestAccSNSTopic_deliveryStatus
=== CONT  TestAccSNSTopic_disappears
=== CONT  TestAccSNSTopic_policy
=== CONT  TestAccSNSTopic_withIAMRole
=== CONT  TestAccSNSTopic_withDeliveryPolicy
=== CONT  TestAccSNSTopic_NamePrefix_fifoTopic
=== CONT  TestAccSNSTopic_namePrefix
=== CONT  TestAccSNSTopic_name
=== CONT  TestAccSNSTopic_fifoExpectContentBasedDeduplicationError
--- PASS: TestAccSNSTopic_fifoExpectContentBasedDeduplicationError (9.48s)
--- PASS: TestAccSNSTopic_disappears (37.62s)
--- PASS: TestAccSNSTopic_namePrefix (44.06s)
--- PASS: TestAccSNSTopic_Name_fifoTopic (49.58s)
--- PASS: TestAccSNSTopic_NamePrefix_fifoTopic (49.63s)
--- PASS: TestAccSNSTopic_NameGenerated_fifoTopic (49.68s)
--- PASS: TestAccSNSTopic_name (49.75s)
--- PASS: TestAccSNSTopic_withDeliveryPolicy (49.83s)
--- PASS: TestAccSNSTopic_policy (49.92s)
--- PASS: TestAccSNSTopic_basic (50.03s)
--- PASS: TestAccSNSTopic_deliveryStatus (59.14s)
--- PASS: TestAccSNSTopic_encryption (64.13s)
--- PASS: TestAccSNSTopic_fifoWithContentBasedDeduplication (64.14s)
--- PASS: TestAccSNSTopic_withIAMRole (69.69s)
--- PASS: TestAccSNSTopic_tags (74.61s)
--- PASS: TestAccSNSTopic_withFakeIAMRole (142.25s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/sns	148.659s

@YakDriver YakDriver mentioned this pull request Jan 11, 2022
27 tasks
@YakDriver YakDriver merged commit 5852262 into main Jan 12, 2022
@YakDriver YakDriver deleted the f-iso-tagging-sns branch January 12, 2022 15:28
@github-actions github-actions bot added this to the v3.72.0 milestone Jan 12, 2022
@github-actions
Copy link

This functionality has been released in v3.72.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
partition/aws-iso Pertains to the aws-iso partition. partition/aws-iso-b Pertains to the aws-iso-b partition. service/sns Issues and PRs that pertain to the sns service. size/S Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SNS State Refreshes and Subscriptions Fail in us-iso-b due to Tagging Not Existing
2 participants