-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sns/topic: ISO-friendly tagging #22511
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTS=TestAccSNSTopic_ PKG=sns
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/sns/... -v -count 1 -parallel 20 -run='TestAccSNSTopic_' -timeout 180m
=== RUN TestAccSNSTopic_basic
=== PAUSE TestAccSNSTopic_basic
=== RUN TestAccSNSTopic_name
=== PAUSE TestAccSNSTopic_name
=== RUN TestAccSNSTopic_namePrefix
=== PAUSE TestAccSNSTopic_namePrefix
=== RUN TestAccSNSTopic_policy
=== PAUSE TestAccSNSTopic_policy
=== RUN TestAccSNSTopic_withIAMRole
=== PAUSE TestAccSNSTopic_withIAMRole
=== RUN TestAccSNSTopic_withFakeIAMRole
=== PAUSE TestAccSNSTopic_withFakeIAMRole
=== RUN TestAccSNSTopic_withDeliveryPolicy
=== PAUSE TestAccSNSTopic_withDeliveryPolicy
=== RUN TestAccSNSTopic_deliveryStatus
=== PAUSE TestAccSNSTopic_deliveryStatus
=== RUN TestAccSNSTopic_NameGenerated_fifoTopic
=== PAUSE TestAccSNSTopic_NameGenerated_fifoTopic
=== RUN TestAccSNSTopic_Name_fifoTopic
=== PAUSE TestAccSNSTopic_Name_fifoTopic
=== RUN TestAccSNSTopic_NamePrefix_fifoTopic
=== PAUSE TestAccSNSTopic_NamePrefix_fifoTopic
=== RUN TestAccSNSTopic_fifoWithContentBasedDeduplication
=== PAUSE TestAccSNSTopic_fifoWithContentBasedDeduplication
=== RUN TestAccSNSTopic_fifoExpectContentBasedDeduplicationError
=== PAUSE TestAccSNSTopic_fifoExpectContentBasedDeduplicationError
=== RUN TestAccSNSTopic_encryption
=== PAUSE TestAccSNSTopic_encryption
=== RUN TestAccSNSTopic_tags
=== PAUSE TestAccSNSTopic_tags
=== RUN TestAccSNSTopic_disappears
=== PAUSE TestAccSNSTopic_disappears
=== CONT TestAccSNSTopic_basic
=== CONT TestAccSNSTopic_encryption
=== CONT TestAccSNSTopic_fifoWithContentBasedDeduplication
=== CONT TestAccSNSTopic_tags
=== CONT TestAccSNSTopic_Name_fifoTopic
=== CONT TestAccSNSTopic_withFakeIAMRole
=== CONT TestAccSNSTopic_NameGenerated_fifoTopic
=== CONT TestAccSNSTopic_deliveryStatus
=== CONT TestAccSNSTopic_disappears
=== CONT TestAccSNSTopic_policy
=== CONT TestAccSNSTopic_withIAMRole
=== CONT TestAccSNSTopic_withDeliveryPolicy
=== CONT TestAccSNSTopic_NamePrefix_fifoTopic
=== CONT TestAccSNSTopic_namePrefix
=== CONT TestAccSNSTopic_name
=== CONT TestAccSNSTopic_fifoExpectContentBasedDeduplicationError
--- PASS: TestAccSNSTopic_fifoExpectContentBasedDeduplicationError (9.48s)
--- PASS: TestAccSNSTopic_disappears (37.62s)
--- PASS: TestAccSNSTopic_namePrefix (44.06s)
--- PASS: TestAccSNSTopic_Name_fifoTopic (49.58s)
--- PASS: TestAccSNSTopic_NamePrefix_fifoTopic (49.63s)
--- PASS: TestAccSNSTopic_NameGenerated_fifoTopic (49.68s)
--- PASS: TestAccSNSTopic_name (49.75s)
--- PASS: TestAccSNSTopic_withDeliveryPolicy (49.83s)
--- PASS: TestAccSNSTopic_policy (49.92s)
--- PASS: TestAccSNSTopic_basic (50.03s)
--- PASS: TestAccSNSTopic_deliveryStatus (59.14s)
--- PASS: TestAccSNSTopic_encryption (64.13s)
--- PASS: TestAccSNSTopic_fifoWithContentBasedDeduplication (64.14s)
--- PASS: TestAccSNSTopic_withIAMRole (69.69s)
--- PASS: TestAccSNSTopic_tags (74.61s)
--- PASS: TestAccSNSTopic_withFakeIAMRole (142.25s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/sns 148.659s
This functionality has been released in v3.72.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Community Note
Closes #21209
Relates #22532
Output from acceptance testing (
us-west-2
):Output from acceptance testing (GovCloud):