New resource/aws_vpc_ipam_organization_admin_account

[drewmullen]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #22092

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccVPCIpamOrganizationAdminAccount_basic' PKG_NAME='./internal/service/ec2'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ././internal/service/ec2/... -v -count 1 -parallel 20 -run=TestAccVPCIpamOrganizationAdminAccount_basic -timeout 180m
=== RUN   TestAccVPCIpamOrganizationAdminAccount_basic
--- PASS: TestAccVPCIpamOrganizationAdminAccount_basic (15.31s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ec2        18.537s

Also included note in docs for aws_vpc_ipam_pool_cidr to explain if the resource is unable to be deleted, users should have some context as to why and how to resolve

[drewmullen]

what am i missing here? passing CLI tests but failing in CI

$ make lint
==> Checking source code with golangci-lint...
==> Checking source code with providerlint...
==> Checking source code with importlint...

$ make fmt
==> Fixing source code with gofmt...
gofmt -s -w ./internal ./providerlint/helper ./providerlint/main.go ./providerlint/passes

$ git status
On branch f-ipam-organization-enable
nothing to commit, working tree clean

[ewbankkit]

@drewmullen No, terrafmt is not currently included in make lint.
#22287 addresses this I think - Could you take a look? Thanks.

[drewmullen]

@ewbankkit thanks for that PR. reviewing that now

regarding semgrep theres a error reported that is unavoidable because ec2 has no Describe action for enabling the service in organizations. is there an ignore option?

    8│   	"github.com/aws/aws-sdk-go/service/ec2"
    9│   	"github.com/aws/aws-sdk-go/service/organizations"
     ╵
     = Resources should not implement multiple AWS service functionality

[ewbankkit]

Adding // nosemgrep: aws-sdk-go-multiple-service-imports will fix the semgrep complaint.
See e.g. internal/service/elbv2/load_balancer.go.

[ewbankkit]

LGTM 🚀.

% make testacc TESTS=TestAccVPCIpamOrganizationAdminAccount_ PKG=ec2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccVPCIpamOrganizationAdminAccount_' -timeout 180m
=== RUN   TestAccVPCIpamOrganizationAdminAccount_basic
--- PASS: TestAccVPCIpamOrganizationAdminAccount_basic (25.32s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	31.046s

[ewbankkit]

@drewmullen Thanks for the contribution 🎉 👏.

[github-actions]

This functionality has been released in v3.71.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.