Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

d/aws_batch_job_queue - new attribute #22348

Merged

Conversation

GlennChia
Copy link
Collaborator

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #21755

Output from acceptance testing:

$ make testacc TESTS=TestAccBatchJobQueueDataSource PKG=batch 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/batch/... -v -count 1 -parallel 20 -run='TestAccBatchJobQueueDataSource' -timeout 180m
=== RUN   TestAccBatchJobQueueDataSource_basic
=== PAUSE TestAccBatchJobQueueDataSource_basic
=== RUN   TestAccBatchJobQueueDataSource_schedulingPolicy
=== PAUSE TestAccBatchJobQueueDataSource_schedulingPolicy
=== CONT  TestAccBatchJobQueueDataSource_basic
=== CONT  TestAccBatchJobQueueDataSource_schedulingPolicy
--- PASS: TestAccBatchJobQueueDataSource_basic (174.88s)
--- PASS: TestAccBatchJobQueueDataSource_schedulingPolicy (176.82s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/batch      185.282s

...

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. size/M Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/batch Issues and PRs that pertain to the batch service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. and removed needs-triage Waiting for first response or review from a maintainer. labels Dec 26, 2021
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTS=TestAccBatchJobQueueDataSource_ PKG=batch
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/batch/... -v -count 1 -parallel 20 -run='TestAccBatchJobQueueDataSource_' -timeout 180m
=== RUN   TestAccBatchJobQueueDataSource_basic
=== PAUSE TestAccBatchJobQueueDataSource_basic
=== RUN   TestAccBatchJobQueueDataSource_schedulingPolicy
=== PAUSE TestAccBatchJobQueueDataSource_schedulingPolicy
=== CONT  TestAccBatchJobQueueDataSource_basic
=== CONT  TestAccBatchJobQueueDataSource_schedulingPolicy
--- PASS: TestAccBatchJobQueueDataSource_schedulingPolicy (72.41s)
--- PASS: TestAccBatchJobQueueDataSource_basic (75.26s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/batch	81.174s

@ewbankkit
Copy link
Contributor

@GlennChia Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 95e98a1 into hashicorp:main Jan 4, 2022
@github-actions github-actions bot added this to the v3.71.0 milestone Jan 4, 2022
@github-actions
Copy link

github-actions bot commented Jan 6, 2022

This functionality has been released in v3.71.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 31, 2022
@GlennChia GlennChia deleted the f-aws_batch_job_queue-new-attribute branch August 6, 2022 02:57
@justinretzolk justinretzolk added the partner Contribution from a partner. label May 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. partner Contribution from a partner. service/batch Issues and PRs that pertain to the batch service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants