Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Resource: aws_memorydb_parameter_group #22304

Merged
merged 1 commit into from
Dec 22, 2021

Conversation

roberth-k
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #20631

Output from acceptance testing:

$ make testacc PKG=memorydb TESTS=TestAccMemoryDBParameterGroup_
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/memorydb/... -v -count 1 -parallel 20 -run='TestAccMemoryDBParameterGroup_' -timeout 180m
=== RUN   TestAccMemoryDBParameterGroup_basic
=== PAUSE TestAccMemoryDBParameterGroup_basic
=== RUN   TestAccMemoryDBParameterGroup_disappears
=== PAUSE TestAccMemoryDBParameterGroup_disappears
=== RUN   TestAccMemoryDBParameterGroup_update_parameters
=== PAUSE TestAccMemoryDBParameterGroup_update_parameters
=== RUN   TestAccMemoryDBParameterGroup_update_tags
=== PAUSE TestAccMemoryDBParameterGroup_update_tags
=== CONT  TestAccMemoryDBParameterGroup_basic
=== CONT  TestAccMemoryDBParameterGroup_update_parameters
=== CONT  TestAccMemoryDBParameterGroup_update_tags
=== CONT  TestAccMemoryDBParameterGroup_disappears
--- PASS: TestAccMemoryDBParameterGroup_disappears (20.86s)
--- PASS: TestAccMemoryDBParameterGroup_basic (28.97s)
--- PASS: TestAccMemoryDBParameterGroup_update_tags (99.43s)
--- PASS: TestAccMemoryDBParameterGroup_update_parameters (147.68s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/memorydb   149.590s

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/memorydb Issues and PRs that pertain to the memorydb service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/XL Managed by automation to categorize the size of a PR. labels Dec 21, 2021
@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Dec 22, 2021
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

Commercial
% make testacc PKG=memorydb TESTS=TestAccMemoryDBParameterGroup_
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/memorydb/... -v -count 1 -parallel 20 -run='TestAccMemoryDBParameterGroup_' -timeout 180m
=== RUN   TestAccMemoryDBParameterGroup_basic
=== PAUSE TestAccMemoryDBParameterGroup_basic
=== RUN   TestAccMemoryDBParameterGroup_disappears
=== PAUSE TestAccMemoryDBParameterGroup_disappears
=== RUN   TestAccMemoryDBParameterGroup_update_parameters
=== PAUSE TestAccMemoryDBParameterGroup_update_parameters
=== RUN   TestAccMemoryDBParameterGroup_update_tags
=== PAUSE TestAccMemoryDBParameterGroup_update_tags
=== CONT  TestAccMemoryDBParameterGroup_basic
=== CONT  TestAccMemoryDBParameterGroup_update_tags
=== CONT  TestAccMemoryDBParameterGroup_update_parameters
=== CONT  TestAccMemoryDBParameterGroup_disappears
--- PASS: TestAccMemoryDBParameterGroup_disappears (19.89s)
--- PASS: TestAccMemoryDBParameterGroup_basic (27.09s)
--- PASS: TestAccMemoryDBParameterGroup_update_tags (88.76s)
--- PASS: TestAccMemoryDBParameterGroup_update_parameters (128.71s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/memorydb	135.832s
GovCloud
% make testacc PKG=memorydb TESTS=TestAccMemoryDBParameterGroup_
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/memorydb/... -v -count 1 -parallel 20 -run='TestAccMemoryDBParameterGroup_' -timeout 180m
=== RUN   TestAccMemoryDBParameterGroup_basic
=== PAUSE TestAccMemoryDBParameterGroup_basic
=== RUN   TestAccMemoryDBParameterGroup_disappears
=== PAUSE TestAccMemoryDBParameterGroup_disappears
=== RUN   TestAccMemoryDBParameterGroup_update_parameters
=== PAUSE TestAccMemoryDBParameterGroup_update_parameters
=== RUN   TestAccMemoryDBParameterGroup_update_tags
=== PAUSE TestAccMemoryDBParameterGroup_update_tags
=== CONT  TestAccMemoryDBParameterGroup_basic
=== CONT  TestAccMemoryDBParameterGroup_update_parameters
=== CONT  TestAccMemoryDBParameterGroup_update_tags
=== CONT  TestAccMemoryDBParameterGroup_disappears
=== CONT  TestAccMemoryDBParameterGroup_basic
    subnet_group_test.go:25: MemoryDB is not supported in aws-us-gov partition
=== CONT  TestAccMemoryDBParameterGroup_update_parameters
    subnet_group_test.go:25: MemoryDB is not supported in aws-us-gov partition
--- SKIP: TestAccMemoryDBParameterGroup_basic (1.26s)
--- SKIP: TestAccMemoryDBParameterGroup_update_parameters (1.26s)
=== CONT  TestAccMemoryDBParameterGroup_update_tags
    subnet_group_test.go:25: MemoryDB is not supported in aws-us-gov partition
--- SKIP: TestAccMemoryDBParameterGroup_update_tags (1.26s)
=== CONT  TestAccMemoryDBParameterGroup_disappears
    subnet_group_test.go:25: MemoryDB is not supported in aws-us-gov partition
--- SKIP: TestAccMemoryDBParameterGroup_disappears (1.26s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/memorydb	4.730s

@ewbankkit
Copy link
Contributor

@roberth-k Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 346879c into hashicorp:main Dec 22, 2021
@github-actions github-actions bot added this to the v3.71.0 milestone Dec 22, 2021
@github-actions
Copy link

github-actions bot commented Jan 6, 2022

This functionality has been released in v3.71.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/memorydb Issues and PRs that pertain to the memorydb service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants