Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

efs/file_system_policy: Fix diffs with equivalent policies #22100

Merged
merged 7 commits into from
Dec 8, 2021

Conversation

YakDriver
Copy link
Member

@YakDriver YakDriver commented Dec 8, 2021

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #21968
Fixes #19245

Output from acceptance testing (us-west-2):

% make testacc TESTS=TestAccEFSFileSystemPolicy PKG=efs                            
TF_ACC=1 go test ./internal/service/efs/... -v -count 1 -parallel 20 -run='TestAccEFSFileSystemPolicy' -timeout 180m
--- PASS: TestAccEFSFileSystemPolicy_disappears (26.35s)
--- PASS: TestAccEFSFileSystemPolicy_equivalentPolicies (35.35s)
--- PASS: TestAccEFSFileSystemPolicy_equivalentPoliciesIAMPolicyDoc (35.53s)
--- PASS: TestAccEFSFileSystemPolicy_basic (41.84s)
--- PASS: TestAccEFSFileSystemPolicy_policyBypass (41.84s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/efs	43.510s

Output from acceptance testing (GovCloud):

% make testacc TESTS=TestAccEFSFileSystemPolicy PKG=efs                            
TF_ACC=1 go test ./internal/service/efs/... -v -count 1 -parallel 20 -run='TestAccEFSFileSystemPolicy' -timeout 180m
--- PASS: TestAccEFSFileSystemPolicy_disappears (29.98s)
--- PASS: TestAccEFSFileSystemPolicy_equivalentPolicies (42.54s)
--- PASS: TestAccEFSFileSystemPolicy_equivalentPoliciesIAMPolicyDoc (42.64s)
--- PASS: TestAccEFSFileSystemPolicy_policyBypass (51.10s)
--- PASS: TestAccEFSFileSystemPolicy_basic (51.10s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/efs	52.786s

@github-actions github-actions bot added service/efs Issues and PRs that pertain to the efs service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/M Managed by automation to categorize the size of a PR. labels Dec 8, 2021
@github-actions github-actions bot added size/L Managed by automation to categorize the size of a PR. and removed size/M Managed by automation to categorize the size of a PR. labels Dec 8, 2021
@YakDriver YakDriver added this to the Roadmap milestone Dec 8, 2021
@YakDriver YakDriver self-assigned this Dec 8, 2021
@YakDriver YakDriver merged commit d9b979e into main Dec 8, 2021
@YakDriver YakDriver deleted the b-efs-file-system-policy-diffs branch December 8, 2021 04:34
@github-actions github-actions bot modified the milestones: Roadmap, v3.69.0 Dec 8, 2021
github-actions bot pushed a commit that referenced this pull request Dec 8, 2021
@github-actions
Copy link

This functionality has been released in v3.69.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Jun 4, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/efs Issues and PRs that pertain to the efs service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws_iam_policy_document Bool condition always shows diff
1 participant