Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/networkfirewall_firewall_(policy|rule_group) stateful rule ordering #21955

Merged
merged 4 commits into from
Dec 10, 2021
Merged

r/networkfirewall_firewall_(policy|rule_group) stateful rule ordering #21955

merged 4 commits into from
Dec 10, 2021

Conversation

stuwil
Copy link
Contributor

@stuwil stuwil commented Nov 29, 2021 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

This implements Network Firewall support for stateful rule ordering and default drop options, as described in this AWS announcement.

Closes #21242

Output from acceptance testing:

$ make testacc TESTS=TestAccNetworkFirewallFirewallPolicy PKG=networkfirewall
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/networkfirewall/... -v -count 1 -parallel 20 -run='TestAccNetworkFirewallFirewallPolicy' -timeout 180m
=== RUN   TestAccNetworkFirewallFirewallPolicy_basic
=== PAUSE TestAccNetworkFirewallFirewallPolicy_basic
=== RUN   TestAccNetworkFirewallFirewallPolicy_statefulDefaultActions
=== PAUSE TestAccNetworkFirewallFirewallPolicy_statefulDefaultActions
=== RUN   TestAccNetworkFirewallFirewallPolicy_statefulEngineOption
=== PAUSE TestAccNetworkFirewallFirewallPolicy_statefulEngineOption
=== RUN   TestAccNetworkFirewallFirewallPolicy_updateStatefulEngineOption
=== PAUSE TestAccNetworkFirewallFirewallPolicy_updateStatefulEngineOption
=== RUN   TestAccNetworkFirewallFirewallPolicy_statefulRuleGroupReference
=== PAUSE TestAccNetworkFirewallFirewallPolicy_statefulRuleGroupReference
=== RUN   TestAccNetworkFirewallFirewallPolicy_updateStatefulRuleGroupReference
=== PAUSE TestAccNetworkFirewallFirewallPolicy_updateStatefulRuleGroupReference
=== RUN   TestAccNetworkFirewallFirewallPolicy_multipleStatefulRuleGroupReferences
=== PAUSE TestAccNetworkFirewallFirewallPolicy_multipleStatefulRuleGroupReferences
=== RUN   TestAccNetworkFirewallFirewallPolicy_statefulRuleGroupPriorityReference
=== PAUSE TestAccNetworkFirewallFirewallPolicy_statefulRuleGroupPriorityReference
=== RUN   TestAccNetworkFirewallFirewallPolicy_updateStatefulRuleGroupPriorityReference
=== PAUSE TestAccNetworkFirewallFirewallPolicy_updateStatefulRuleGroupPriorityReference
=== RUN   TestAccNetworkFirewallFirewallPolicy_statelessRuleGroupReference
=== PAUSE TestAccNetworkFirewallFirewallPolicy_statelessRuleGroupReference
=== RUN   TestAccNetworkFirewallFirewallPolicy_updateStatelessRuleGroupReference
=== PAUSE TestAccNetworkFirewallFirewallPolicy_updateStatelessRuleGroupReference
=== RUN   TestAccNetworkFirewallFirewallPolicy_multipleStatelessRuleGroupReferences
=== PAUSE TestAccNetworkFirewallFirewallPolicy_multipleStatelessRuleGroupReferences
=== RUN   TestAccNetworkFirewallFirewallPolicy_statelessCustomAction
=== PAUSE TestAccNetworkFirewallFirewallPolicy_statelessCustomAction
=== RUN   TestAccNetworkFirewallFirewallPolicy_updateStatelessCustomAction
=== PAUSE TestAccNetworkFirewallFirewallPolicy_updateStatelessCustomAction
=== RUN   TestAccNetworkFirewallFirewallPolicy_multipleStatelessCustomActions
=== PAUSE TestAccNetworkFirewallFirewallPolicy_multipleStatelessCustomActions
=== RUN   TestAccNetworkFirewallFirewallPolicy_statefulRuleGroupReferenceAndCustomAction
=== PAUSE TestAccNetworkFirewallFirewallPolicy_statefulRuleGroupReferenceAndCustomAction
=== RUN   TestAccNetworkFirewallFirewallPolicy_tags
=== PAUSE TestAccNetworkFirewallFirewallPolicy_tags
=== RUN   TestAccNetworkFirewallFirewallPolicy_disappears
=== PAUSE TestAccNetworkFirewallFirewallPolicy_disappears
=== CONT  TestAccNetworkFirewallFirewallPolicy_basic
=== CONT  TestAccNetworkFirewallFirewallPolicy_statelessRuleGroupReference
=== CONT  TestAccNetworkFirewallFirewallPolicy_statefulRuleGroupReferenceAndCustomAction
=== CONT  TestAccNetworkFirewallFirewallPolicy_updateStatelessRuleGroupReference
=== CONT  TestAccNetworkFirewallFirewallPolicy_statefulDefaultActions
=== CONT  TestAccNetworkFirewallFirewallPolicy_statefulEngineOption
=== CONT  TestAccNetworkFirewallFirewallPolicy_disappears
=== CONT  TestAccNetworkFirewallFirewallPolicy_tags
=== CONT  TestAccNetworkFirewallFirewallPolicy_statelessCustomAction
=== CONT  TestAccNetworkFirewallFirewallPolicy_multipleStatelessRuleGroupReferences
=== CONT  TestAccNetworkFirewallFirewallPolicy_updateStatelessCustomAction
=== CONT  TestAccNetworkFirewallFirewallPolicy_updateStatefulEngineOption
=== CONT  TestAccNetworkFirewallFirewallPolicy_updateStatefulRuleGroupReference
=== CONT  TestAccNetworkFirewallFirewallPolicy_updateStatefulRuleGroupPriorityReference
=== CONT  TestAccNetworkFirewallFirewallPolicy_statefulRuleGroupPriorityReference
=== CONT  TestAccNetworkFirewallFirewallPolicy_statefulRuleGroupReference
=== CONT  TestAccNetworkFirewallFirewallPolicy_multipleStatefulRuleGroupReferences
=== CONT  TestAccNetworkFirewallFirewallPolicy_multipleStatelessCustomActions
--- PASS: TestAccNetworkFirewallFirewallPolicy_statefulDefaultActions (133.86s)
--- PASS: TestAccNetworkFirewallFirewallPolicy_basic (134.25s)
--- PASS: TestAccNetworkFirewallFirewallPolicy_statelessCustomAction (135.64s)
--- PASS: TestAccNetworkFirewallFirewallPolicy_statefulEngineOption (138.26s)
--- PASS: TestAccNetworkFirewallFirewallPolicy_tags (170.03s)
--- PASS: TestAccNetworkFirewallFirewallPolicy_statefulRuleGroupReference (173.83s)
--- PASS: TestAccNetworkFirewallFirewallPolicy_disappears (175.80s)
--- PASS: TestAccNetworkFirewallFirewallPolicy_updateStatefulRuleGroupReference (200.24s)
--- PASS: TestAccNetworkFirewallFirewallPolicy_updateStatelessRuleGroupReference (200.96s)
--- PASS: TestAccNetworkFirewallFirewallPolicy_updateStatefulRuleGroupPriorityReference (206.25s)
--- PASS: TestAccNetworkFirewallFirewallPolicy_statefulRuleGroupPriorityReference (206.60s)
--- PASS: TestAccNetworkFirewallFirewallPolicy_multipleStatefulRuleGroupReferences (208.13s)
--- PASS: TestAccNetworkFirewallFirewallPolicy_statelessRuleGroupReference (208.63s)
--- PASS: TestAccNetworkFirewallFirewallPolicy_multipleStatelessRuleGroupReferences (210.03s)
--- PASS: TestAccNetworkFirewallFirewallPolicy_statefulRuleGroupReferenceAndCustomAction (286.85s)
--- PASS: TestAccNetworkFirewallFirewallPolicy_updateStatefulEngineOption (313.62s)
--- PASS: TestAccNetworkFirewallFirewallPolicy_multipleStatelessCustomActions (313.98s)
--- PASS: TestAccNetworkFirewallFirewallPolicy_updateStatelessCustomAction (589.55s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/networkfirewall	591.316s

$ make testacc TESTS=TestAccNetworkFirewallRuleGroup PKG=networkfirewall
TF_ACC=1 go test ./internal/service/networkfirewall/... -v -count 1 -parallel 20 -run='TestAccNetworkFirewallRuleGroup' -timeout 180m
=== RUN   TestAccNetworkFirewallRuleGroup_Basic_rulesSourceList
=== PAUSE TestAccNetworkFirewallRuleGroup_Basic_rulesSourceList
=== RUN   TestAccNetworkFirewallRuleGroup_Basic_statefulRule
=== PAUSE TestAccNetworkFirewallRuleGroup_Basic_statefulRule
=== RUN   TestAccNetworkFirewallRuleGroup_Basic_statelessRule
=== PAUSE TestAccNetworkFirewallRuleGroup_Basic_statelessRule
=== RUN   TestAccNetworkFirewallRuleGroup_Basic_rules
=== PAUSE TestAccNetworkFirewallRuleGroup_Basic_rules
=== RUN   TestAccNetworkFirewallRuleGroup_statefulRuleOptions
=== PAUSE TestAccNetworkFirewallRuleGroup_statefulRuleOptions
=== RUN   TestAccNetworkFirewallRuleGroup_updateStatefulRuleOptions
=== PAUSE TestAccNetworkFirewallRuleGroup_updateStatefulRuleOptions
=== RUN   TestAccNetworkFirewallRuleGroup_statelessRuleWithCustomAction
=== PAUSE TestAccNetworkFirewallRuleGroup_statelessRuleWithCustomAction
=== RUN   TestAccNetworkFirewallRuleGroup_updateRules
=== PAUSE TestAccNetworkFirewallRuleGroup_updateRules
=== RUN   TestAccNetworkFirewallRuleGroup_updateRulesSourceList
=== PAUSE TestAccNetworkFirewallRuleGroup_updateRulesSourceList
=== RUN   TestAccNetworkFirewallRuleGroup_rulesSourceAndRuleVariables
=== PAUSE TestAccNetworkFirewallRuleGroup_rulesSourceAndRuleVariables
=== RUN   TestAccNetworkFirewallRuleGroup_updateStatefulRule
=== PAUSE TestAccNetworkFirewallRuleGroup_updateStatefulRule
=== RUN   TestAccNetworkFirewallRuleGroup_updateMultipleStatefulRules
=== PAUSE TestAccNetworkFirewallRuleGroup_updateMultipleStatefulRules
=== RUN   TestAccNetworkFirewallRuleGroup_StatefulRule_action
=== PAUSE TestAccNetworkFirewallRuleGroup_StatefulRule_action
=== RUN   TestAccNetworkFirewallRuleGroup_StatefulRule_header
=== PAUSE TestAccNetworkFirewallRuleGroup_StatefulRule_header
=== RUN   TestAccNetworkFirewallRuleGroup_updateStatelessRule
=== PAUSE TestAccNetworkFirewallRuleGroup_updateStatelessRule
=== RUN   TestAccNetworkFirewallRuleGroup_tags
=== PAUSE TestAccNetworkFirewallRuleGroup_tags
=== RUN   TestAccNetworkFirewallRuleGroup_disappears
=== PAUSE TestAccNetworkFirewallRuleGroup_disappears
=== CONT  TestAccNetworkFirewallRuleGroup_Basic_rulesSourceList
=== CONT  TestAccNetworkFirewallRuleGroup_rulesSourceAndRuleVariables
=== CONT  TestAccNetworkFirewallRuleGroup_updateStatelessRule
=== CONT  TestAccNetworkFirewallRuleGroup_updateStatefulRule
=== CONT  TestAccNetworkFirewallRuleGroup_StatefulRule_header
=== CONT  TestAccNetworkFirewallRuleGroup_disappears
=== CONT  TestAccNetworkFirewallRuleGroup_tags
=== CONT  TestAccNetworkFirewallRuleGroup_StatefulRule_action
=== CONT  TestAccNetworkFirewallRuleGroup_updateMultipleStatefulRules
=== CONT  TestAccNetworkFirewallRuleGroup_updateStatefulRuleOptions
=== CONT  TestAccNetworkFirewallRuleGroup_statelessRuleWithCustomAction
=== CONT  TestAccNetworkFirewallRuleGroup_updateRulesSourceList
=== CONT  TestAccNetworkFirewallRuleGroup_updateRules
=== CONT  TestAccNetworkFirewallRuleGroup_Basic_rules
=== CONT  TestAccNetworkFirewallRuleGroup_statefulRuleOptions
=== CONT  TestAccNetworkFirewallRuleGroup_Basic_statelessRule
=== CONT  TestAccNetworkFirewallRuleGroup_Basic_statefulRule
--- PASS: TestAccNetworkFirewallRuleGroup_disappears (155.61s)
--- PASS: TestAccNetworkFirewallRuleGroup_updateRules (155.99s)
--- PASS: TestAccNetworkFirewallRuleGroup_tags (158.16s)
--- PASS: TestAccNetworkFirewallRuleGroup_Basic_rulesSourceList (159.19s)
--- PASS: TestAccNetworkFirewallRuleGroup_updateStatelessRule (159.62s)
--- PASS: TestAccNetworkFirewallRuleGroup_Basic_statefulRule (159.71s)
--- PASS: TestAccNetworkFirewallRuleGroup_statefulRuleOptions (159.82s)
--- PASS: TestAccNetworkFirewallRuleGroup_Basic_rules (160.77s)
--- PASS: TestAccNetworkFirewallRuleGroup_updateRulesSourceList (161.50s)
--- PASS: TestAccNetworkFirewallRuleGroup_updateStatefulRule (163.65s)
--- PASS: TestAccNetworkFirewallRuleGroup_StatefulRule_header (166.11s)
--- PASS: TestAccNetworkFirewallRuleGroup_Basic_statelessRule (167.31s)
--- PASS: TestAccNetworkFirewallRuleGroup_statelessRuleWithCustomAction (168.93s)
--- PASS: TestAccNetworkFirewallRuleGroup_StatefulRule_action (186.82s)
--- PASS: TestAccNetworkFirewallRuleGroup_rulesSourceAndRuleVariables (190.24s)
--- PASS: TestAccNetworkFirewallRuleGroup_updateMultipleStatefulRules (191.18s)
--- PASS: TestAccNetworkFirewallRuleGroup_updateStatefulRuleOptions (315.02s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/networkfirewall	316.769s

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. service/networkfirewall Issues and PRs that pertain to the networkfirewall service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. needs-triage Waiting for first response or review from a maintainer. size/XL Managed by automation to categorize the size of a PR. labels Nov 29, 2021
@stuwil stuwil force-pushed the f-aws_networkfirewall-strict-ordering branch from 65b0837 to 92928c0 Compare November 29, 2021 23:35
@stuwil stuwil changed the title r/networkfirewall_firewall_(policy|rule_group) strict stateful support r/networkfirewall_firewall_(policy|rule_group) stateful rule ordering Nov 29, 2021
github-actions[bot]
github-actions bot reviewed Nov 29, 2021
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @stuwil 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@stuwil stuwil marked this pull request as ready for review November 29, 2021 23:45
@cgswong
Copy link

cgswong commented Dec 1, 2021

Can this be reviewed and merged as a priority please? I have a customer blocked waiting on this capability 😅

@Tailzip
Copy link
Contributor

Tailzip commented Dec 1, 2021

Thanks for this PR, would love to see this merged as well! 😄

@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Dec 9, 2021
ewbankkit
ewbankkit approved these changes Dec 10, 2021
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

Commercial
% make testacc TESTARGS='-run=TestAccNetworkFirewallFirewallPolicy_\|TestAccNetworkFirewallRuleGroup_' PKG=networkfirewall
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/networkfirewall/... -v -count 1 -parallel 20 -run=TestAccNetworkFirewallFirewallPolicy_\|TestAccNetworkFirewallRuleGroup_ -timeout 180m
=== RUN   TestAccNetworkFirewallFirewallPolicy_basic
=== PAUSE TestAccNetworkFirewallFirewallPolicy_basic
=== RUN   TestAccNetworkFirewallFirewallPolicy_statefulDefaultActions
=== PAUSE TestAccNetworkFirewallFirewallPolicy_statefulDefaultActions
=== RUN   TestAccNetworkFirewallFirewallPolicy_statefulEngineOption
=== PAUSE TestAccNetworkFirewallFirewallPolicy_statefulEngineOption
=== RUN   TestAccNetworkFirewallFirewallPolicy_updateStatefulEngineOption
=== PAUSE TestAccNetworkFirewallFirewallPolicy_updateStatefulEngineOption
=== RUN   TestAccNetworkFirewallFirewallPolicy_statefulRuleGroupReference
=== PAUSE TestAccNetworkFirewallFirewallPolicy_statefulRuleGroupReference
=== RUN   TestAccNetworkFirewallFirewallPolicy_updateStatefulRuleGroupReference
=== PAUSE TestAccNetworkFirewallFirewallPolicy_updateStatefulRuleGroupReference
=== RUN   TestAccNetworkFirewallFirewallPolicy_multipleStatefulRuleGroupReferences
=== PAUSE TestAccNetworkFirewallFirewallPolicy_multipleStatefulRuleGroupReferences
=== RUN   TestAccNetworkFirewallFirewallPolicy_statefulRuleGroupPriorityReference
=== PAUSE TestAccNetworkFirewallFirewallPolicy_statefulRuleGroupPriorityReference
=== RUN   TestAccNetworkFirewallFirewallPolicy_updateStatefulRuleGroupPriorityReference
=== PAUSE TestAccNetworkFirewallFirewallPolicy_updateStatefulRuleGroupPriorityReference
=== RUN   TestAccNetworkFirewallFirewallPolicy_statelessRuleGroupReference
=== PAUSE TestAccNetworkFirewallFirewallPolicy_statelessRuleGroupReference
=== RUN   TestAccNetworkFirewallFirewallPolicy_updateStatelessRuleGroupReference
=== PAUSE TestAccNetworkFirewallFirewallPolicy_updateStatelessRuleGroupReference
=== RUN   TestAccNetworkFirewallFirewallPolicy_multipleStatelessRuleGroupReferences
=== PAUSE TestAccNetworkFirewallFirewallPolicy_multipleStatelessRuleGroupReferences
=== RUN   TestAccNetworkFirewallFirewallPolicy_statelessCustomAction
=== PAUSE TestAccNetworkFirewallFirewallPolicy_statelessCustomAction
=== RUN   TestAccNetworkFirewallFirewallPolicy_updateStatelessCustomAction
=== PAUSE TestAccNetworkFirewallFirewallPolicy_updateStatelessCustomAction
=== RUN   TestAccNetworkFirewallFirewallPolicy_multipleStatelessCustomActions
=== PAUSE TestAccNetworkFirewallFirewallPolicy_multipleStatelessCustomActions
=== RUN   TestAccNetworkFirewallFirewallPolicy_statefulRuleGroupReferenceAndCustomAction
=== PAUSE TestAccNetworkFirewallFirewallPolicy_statefulRuleGroupReferenceAndCustomAction
=== RUN   TestAccNetworkFirewallFirewallPolicy_tags
=== PAUSE TestAccNetworkFirewallFirewallPolicy_tags
=== RUN   TestAccNetworkFirewallFirewallPolicy_disappears
=== PAUSE TestAccNetworkFirewallFirewallPolicy_disappears
=== RUN   TestAccNetworkFirewallRuleGroup_Basic_rulesSourceList
=== PAUSE TestAccNetworkFirewallRuleGroup_Basic_rulesSourceList
=== RUN   TestAccNetworkFirewallRuleGroup_Basic_statefulRule
=== PAUSE TestAccNetworkFirewallRuleGroup_Basic_statefulRule
=== RUN   TestAccNetworkFirewallRuleGroup_Basic_statelessRule
=== PAUSE TestAccNetworkFirewallRuleGroup_Basic_statelessRule
=== RUN   TestAccNetworkFirewallRuleGroup_Basic_rules
=== PAUSE TestAccNetworkFirewallRuleGroup_Basic_rules
=== RUN   TestAccNetworkFirewallRuleGroup_statefulRuleOptions
=== PAUSE TestAccNetworkFirewallRuleGroup_statefulRuleOptions
=== RUN   TestAccNetworkFirewallRuleGroup_updateStatefulRuleOptions
=== PAUSE TestAccNetworkFirewallRuleGroup_updateStatefulRuleOptions
=== RUN   TestAccNetworkFirewallRuleGroup_statelessRuleWithCustomAction
=== PAUSE TestAccNetworkFirewallRuleGroup_statelessRuleWithCustomAction
=== RUN   TestAccNetworkFirewallRuleGroup_updateRules
=== PAUSE TestAccNetworkFirewallRuleGroup_updateRules
=== RUN   TestAccNetworkFirewallRuleGroup_updateRulesSourceList
=== PAUSE TestAccNetworkFirewallRuleGroup_updateRulesSourceList
=== RUN   TestAccNetworkFirewallRuleGroup_rulesSourceAndRuleVariables
=== PAUSE TestAccNetworkFirewallRuleGroup_rulesSourceAndRuleVariables
=== RUN   TestAccNetworkFirewallRuleGroup_updateStatefulRule
=== PAUSE TestAccNetworkFirewallRuleGroup_updateStatefulRule
=== RUN   TestAccNetworkFirewallRuleGroup_updateMultipleStatefulRules
=== PAUSE TestAccNetworkFirewallRuleGroup_updateMultipleStatefulRules
=== RUN   TestAccNetworkFirewallRuleGroup_StatefulRule_action
=== PAUSE TestAccNetworkFirewallRuleGroup_StatefulRule_action
=== RUN   TestAccNetworkFirewallRuleGroup_StatefulRule_header
=== PAUSE TestAccNetworkFirewallRuleGroup_StatefulRule_header
=== RUN   TestAccNetworkFirewallRuleGroup_updateStatelessRule
=== PAUSE TestAccNetworkFirewallRuleGroup_updateStatelessRule
=== RUN   TestAccNetworkFirewallRuleGroup_tags
=== PAUSE TestAccNetworkFirewallRuleGroup_tags
=== RUN   TestAccNetworkFirewallRuleGroup_disappears
=== PAUSE TestAccNetworkFirewallRuleGroup_disappears
=== CONT  TestAccNetworkFirewallFirewallPolicy_basic
=== CONT  TestAccNetworkFirewallRuleGroup_statelessRuleWithCustomAction
=== CONT  TestAccNetworkFirewallRuleGroup_disappears
=== CONT  TestAccNetworkFirewallFirewallPolicy_statelessCustomAction
=== CONT  TestAccNetworkFirewallFirewallPolicy_updateStatefulEngineOption
=== CONT  TestAccNetworkFirewallRuleGroup_StatefulRule_action
=== CONT  TestAccNetworkFirewallRuleGroup_updateStatelessRule
=== CONT  TestAccNetworkFirewallRuleGroup_StatefulRule_header
=== CONT  TestAccNetworkFirewallFirewallPolicy_multipleStatefulRuleGroupReferences
=== CONT  TestAccNetworkFirewallFirewallPolicy_multipleStatelessRuleGroupReferences
=== CONT  TestAccNetworkFirewallFirewallPolicy_updateStatelessRuleGroupReference
=== CONT  TestAccNetworkFirewallFirewallPolicy_statelessRuleGroupReference
=== CONT  TestAccNetworkFirewallFirewallPolicy_updateStatefulRuleGroupPriorityReference
=== CONT  TestAccNetworkFirewallRuleGroup_tags
=== CONT  TestAccNetworkFirewallRuleGroup_updateMultipleStatefulRules
=== CONT  TestAccNetworkFirewallRuleGroup_updateStatefulRule
=== CONT  TestAccNetworkFirewallRuleGroup_rulesSourceAndRuleVariables
=== CONT  TestAccNetworkFirewallRuleGroup_updateRulesSourceList
=== CONT  TestAccNetworkFirewallFirewallPolicy_statefulRuleGroupPriorityReference
=== CONT  TestAccNetworkFirewallRuleGroup_updateRules
--- PASS: TestAccNetworkFirewallFirewallPolicy_basic (140.06s)
=== CONT  TestAccNetworkFirewallFirewallPolicy_updateStatefulRuleGroupReference
--- PASS: TestAccNetworkFirewallFirewallPolicy_statelessCustomAction (142.17s)
=== CONT  TestAccNetworkFirewallFirewallPolicy_statefulEngineOption
--- PASS: TestAccNetworkFirewallRuleGroup_tags (150.44s)
=== CONT  TestAccNetworkFirewallRuleGroup_Basic_rulesSourceList
--- PASS: TestAccNetworkFirewallRuleGroup_disappears (153.16s)
=== CONT  TestAccNetworkFirewallRuleGroup_updateStatefulRuleOptions
--- PASS: TestAccNetworkFirewallRuleGroup_statelessRuleWithCustomAction (155.92s)
=== CONT  TestAccNetworkFirewallRuleGroup_statefulRuleOptions
--- PASS: TestAccNetworkFirewallRuleGroup_updateStatelessRule (171.14s)
=== CONT  TestAccNetworkFirewallRuleGroup_Basic_rules
--- PASS: TestAccNetworkFirewallRuleGroup_updateRules (175.92s)
=== CONT  TestAccNetworkFirewallRuleGroup_Basic_statelessRule
--- PASS: TestAccNetworkFirewallRuleGroup_StatefulRule_header (176.94s)
=== CONT  TestAccNetworkFirewallRuleGroup_Basic_statefulRule
--- PASS: TestAccNetworkFirewallRuleGroup_updateRulesSourceList (178.62s)
=== CONT  TestAccNetworkFirewallFirewallPolicy_statefulRuleGroupReferenceAndCustomAction
--- PASS: TestAccNetworkFirewallRuleGroup_updateStatefulRule (179.71s)
=== CONT  TestAccNetworkFirewallFirewallPolicy_disappears
--- PASS: TestAccNetworkFirewallFirewallPolicy_multipleStatelessRuleGroupReferences (198.49s)
=== CONT  TestAccNetworkFirewallFirewallPolicy_tags
--- PASS: TestAccNetworkFirewallFirewallPolicy_statelessRuleGroupReference (201.66s)
=== CONT  TestAccNetworkFirewallFirewallPolicy_statefulDefaultActions
--- PASS: TestAccNetworkFirewallFirewallPolicy_updateStatelessRuleGroupReference (207.09s)
=== CONT  TestAccNetworkFirewallFirewallPolicy_multipleStatelessCustomActions
--- PASS: TestAccNetworkFirewallFirewallPolicy_multipleStatefulRuleGroupReferences (209.92s)
=== CONT  TestAccNetworkFirewallFirewallPolicy_updateStatelessCustomAction
--- PASS: TestAccNetworkFirewallFirewallPolicy_updateStatefulRuleGroupPriorityReference (210.73s)
=== CONT  TestAccNetworkFirewallFirewallPolicy_statefulRuleGroupReference
--- PASS: TestAccNetworkFirewallRuleGroup_rulesSourceAndRuleVariables (212.85s)
--- PASS: TestAccNetworkFirewallRuleGroup_updateMultipleStatefulRules (215.06s)
--- PASS: TestAccNetworkFirewallFirewallPolicy_statefulRuleGroupPriorityReference (215.14s)
--- PASS: TestAccNetworkFirewallRuleGroup_StatefulRule_action (215.19s)
--- PASS: TestAccNetworkFirewallRuleGroup_Basic_rulesSourceList (134.06s)
--- PASS: TestAccNetworkFirewallFirewallPolicy_statefulEngineOption (144.58s)
--- PASS: TestAccNetworkFirewallFirewallPolicy_updateStatefulRuleGroupReference (167.52s)
--- PASS: TestAccNetworkFirewallRuleGroup_Basic_rules (136.74s)
--- PASS: TestAccNetworkFirewallRuleGroup_statefulRuleOptions (154.82s)
--- PASS: TestAccNetworkFirewallFirewallPolicy_updateStatefulEngineOption (312.24s)
--- PASS: TestAccNetworkFirewallRuleGroup_Basic_statefulRule (136.04s)
--- PASS: TestAccNetworkFirewallFirewallPolicy_disappears (145.48s)
--- PASS: TestAccNetworkFirewallRuleGroup_Basic_statelessRule (157.98s)
--- PASS: TestAccNetworkFirewallFirewallPolicy_tags (148.80s)
--- PASS: TestAccNetworkFirewallFirewallPolicy_statefulDefaultActions (148.04s)
--- PASS: TestAccNetworkFirewallFirewallPolicy_statefulRuleGroupReference (188.20s)
--- PASS: TestAccNetworkFirewallRuleGroup_updateStatefulRuleOptions (309.25s)
--- PASS: TestAccNetworkFirewallFirewallPolicy_multipleStatelessCustomActions (281.46s)
--- PASS: TestAccNetworkFirewallFirewallPolicy_statefulRuleGroupReferenceAndCustomAction (310.12s)
--- PASS: TestAccNetworkFirewallFirewallPolicy_updateStatelessCustomAction (606.24s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/networkfirewall	819.512s
GovCloud
% make testacc TESTARGS='-run=TestAccNetworkFirewallFirewallPolicy_\|TestAccNetworkFirewallRuleGroup_' PKG=networkfirewall
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/networkfirewall/... -v -count 1 -parallel 20 -run=TestAccNetworkFirewallFirewallPolicy_\|TestAccNetworkFirewallRuleGroup_ -timeout 180m
=== RUN   TestAccNetworkFirewallFirewallPolicy_basic
=== PAUSE TestAccNetworkFirewallFirewallPolicy_basic
=== RUN   TestAccNetworkFirewallFirewallPolicy_statefulDefaultActions
=== PAUSE TestAccNetworkFirewallFirewallPolicy_statefulDefaultActions
=== RUN   TestAccNetworkFirewallFirewallPolicy_statefulEngineOption
=== PAUSE TestAccNetworkFirewallFirewallPolicy_statefulEngineOption
=== RUN   TestAccNetworkFirewallFirewallPolicy_updateStatefulEngineOption
=== PAUSE TestAccNetworkFirewallFirewallPolicy_updateStatefulEngineOption
=== RUN   TestAccNetworkFirewallFirewallPolicy_statefulRuleGroupReference
=== PAUSE TestAccNetworkFirewallFirewallPolicy_statefulRuleGroupReference
=== RUN   TestAccNetworkFirewallFirewallPolicy_updateStatefulRuleGroupReference
=== PAUSE TestAccNetworkFirewallFirewallPolicy_updateStatefulRuleGroupReference
=== RUN   TestAccNetworkFirewallFirewallPolicy_multipleStatefulRuleGroupReferences
=== PAUSE TestAccNetworkFirewallFirewallPolicy_multipleStatefulRuleGroupReferences
=== RUN   TestAccNetworkFirewallFirewallPolicy_statefulRuleGroupPriorityReference
=== PAUSE TestAccNetworkFirewallFirewallPolicy_statefulRuleGroupPriorityReference
=== RUN   TestAccNetworkFirewallFirewallPolicy_updateStatefulRuleGroupPriorityReference
=== PAUSE TestAccNetworkFirewallFirewallPolicy_updateStatefulRuleGroupPriorityReference
=== RUN   TestAccNetworkFirewallFirewallPolicy_statelessRuleGroupReference
=== PAUSE TestAccNetworkFirewallFirewallPolicy_statelessRuleGroupReference
=== RUN   TestAccNetworkFirewallFirewallPolicy_updateStatelessRuleGroupReference
=== PAUSE TestAccNetworkFirewallFirewallPolicy_updateStatelessRuleGroupReference
=== RUN   TestAccNetworkFirewallFirewallPolicy_multipleStatelessRuleGroupReferences
=== PAUSE TestAccNetworkFirewallFirewallPolicy_multipleStatelessRuleGroupReferences
=== RUN   TestAccNetworkFirewallFirewallPolicy_statelessCustomAction
=== PAUSE TestAccNetworkFirewallFirewallPolicy_statelessCustomAction
=== RUN   TestAccNetworkFirewallFirewallPolicy_updateStatelessCustomAction
=== PAUSE TestAccNetworkFirewallFirewallPolicy_updateStatelessCustomAction
=== RUN   TestAccNetworkFirewallFirewallPolicy_multipleStatelessCustomActions
=== PAUSE TestAccNetworkFirewallFirewallPolicy_multipleStatelessCustomActions
=== RUN   TestAccNetworkFirewallFirewallPolicy_statefulRuleGroupReferenceAndCustomAction
=== PAUSE TestAccNetworkFirewallFirewallPolicy_statefulRuleGroupReferenceAndCustomAction
=== RUN   TestAccNetworkFirewallFirewallPolicy_tags
=== PAUSE TestAccNetworkFirewallFirewallPolicy_tags
=== RUN   TestAccNetworkFirewallFirewallPolicy_disappears
=== PAUSE TestAccNetworkFirewallFirewallPolicy_disappears
=== RUN   TestAccNetworkFirewallRuleGroup_Basic_rulesSourceList
=== PAUSE TestAccNetworkFirewallRuleGroup_Basic_rulesSourceList
=== RUN   TestAccNetworkFirewallRuleGroup_Basic_statefulRule
=== PAUSE TestAccNetworkFirewallRuleGroup_Basic_statefulRule
=== RUN   TestAccNetworkFirewallRuleGroup_Basic_statelessRule
=== PAUSE TestAccNetworkFirewallRuleGroup_Basic_statelessRule
=== RUN   TestAccNetworkFirewallRuleGroup_Basic_rules
=== PAUSE TestAccNetworkFirewallRuleGroup_Basic_rules
=== RUN   TestAccNetworkFirewallRuleGroup_statefulRuleOptions
=== PAUSE TestAccNetworkFirewallRuleGroup_statefulRuleOptions
=== RUN   TestAccNetworkFirewallRuleGroup_updateStatefulRuleOptions
=== PAUSE TestAccNetworkFirewallRuleGroup_updateStatefulRuleOptions
=== RUN   TestAccNetworkFirewallRuleGroup_statelessRuleWithCustomAction
=== PAUSE TestAccNetworkFirewallRuleGroup_statelessRuleWithCustomAction
=== RUN   TestAccNetworkFirewallRuleGroup_updateRules
=== PAUSE TestAccNetworkFirewallRuleGroup_updateRules
=== RUN   TestAccNetworkFirewallRuleGroup_updateRulesSourceList
=== PAUSE TestAccNetworkFirewallRuleGroup_updateRulesSourceList
=== RUN   TestAccNetworkFirewallRuleGroup_rulesSourceAndRuleVariables
=== PAUSE TestAccNetworkFirewallRuleGroup_rulesSourceAndRuleVariables
=== RUN   TestAccNetworkFirewallRuleGroup_updateStatefulRule
=== PAUSE TestAccNetworkFirewallRuleGroup_updateStatefulRule
=== RUN   TestAccNetworkFirewallRuleGroup_updateMultipleStatefulRules
=== PAUSE TestAccNetworkFirewallRuleGroup_updateMultipleStatefulRules
=== RUN   TestAccNetworkFirewallRuleGroup_StatefulRule_action
=== PAUSE TestAccNetworkFirewallRuleGroup_StatefulRule_action
=== RUN   TestAccNetworkFirewallRuleGroup_StatefulRule_header
=== PAUSE TestAccNetworkFirewallRuleGroup_StatefulRule_header
=== RUN   TestAccNetworkFirewallRuleGroup_updateStatelessRule
=== PAUSE TestAccNetworkFirewallRuleGroup_updateStatelessRule
=== RUN   TestAccNetworkFirewallRuleGroup_tags
=== PAUSE TestAccNetworkFirewallRuleGroup_tags
=== RUN   TestAccNetworkFirewallRuleGroup_disappears
=== PAUSE TestAccNetworkFirewallRuleGroup_disappears
=== CONT  TestAccNetworkFirewallFirewallPolicy_basic
=== CONT  TestAccNetworkFirewallRuleGroup_Basic_rulesSourceList
=== CONT  TestAccNetworkFirewallFirewallPolicy_disappears
=== CONT  TestAccNetworkFirewallFirewallPolicy_updateStatelessCustomAction
=== CONT  TestAccNetworkFirewallFirewallPolicy_tags
=== CONT  TestAccNetworkFirewallFirewallPolicy_statefulRuleGroupReferenceAndCustomAction
=== CONT  TestAccNetworkFirewallFirewallPolicy_multipleStatelessCustomActions
=== CONT  TestAccNetworkFirewallFirewallPolicy_statelessRuleGroupReference
=== CONT  TestAccNetworkFirewallFirewallPolicy_statelessCustomAction
=== CONT  TestAccNetworkFirewallFirewallPolicy_updateStatefulRuleGroupReference
=== CONT  TestAccNetworkFirewallFirewallPolicy_updateStatefulRuleGroupPriorityReference
=== CONT  TestAccNetworkFirewallFirewallPolicy_statefulRuleGroupPriorityReference
=== CONT  TestAccNetworkFirewallRuleGroup_disappears
=== CONT  TestAccNetworkFirewallRuleGroup_tags
=== CONT  TestAccNetworkFirewallRuleGroup_updateStatelessRule
=== CONT  TestAccNetworkFirewallRuleGroup_StatefulRule_header
=== CONT  TestAccNetworkFirewallRuleGroup_StatefulRule_action
=== CONT  TestAccNetworkFirewallRuleGroup_updateMultipleStatefulRules
=== CONT  TestAccNetworkFirewallFirewallPolicy_multipleStatelessRuleGroupReferences
=== CONT  TestAccNetworkFirewallFirewallPolicy_multipleStatefulRuleGroupReferences
=== CONT  TestAccNetworkFirewallRuleGroup_disappears
    firewall_test.go:368: skipping acceptance testing: RequestError: send request failed
        caused by: Post "https://network-firewall.us-gov-west-1.amazonaws.com/": dial tcp: lookup network-firewall.us-gov-west-1.amazonaws.com: no such host
--- SKIP: TestAccNetworkFirewallRuleGroup_disappears (20.61s)
=== CONT  TestAccNetworkFirewallRuleGroup_updateStatefulRule
=== CONT  TestAccNetworkFirewallFirewallPolicy_updateStatelessCustomAction
    firewall_test.go:368: skipping acceptance testing: RequestError: send request failed
        caused by: Post "https://network-firewall.us-gov-west-1.amazonaws.com/": dial tcp: lookup network-firewall.us-gov-west-1.amazonaws.com: no such host
--- SKIP: TestAccNetworkFirewallFirewallPolicy_updateStatelessCustomAction (21.21s)
=== CONT  TestAccNetworkFirewallRuleGroup_rulesSourceAndRuleVariables
=== CONT  TestAccNetworkFirewallFirewallPolicy_statelessRuleGroupReference
    firewall_test.go:368: skipping acceptance testing: RequestError: send request failed
        caused by: Post "https://network-firewall.us-gov-west-1.amazonaws.com/": dial tcp: lookup network-firewall.us-gov-west-1.amazonaws.com: no such host
--- SKIP: TestAccNetworkFirewallFirewallPolicy_statelessRuleGroupReference (21.49s)
=== CONT  TestAccNetworkFirewallRuleGroup_updateRulesSourceList
=== CONT  TestAccNetworkFirewallFirewallPolicy_basic
    firewall_test.go:368: skipping acceptance testing: RequestError: send request failed
        caused by: Post "https://network-firewall.us-gov-west-1.amazonaws.com/": dial tcp: lookup network-firewall.us-gov-west-1.amazonaws.com: no such host
--- SKIP: TestAccNetworkFirewallFirewallPolicy_basic (21.86s)
=== CONT  TestAccNetworkFirewallRuleGroup_updateRules
=== CONT  TestAccNetworkFirewallFirewallPolicy_multipleStatefulRuleGroupReferences
    firewall_test.go:368: skipping acceptance testing: RequestError: send request failed
        caused by: Post "https://network-firewall.us-gov-west-1.amazonaws.com/": dial tcp: lookup network-firewall.us-gov-west-1.amazonaws.com: no such host
--- SKIP: TestAccNetworkFirewallFirewallPolicy_multipleStatefulRuleGroupReferences (21.91s)
=== CONT  TestAccNetworkFirewallRuleGroup_statelessRuleWithCustomAction
=== CONT  TestAccNetworkFirewallRuleGroup_updateStatelessRule
    firewall_test.go:368: skipping acceptance testing: RequestError: send request failed
        caused by: Post "https://network-firewall.us-gov-west-1.amazonaws.com/": dial tcp: lookup network-firewall.us-gov-west-1.amazonaws.com: no such host
--- SKIP: TestAccNetworkFirewallRuleGroup_updateStatelessRule (22.42s)
=== CONT  TestAccNetworkFirewallRuleGroup_updateStatefulRuleOptions
=== CONT  TestAccNetworkFirewallFirewallPolicy_statefulRuleGroupReferenceAndCustomAction
    firewall_test.go:368: skipping acceptance testing: RequestError: send request failed
        caused by: Post "https://network-firewall.us-gov-west-1.amazonaws.com/": dial tcp: lookup network-firewall.us-gov-west-1.amazonaws.com: no such host
--- SKIP: TestAccNetworkFirewallFirewallPolicy_statefulRuleGroupReferenceAndCustomAction (23.34s)
=== CONT  TestAccNetworkFirewallRuleGroup_statefulRuleOptions
=== CONT  TestAccNetworkFirewallRuleGroup_tags
    firewall_test.go:368: skipping acceptance testing: RequestError: send request failed
        caused by: Post "https://network-firewall.us-gov-west-1.amazonaws.com/": dial tcp: lookup network-firewall.us-gov-west-1.amazonaws.com: no such host
--- SKIP: TestAccNetworkFirewallRuleGroup_tags (24.47s)
=== CONT  TestAccNetworkFirewallRuleGroup_Basic_rules
=== CONT  TestAccNetworkFirewallRuleGroup_updateMultipleStatefulRules
    firewall_test.go:368: skipping acceptance testing: RequestError: send request failed
        caused by: Post "https://network-firewall.us-gov-west-1.amazonaws.com/": dial tcp: lookup network-firewall.us-gov-west-1.amazonaws.com: no such host
--- SKIP: TestAccNetworkFirewallRuleGroup_updateMultipleStatefulRules (25.29s)
=== CONT  TestAccNetworkFirewallRuleGroup_Basic_statelessRule
=== CONT  TestAccNetworkFirewallRuleGroup_StatefulRule_header
    firewall_test.go:368: skipping acceptance testing: RequestError: send request failed
        caused by: Post "https://network-firewall.us-gov-west-1.amazonaws.com/": dial tcp: lookup network-firewall.us-gov-west-1.amazonaws.com: no such host
--- SKIP: TestAccNetworkFirewallRuleGroup_StatefulRule_header (25.34s)
=== CONT  TestAccNetworkFirewallRuleGroup_Basic_statefulRule
=== CONT  TestAccNetworkFirewallFirewallPolicy_statefulRuleGroupPriorityReference
    firewall_test.go:368: skipping acceptance testing: RequestError: send request failed
        caused by: Post "https://network-firewall.us-gov-west-1.amazonaws.com/": dial tcp: lookup network-firewall.us-gov-west-1.amazonaws.com: no such host
--- SKIP: TestAccNetworkFirewallFirewallPolicy_statefulRuleGroupPriorityReference (26.24s)
=== CONT  TestAccNetworkFirewallFirewallPolicy_statefulEngineOption
=== CONT  TestAccNetworkFirewallFirewallPolicy_updateStatefulRuleGroupReference
    firewall_test.go:368: skipping acceptance testing: RequestError: send request failed
        caused by: Post "https://network-firewall.us-gov-west-1.amazonaws.com/": dial tcp: lookup network-firewall.us-gov-west-1.amazonaws.com: no such host
--- SKIP: TestAccNetworkFirewallFirewallPolicy_updateStatefulRuleGroupReference (26.38s)
=== CONT  TestAccNetworkFirewallFirewallPolicy_statefulRuleGroupReference
=== CONT  TestAccNetworkFirewallFirewallPolicy_multipleStatelessRuleGroupReferences
    firewall_test.go:368: skipping acceptance testing: RequestError: send request failed
        caused by: Post "https://network-firewall.us-gov-west-1.amazonaws.com/": dial tcp: lookup network-firewall.us-gov-west-1.amazonaws.com: no such host
--- SKIP: TestAccNetworkFirewallFirewallPolicy_multipleStatelessRuleGroupReferences (26.42s)
=== CONT  TestAccNetworkFirewallFirewallPolicy_updateStatelessRuleGroupReference
=== CONT  TestAccNetworkFirewallRuleGroup_StatefulRule_action
    firewall_test.go:368: skipping acceptance testing: RequestError: send request failed
        caused by: Post "https://network-firewall.us-gov-west-1.amazonaws.com/": dial tcp: lookup network-firewall.us-gov-west-1.amazonaws.com: no such host
--- SKIP: TestAccNetworkFirewallRuleGroup_StatefulRule_action (26.46s)
=== CONT  TestAccNetworkFirewallFirewallPolicy_statefulDefaultActions
=== CONT  TestAccNetworkFirewallFirewallPolicy_tags
    firewall_test.go:368: skipping acceptance testing: RequestError: send request failed
        caused by: Post "https://network-firewall.us-gov-west-1.amazonaws.com/": dial tcp: lookup network-firewall.us-gov-west-1.amazonaws.com: no such host
--- SKIP: TestAccNetworkFirewallFirewallPolicy_tags (26.55s)
=== CONT  TestAccNetworkFirewallFirewallPolicy_updateStatefulEngineOption
=== CONT  TestAccNetworkFirewallFirewallPolicy_multipleStatelessCustomActions
    firewall_test.go:368: skipping acceptance testing: RequestError: send request failed
        caused by: Post "https://network-firewall.us-gov-west-1.amazonaws.com/": dial tcp: lookup network-firewall.us-gov-west-1.amazonaws.com: no such host
--- SKIP: TestAccNetworkFirewallFirewallPolicy_multipleStatelessCustomActions (26.67s)
=== CONT  TestAccNetworkFirewallFirewallPolicy_updateStatefulRuleGroupPriorityReference
    firewall_test.go:368: skipping acceptance testing: RequestError: send request failed
        caused by: Post "https://network-firewall.us-gov-west-1.amazonaws.com/": dial tcp: lookup network-firewall.us-gov-west-1.amazonaws.com: no such host
--- SKIP: TestAccNetworkFirewallFirewallPolicy_updateStatefulRuleGroupPriorityReference (27.87s)
=== CONT  TestAccNetworkFirewallFirewallPolicy_statelessCustomAction
    firewall_test.go:368: skipping acceptance testing: RequestError: send request failed
        caused by: Post "https://network-firewall.us-gov-west-1.amazonaws.com/": dial tcp: lookup network-firewall.us-gov-west-1.amazonaws.com: no such host
--- SKIP: TestAccNetworkFirewallFirewallPolicy_statelessCustomAction (28.15s)
=== CONT  TestAccNetworkFirewallRuleGroup_Basic_rulesSourceList
    firewall_test.go:368: skipping acceptance testing: RequestError: send request failed
        caused by: Post "https://network-firewall.us-gov-west-1.amazonaws.com/": dial tcp: lookup network-firewall.us-gov-west-1.amazonaws.com: no such host
--- SKIP: TestAccNetworkFirewallRuleGroup_Basic_rulesSourceList (28.21s)
=== CONT  TestAccNetworkFirewallFirewallPolicy_disappears
    firewall_test.go:368: skipping acceptance testing: RequestError: send request failed
        caused by: Post "https://network-firewall.us-gov-west-1.amazonaws.com/": dial tcp: lookup network-firewall.us-gov-west-1.amazonaws.com: no such host
--- SKIP: TestAccNetworkFirewallFirewallPolicy_disappears (28.29s)
=== CONT  TestAccNetworkFirewallRuleGroup_statelessRuleWithCustomAction
    firewall_test.go:368: skipping acceptance testing: RequestError: send request failed
        caused by: Post "https://network-firewall.us-gov-west-1.amazonaws.com/": dial tcp: lookup network-firewall.us-gov-west-1.amazonaws.com: no such host
--- SKIP: TestAccNetworkFirewallRuleGroup_statelessRuleWithCustomAction (21.59s)
=== CONT  TestAccNetworkFirewallRuleGroup_rulesSourceAndRuleVariables
    firewall_test.go:368: skipping acceptance testing: RequestError: send request failed
        caused by: Post "https://network-firewall.us-gov-west-1.amazonaws.com/": dial tcp: lookup network-firewall.us-gov-west-1.amazonaws.com: no such host
--- SKIP: TestAccNetworkFirewallRuleGroup_rulesSourceAndRuleVariables (22.43s)
=== CONT  TestAccNetworkFirewallRuleGroup_updateRulesSourceList
    firewall_test.go:368: skipping acceptance testing: RequestError: send request failed
        caused by: Post "https://network-firewall.us-gov-west-1.amazonaws.com/": dial tcp: lookup network-firewall.us-gov-west-1.amazonaws.com: no such host
--- SKIP: TestAccNetworkFirewallRuleGroup_updateRulesSourceList (23.73s)
=== CONT  TestAccNetworkFirewallRuleGroup_updateRules
    firewall_test.go:368: skipping acceptance testing: RequestError: send request failed
        caused by: Post "https://network-firewall.us-gov-west-1.amazonaws.com/": dial tcp: lookup network-firewall.us-gov-west-1.amazonaws.com: no such host
--- SKIP: TestAccNetworkFirewallRuleGroup_updateRules (23.45s)
=== CONT  TestAccNetworkFirewallFirewallPolicy_statefulEngineOption
    firewall_test.go:368: skipping acceptance testing: RequestError: send request failed
        caused by: Post "https://network-firewall.us-gov-west-1.amazonaws.com/": dial tcp: lookup network-firewall.us-gov-west-1.amazonaws.com: no such host
--- SKIP: TestAccNetworkFirewallFirewallPolicy_statefulEngineOption (20.34s)
=== CONT  TestAccNetworkFirewallRuleGroup_updateStatefulRule
    firewall_test.go:368: skipping acceptance testing: RequestError: send request failed
        caused by: Post "https://network-firewall.us-gov-west-1.amazonaws.com/": dial tcp: lookup network-firewall.us-gov-west-1.amazonaws.com: no such host
--- SKIP: TestAccNetworkFirewallRuleGroup_updateStatefulRule (26.07s)
=== CONT  TestAccNetworkFirewallFirewallPolicy_updateStatelessRuleGroupReference
    firewall_test.go:368: skipping acceptance testing: RequestError: send request failed
        caused by: Post "https://network-firewall.us-gov-west-1.amazonaws.com/": dial tcp: lookup network-firewall.us-gov-west-1.amazonaws.com: no such host
--- SKIP: TestAccNetworkFirewallFirewallPolicy_updateStatelessRuleGroupReference (20.36s)
=== CONT  TestAccNetworkFirewallRuleGroup_statefulRuleOptions
    firewall_test.go:368: skipping acceptance testing: RequestError: send request failed
        caused by: Post "https://network-firewall.us-gov-west-1.amazonaws.com/": dial tcp: lookup network-firewall.us-gov-west-1.amazonaws.com: no such host
--- SKIP: TestAccNetworkFirewallRuleGroup_statefulRuleOptions (24.19s)
=== CONT  TestAccNetworkFirewallRuleGroup_Basic_statefulRule
    firewall_test.go:368: skipping acceptance testing: RequestError: send request failed
        caused by: Post "https://network-firewall.us-gov-west-1.amazonaws.com/": dial tcp: lookup network-firewall.us-gov-west-1.amazonaws.com: no such host
--- SKIP: TestAccNetworkFirewallRuleGroup_Basic_statefulRule (22.65s)
=== CONT  TestAccNetworkFirewallRuleGroup_Basic_rules
    firewall_test.go:368: skipping acceptance testing: RequestError: send request failed
        caused by: Post "https://network-firewall.us-gov-west-1.amazonaws.com/": dial tcp: lookup network-firewall.us-gov-west-1.amazonaws.com: no such host
--- SKIP: TestAccNetworkFirewallRuleGroup_Basic_rules (23.88s)
=== CONT  TestAccNetworkFirewallRuleGroup_updateStatefulRuleOptions
    firewall_test.go:368: skipping acceptance testing: RequestError: send request failed
        caused by: Post "https://network-firewall.us-gov-west-1.amazonaws.com/": dial tcp: lookup network-firewall.us-gov-west-1.amazonaws.com: no such host
--- SKIP: TestAccNetworkFirewallRuleGroup_updateStatefulRuleOptions (26.05s)
=== CONT  TestAccNetworkFirewallFirewallPolicy_statefulRuleGroupReference
    firewall_test.go:368: skipping acceptance testing: RequestError: send request failed
        caused by: Post "https://network-firewall.us-gov-west-1.amazonaws.com/": dial tcp: lookup network-firewall.us-gov-west-1.amazonaws.com: no such host
--- SKIP: TestAccNetworkFirewallFirewallPolicy_statefulRuleGroupReference (22.29s)
=== CONT  TestAccNetworkFirewallFirewallPolicy_statefulDefaultActions
    firewall_test.go:368: skipping acceptance testing: RequestError: send request failed
        caused by: Post "https://network-firewall.us-gov-west-1.amazonaws.com/": dial tcp: lookup network-firewall.us-gov-west-1.amazonaws.com: no such host
--- SKIP: TestAccNetworkFirewallFirewallPolicy_statefulDefaultActions (23.24s)
=== CONT  TestAccNetworkFirewallRuleGroup_Basic_statelessRule
    firewall_test.go:368: skipping acceptance testing: RequestError: send request failed
        caused by: Post "https://network-firewall.us-gov-west-1.amazonaws.com/": dial tcp: lookup network-firewall.us-gov-west-1.amazonaws.com: no such host
--- SKIP: TestAccNetworkFirewallRuleGroup_Basic_statelessRule (26.00s)
=== CONT  TestAccNetworkFirewallFirewallPolicy_updateStatefulEngineOption
    firewall_test.go:368: skipping acceptance testing: RequestError: send request failed
        caused by: Post "https://network-firewall.us-gov-west-1.amazonaws.com/": dial tcp: lookup network-firewall.us-gov-west-1.amazonaws.com: no such host
--- SKIP: TestAccNetworkFirewallFirewallPolicy_updateStatefulEngineOption (26.77s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/networkfirewall	56.997s

@ewbankkit
Copy link
Contributor

@stuwil Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit fdc45ab into hashicorp:main Dec 10, 2021
@github-actions github-actions bot added this to the v3.70.0 milestone Dec 10, 2021
@stuwil stuwil deleted the f-aws_networkfirewall-strict-ordering branch December 11, 2021 01:58
@github-actions
Copy link

This functionality has been released in v3.70.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Jun 1, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/networkfirewall Issues and PRs that pertain to the networkfirewall service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.70.0
Development

Successfully merging this pull request may close these issues.

AWS Network firewall ordering
5 participants
@stuwil @cgswong @Tailzip @ewbankkit @justinretzolk