r/sagemaker_project - new resource

[DrFaust92]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #21490

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccSageMakerProject_' PKG_NAME=internal/service/sagemaker
--- PASS: TestAccSageMakerProject_description (426.65s)
--- PASS: TestAccSageMakerProject_basic (427.42s)
--- PASS: TestAccSageMakerProject_tags (674.57s)
--- PASS: TestAccSageMakerProject_disappears (236.10s)

[DrFaust92]

Still trying to figure out how to allow sagemaker to find SC product

        Error: error creating SageMaker Project tf-acc-test-****: ValidationException: Product prod-xxxxxxxx does not exist or access was denied

edit:

managed to workaround the servicecatalog permissions model

[DrFaust92]

Update seems to be eventual consistent or just doesn't work.

        Terraform used the selected providers to generate the following execution
        plan. Resource actions are indicated with the following symbols:
          ~ update in-place
        
        Terraform will perform the following actions:
        
          # aws_sagemaker_project.test will be updated in-place
          ~ resource "aws_sagemaker_project" "test" {
                id                  = "tf-acc-test-681159631628448959"
              ~ project_description = "tf-acc-test-681159631628448959" -> "tf-acc-test-5355559471089804246"
                tags                = {}
                # (4 unchanged attributes hidden)
        
                # (1 unchanged block hidden)
            }

[ewbankkit]

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccSageMakerProject_' PKG_NAME=internal/service/sagemaker
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/sagemaker/... -v -count 1 -parallel 20 -run=TestAccSageMakerProject_ -timeout 180m
=== RUN   TestAccSageMakerProject_basic
=== PAUSE TestAccSageMakerProject_basic
=== RUN   TestAccSageMakerProject_description
=== PAUSE TestAccSageMakerProject_description
=== RUN   TestAccSageMakerProject_tags
=== PAUSE TestAccSageMakerProject_tags
=== RUN   TestAccSageMakerProject_disappears
=== PAUSE TestAccSageMakerProject_disappears
=== CONT  TestAccSageMakerProject_basic
=== CONT  TestAccSageMakerProject_tags
=== CONT  TestAccSageMakerProject_disappears
=== CONT  TestAccSageMakerProject_description
--- PASS: TestAccSageMakerProject_disappears (164.61s)
--- PASS: TestAccSageMakerProject_basic (194.46s)
--- PASS: TestAccSageMakerProject_description (278.19s)
--- PASS: TestAccSageMakerProject_tags (295.66s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/sagemaker	299.356s

[ewbankkit]

@DrFaust92 Thanks for the contribution 🎉 👏.

[github-actions]

This functionality has been released in v3.74.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.