Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adjust generators directives with bool flags and add conditional logic for header template #21333

Merged
merged 4 commits into from
Oct 18, 2021

Conversation

anGie44
Copy link
Contributor

@anGie44 anGie44 commented Oct 16, 2021

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #20000

Notes:

  • major changes here include:
    • appstream/generate.go: a directive for ListPages generation added to correctly match methods already present
    • directives in <service>/generate.go and <service>/list_pages_gen.go use boolean flags where the string "yes" was previously passed in to simplify usage; docs have been updated as well with the new usage
    • directives in <service>/generate.go no longer pass in a tags flag and generate command as they don't seem to influence file generation

Output from acceptance testing:

$ make gen --> returns no diff 
$ make --> installs successfully
$ make lint --> complains about magic number usage and methods not used 🤔 

@github-actions github-actions bot added the size/XL Managed by automation to categorize the size of a PR. label Oct 16, 2021
@anGie44 anGie44 marked this pull request as ready for review October 18, 2021 14:27
Copy link
Member

@YakDriver YakDriver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me! 🎉

@@ -18,11 +18,12 @@ import (
const filename = `tags_gen.go`

var (
getTag = flag.String("GetTag", "", "whether to generate GetTag")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! This is a much better way!

@anGie44 anGie44 added this to the v3.64.0 milestone Oct 18, 2021
@anGie44 anGie44 merged commit 34d89a5 into main Oct 18, 2021
@anGie44 anGie44 deleted the sp-make-gen branch October 18, 2021 17:09
@github-actions
Copy link

github-actions bot commented Nov 4, 2021

This functionality has been released in v3.64.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
size/XL Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants