d/iam_users - extract fetching logic to finder package

[kamilturek]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Output from acceptance testing:

$ make testacc TESTARGS="-run=TestAccAWSIAMUsersDataSource"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSIAMUsersDataSource -timeout 180m
=== RUN   TestAccAWSIAMUsersDataSource_nameRegex
=== PAUSE TestAccAWSIAMUsersDataSource_nameRegex
=== RUN   TestAccAWSIAMUsersDataSource_pathPrefix
=== PAUSE TestAccAWSIAMUsersDataSource_pathPrefix
=== RUN   TestAccAWSIAMUsersDataSource_nonExistentNameRegex
=== PAUSE TestAccAWSIAMUsersDataSource_nonExistentNameRegex
=== RUN   TestAccAWSIAMUsersDataSource_nonExistentPathPrefix
=== PAUSE TestAccAWSIAMUsersDataSource_nonExistentPathPrefix
=== CONT  TestAccAWSIAMUsersDataSource_nameRegex
=== CONT  TestAccAWSIAMUsersDataSource_nonExistentPathPrefix
=== CONT  TestAccAWSIAMUsersDataSource_nonExistentNameRegex
=== CONT  TestAccAWSIAMUsersDataSource_pathPrefix
--- PASS: TestAccAWSIAMUsersDataSource_nonExistentNameRegex (25.23s)
--- PASS: TestAccAWSIAMUsersDataSource_nonExistentPathPrefix (26.80s)
--- PASS: TestAccAWSIAMUsersDataSource_nameRegex (27.79s)
--- PASS: TestAccAWSIAMUsersDataSource_pathPrefix (27.79s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       35.631s

[ewbankkit]

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccAWSIAMUsersDataSource_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSIAMUsersDataSource_ -timeout 180m
=== RUN   TestAccAWSIAMUsersDataSource_nameRegex
=== PAUSE TestAccAWSIAMUsersDataSource_nameRegex
=== RUN   TestAccAWSIAMUsersDataSource_pathPrefix
=== PAUSE TestAccAWSIAMUsersDataSource_pathPrefix
=== RUN   TestAccAWSIAMUsersDataSource_nonExistentNameRegex
=== PAUSE TestAccAWSIAMUsersDataSource_nonExistentNameRegex
=== RUN   TestAccAWSIAMUsersDataSource_nonExistentPathPrefix
=== PAUSE TestAccAWSIAMUsersDataSource_nonExistentPathPrefix
=== CONT  TestAccAWSIAMUsersDataSource_nameRegex
=== CONT  TestAccAWSIAMUsersDataSource_nonExistentPathPrefix
=== CONT  TestAccAWSIAMUsersDataSource_nonExistentNameRegex
=== CONT  TestAccAWSIAMUsersDataSource_pathPrefix
--- PASS: TestAccAWSIAMUsersDataSource_nonExistentPathPrefix (9.46s)
--- PASS: TestAccAWSIAMUsersDataSource_nonExistentNameRegex (9.51s)
--- PASS: TestAccAWSIAMUsersDataSource_nameRegex (11.84s)
--- PASS: TestAccAWSIAMUsersDataSource_pathPrefix (11.92s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	15.096s

[ewbankkit]

@kamilturek Thanks for the contribution 🎉 👏.

[github-actions]

This functionality has been released in v3.62.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.