Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

d/aws_eks_clusters: New data source #20883

Merged
merged 8 commits into from
Sep 13, 2021
Merged

d/aws_eks_clusters: New data source #20883

merged 8 commits into from
Sep 13, 2021

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Sep 13, 2021

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #20251.
Closes #13719.
Supersedes #20315.
Supersedes #15204.

Output from acceptance testing:

Commercial

% make testacc TESTARGS='-run=TestAccAWSEksClustersDataSource_'

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSEksClustersDataSource_ -timeout 180m
=== RUN   TestAccAWSEksClustersDataSource_basic
=== PAUSE TestAccAWSEksClustersDataSource_basic
=== CONT  TestAccAWSEksClustersDataSource_basic
--- PASS: TestAccAWSEksClustersDataSource_basic (918.75s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	923.589s

GovCloud

% make testacc TESTARGS='-run=TestAccAWSEksClustersDataSource_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSEksClustersDataSource_ -timeout 180m
=== RUN   TestAccAWSEksClustersDataSource_basic
=== PAUSE TestAccAWSEksClustersDataSource_basic
=== CONT  TestAccAWSEksClustersDataSource_basic
--- PASS: TestAccAWSEksClustersDataSource_basic (769.09s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	773.404s

@github-actions github-actions bot added size/M Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/eks Issues and PRs that pertain to the eks service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Sep 13, 2021
@ewbankkit ewbankkit changed the title [WIP] d/aws_eks_clusters: New data source d/aws_eks_clusters: New data source Sep 13, 2021
@ewbankkit ewbankkit merged commit a41d152 into main Sep 13, 2021
@ewbankkit ewbankkit deleted the tmp-20315 branch September 13, 2021 14:11
github-actions bot pushed a commit that referenced this pull request Sep 13, 2021
@breathingdust breathingdust added this to the v3.59.0 milestone Sep 16, 2021
@github-actions
Copy link

This functionality has been released in v3.59.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/eks Issues and PRs that pertain to the eks service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
3 participants