Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aws_iam_role name_prefix size #20785

Merged
merged 10 commits into from
Sep 10, 2021
Merged

aws_iam_role name_prefix size #20785

merged 10 commits into from
Sep 10, 2021

Conversation

caiodelgadonew
Copy link
Contributor

@caiodelgadonew caiodelgadonew commented Sep 3, 2021 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

This PR aims to increase the name_prefix size of aws_iam_role to 64 characters as described as a maximum of the documentation

Right now we have 26 characters being randomly generated for name_prefix that gives us just 6 characters to work.

There's 2 possible solutions:

  1. Increase the size of name_prefix to 64 characters.
  2. Add the limit info into the documentation

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. documentation Introduces or discusses updates to documentation. service/iam Issues and PRs that pertain to the iam service. size/XS Managed by automation to categorize the size of a PR. labels Sep 3, 2021
@caiodelgadonew
Copy link
Contributor Author

For hashicorp mantainers:

We can either adopt solution 1 or 2.

Just let me know and I can change the values of it based on whatever you think is best, right now the PR has both solutions so it need to be changed.

github-actions[bot]
github-actions bot reviewed Sep 3, 2021
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @caiodelgadonew 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@breathingdust breathingdust added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Sep 3, 2021
@caiodelgadonew
Copy link
Contributor Author

@breathingdust , what do you think about it? Can we change to 64 characters or should we just add the description of the character limit?

@ewbankkit
Copy link
Contributor

@caiodelgadonew Thanks for working on this.
You should be able to use a range of 1 to 64 - resource.UniqueIDSuffixLength for the name_prefix length.

@caiodelgadonew caiodelgadonew changed the title [WIP] aws_iam_role name_prefix size aws_iam_role name_prefix size Sep 8, 2021
@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. and removed documentation Introduces or discusses updates to documentation. labels Sep 8, 2021
@caiodelgadonew
Copy link
Contributor Author

Hello @ewbankkit , I've just set the modifications expected, could you please verify it to merge?

ewbankkit and others added 7 commits September 10, 2021 13:32
@ewbankkit
r/aws_iam_role: Use internal naming package.
83985f6
@DrFaust92 @ewbankkit
add validations
9abdd08
@DrFaust92 @ewbankkit
changelog
f5730fd
@beyondbill @ewbankkit
r/aws_iam_role - add retry for assume role policy update
b87064a
@ewbankkit
Add CHANGELOG entry.
7cbcba6
@ewbankkit
r/aws_iam_role: Use internal finder package.
c2932db 
Acceptance test output:

% make testacc TESTARGS='-run=TestAccAWSIAMRole_basic\|TestAccAWSIAMRole_Name'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSIAMRole_basic\|TestAccAWSIAMRole_Name -timeout 180m
=== RUN   TestAccAWSIAMRole_basic
=== PAUSE TestAccAWSIAMRole_basic
=== RUN   TestAccAWSIAMRole_basicWithDescription
=== PAUSE TestAccAWSIAMRole_basicWithDescription
=== RUN   TestAccAWSIAMRole_NameGenerated
=== PAUSE TestAccAWSIAMRole_NameGenerated
=== RUN   TestAccAWSIAMRole_NamePrefix
=== PAUSE TestAccAWSIAMRole_NamePrefix
=== CONT  TestAccAWSIAMRole_basic
=== CONT  TestAccAWSIAMRole_NamePrefix
=== CONT  TestAccAWSIAMRole_NameGenerated
=== CONT  TestAccAWSIAMRole_basicWithDescription
--- PASS: TestAccAWSIAMRole_basic (15.42s)
--- PASS: TestAccAWSIAMRole_NamePrefix (34.60s)
--- PASS: TestAccAWSIAMRole_basicWithDescription (48.39s)
--- PASS: TestAccAWSIAMRole_NameGenerated (95.65s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	98.853s
@ewbankkit
r/aws_iam_role: Use 'tfresource.RetryWhen'.
b24b905
@github-actions github-actions bot added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/XL Managed by automation to categorize the size of a PR. and removed documentation Introduces or discusses updates to documentation. size/XS Managed by automation to categorize the size of a PR. labels Sep 10, 2021
ewbankkit
ewbankkit approved these changes Sep 10, 2021
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

Commercial
% make testacc TESTARGS='-run=TestAccAWSIAMRole_\|TestAccAWSDataSourceIAMSessionContext_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSIAMRole_\|TestAccAWSDataSourceIAMSessionContext_ -timeout 180m
=== RUN   TestAccAWSDataSourceIAMSessionContext_basic
=== PAUSE TestAccAWSDataSourceIAMSessionContext_basic
=== RUN   TestAccAWSDataSourceIAMSessionContext_withPath
=== PAUSE TestAccAWSDataSourceIAMSessionContext_withPath
=== RUN   TestAccAWSDataSourceIAMSessionContext_notAssumedRole
=== PAUSE TestAccAWSDataSourceIAMSessionContext_notAssumedRole
=== RUN   TestAccAWSDataSourceIAMSessionContext_notAssumedRoleWithPath
=== PAUSE TestAccAWSDataSourceIAMSessionContext_notAssumedRoleWithPath
=== RUN   TestAccAWSDataSourceIAMSessionContext_notAssumedRoleUser
=== PAUSE TestAccAWSDataSourceIAMSessionContext_notAssumedRoleUser
=== RUN   TestAccAWSIAMRole_basic
=== PAUSE TestAccAWSIAMRole_basic
=== RUN   TestAccAWSIAMRole_basicWithDescription
=== PAUSE TestAccAWSIAMRole_basicWithDescription
=== RUN   TestAccAWSIAMRole_NameGenerated
=== PAUSE TestAccAWSIAMRole_NameGenerated
=== RUN   TestAccAWSIAMRole_NamePrefix
=== PAUSE TestAccAWSIAMRole_NamePrefix
=== RUN   TestAccAWSIAMRole_testNameChange
=== PAUSE TestAccAWSIAMRole_testNameChange
=== RUN   TestAccAWSIAMRole_badJSON
=== PAUSE TestAccAWSIAMRole_badJSON
=== RUN   TestAccAWSIAMRole_disappears
=== PAUSE TestAccAWSIAMRole_disappears
=== RUN   TestAccAWSIAMRole_force_detach_policies
=== PAUSE TestAccAWSIAMRole_force_detach_policies
=== RUN   TestAccAWSIAMRole_MaxSessionDuration
=== PAUSE TestAccAWSIAMRole_MaxSessionDuration
=== RUN   TestAccAWSIAMRole_PermissionsBoundary
=== PAUSE TestAccAWSIAMRole_PermissionsBoundary
=== RUN   TestAccAWSIAMRole_tags
=== PAUSE TestAccAWSIAMRole_tags
=== RUN   TestAccAWSIAMRole_policyBasicInline
=== PAUSE TestAccAWSIAMRole_policyBasicInline
=== RUN   TestAccAWSIAMRole_policyBasicInlineEmpty
=== PAUSE TestAccAWSIAMRole_policyBasicInlineEmpty
=== RUN   TestAccAWSIAMRole_policyBasicManaged
=== PAUSE TestAccAWSIAMRole_policyBasicManaged
=== RUN   TestAccAWSIAMRole_policyOutOfBandRemovalAddedBack_managedNonEmpty
=== PAUSE TestAccAWSIAMRole_policyOutOfBandRemovalAddedBack_managedNonEmpty
=== RUN   TestAccAWSIAMRole_policyOutOfBandRemovalAddedBack_inlineNonEmpty
=== PAUSE TestAccAWSIAMRole_policyOutOfBandRemovalAddedBack_inlineNonEmpty
=== RUN   TestAccAWSIAMRole_policyOutOfBandAdditionRemoved_managedNonEmpty
=== PAUSE TestAccAWSIAMRole_policyOutOfBandAdditionRemoved_managedNonEmpty
=== RUN   TestAccAWSIAMRole_policyOutOfBandAdditionRemoved_inlineNonEmpty
=== PAUSE TestAccAWSIAMRole_policyOutOfBandAdditionRemoved_inlineNonEmpty
=== RUN   TestAccAWSIAMRole_policyOutOfBandAdditionIgnored_inlineNonExistent
=== PAUSE TestAccAWSIAMRole_policyOutOfBandAdditionIgnored_inlineNonExistent
=== RUN   TestAccAWSIAMRole_policyOutOfBandAdditionIgnored_managedNonExistent
=== PAUSE TestAccAWSIAMRole_policyOutOfBandAdditionIgnored_managedNonExistent
=== RUN   TestAccAWSIAMRole_policyOutOfBandAdditionRemoved_inlineEmpty
=== PAUSE TestAccAWSIAMRole_policyOutOfBandAdditionRemoved_inlineEmpty
=== RUN   TestAccAWSIAMRole_policyOutOfBandAdditionRemoved_managedEmpty
=== PAUSE TestAccAWSIAMRole_policyOutOfBandAdditionRemoved_managedEmpty
=== CONT  TestAccAWSDataSourceIAMSessionContext_basic
=== CONT  TestAccAWSIAMRole_PermissionsBoundary
=== CONT  TestAccAWSIAMRole_NameGenerated
=== CONT  TestAccAWSIAMRole_basicWithDescription
=== CONT  TestAccAWSDataSourceIAMSessionContext_notAssumedRoleUser
=== CONT  TestAccAWSDataSourceIAMSessionContext_notAssumedRole
=== CONT  TestAccAWSIAMRole_policyOutOfBandAdditionRemoved_managedNonEmpty
=== CONT  TestAccAWSIAMRole_policyBasicInlineEmpty
=== CONT  TestAccAWSIAMRole_policyBasicInline
=== CONT  TestAccAWSIAMRole_tags
=== CONT  TestAccAWSIAMRole_policyOutOfBandAdditionRemoved_managedEmpty
=== CONT  TestAccAWSIAMRole_policyOutOfBandAdditionRemoved_inlineEmpty
=== CONT  TestAccAWSIAMRole_policyOutOfBandAdditionIgnored_managedNonExistent
=== CONT  TestAccAWSIAMRole_policyOutOfBandAdditionIgnored_inlineNonExistent
=== CONT  TestAccAWSIAMRole_policyBasicManaged
=== CONT  TestAccAWSIAMRole_policyOutOfBandRemovalAddedBack_inlineNonEmpty
=== CONT  TestAccAWSIAMRole_policyOutOfBandAdditionRemoved_inlineNonEmpty
=== CONT  TestAccAWSIAMRole_disappears
=== CONT  TestAccAWSDataSourceIAMSessionContext_notAssumedRoleWithPath
=== CONT  TestAccAWSIAMRole_policyOutOfBandRemovalAddedBack_managedNonEmpty
--- PASS: TestAccAWSDataSourceIAMSessionContext_notAssumedRoleUser (28.70s)
=== CONT  TestAccAWSIAMRole_MaxSessionDuration
--- PASS: TestAccAWSDataSourceIAMSessionContext_notAssumedRoleWithPath (31.85s)
=== CONT  TestAccAWSIAMRole_badJSON
--- PASS: TestAccAWSIAMRole_disappears (34.54s)
=== CONT  TestAccAWSIAMRole_testNameChange
--- PASS: TestAccAWSIAMRole_policyBasicInlineEmpty (35.79s)
=== CONT  TestAccAWSIAMRole_NamePrefix
--- PASS: TestAccAWSIAMRole_badJSON (6.54s)
=== CONT  TestAccAWSDataSourceIAMSessionContext_withPath
--- PASS: TestAccAWSDataSourceIAMSessionContext_basic (38.80s)
=== CONT  TestAccAWSIAMRole_force_detach_policies
--- PASS: TestAccAWSDataSourceIAMSessionContext_notAssumedRole (38.81s)
=== CONT  TestAccAWSIAMRole_basic
--- PASS: TestAccAWSIAMRole_NameGenerated (45.44s)
--- PASS: TestAccAWSIAMRole_policyOutOfBandAdditionIgnored_managedNonExistent (61.31s)
--- PASS: TestAccAWSIAMRole_policyOutOfBandAdditionRemoved_inlineEmpty (68.60s)
--- PASS: TestAccAWSIAMRole_policyOutOfBandRemovalAddedBack_inlineNonEmpty (69.57s)
--- PASS: TestAccAWSIAMRole_policyOutOfBandAdditionRemoved_managedEmpty (70.44s)
--- PASS: TestAccAWSIAMRole_policyOutOfBandAdditionRemoved_inlineNonEmpty (70.88s)
--- PASS: TestAccAWSIAMRole_policyOutOfBandAdditionRemoved_managedNonEmpty (71.39s)
--- PASS: TestAccAWSIAMRole_policyOutOfBandRemovalAddedBack_managedNonEmpty (72.68s)
--- PASS: TestAccAWSIAMRole_tags (74.00s)
--- PASS: TestAccAWSIAMRole_NamePrefix (38.57s)
--- PASS: TestAccAWSDataSourceIAMSessionContext_withPath (36.03s)
--- PASS: TestAccAWSIAMRole_basic (35.82s)
--- PASS: TestAccAWSIAMRole_force_detach_policies (38.18s)
--- PASS: TestAccAWSIAMRole_policyOutOfBandAdditionIgnored_inlineNonExistent (81.10s)
--- PASS: TestAccAWSIAMRole_basicWithDescription (86.73s)
--- PASS: TestAccAWSIAMRole_policyBasicManaged (88.46s)
--- PASS: TestAccAWSIAMRole_policyBasicInline (89.03s)
--- PASS: TestAccAWSIAMRole_testNameChange (54.89s)
--- PASS: TestAccAWSIAMRole_MaxSessionDuration (61.48s)
--- PASS: TestAccAWSIAMRole_PermissionsBoundary (105.29s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	108.464s
GovCloud
% make testacc TESTARGS='-run=TestAccAWSIAMRole_\|TestAccAWSDataSourceIAMSessionContext_' 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSIAMRole_\|TestAccAWSDataSourceIAMSessionContext_ -timeout 180m
=== RUN   TestAccAWSDataSourceIAMSessionContext_basic
=== PAUSE TestAccAWSDataSourceIAMSessionContext_basic
=== RUN   TestAccAWSDataSourceIAMSessionContext_withPath
=== PAUSE TestAccAWSDataSourceIAMSessionContext_withPath
=== RUN   TestAccAWSDataSourceIAMSessionContext_notAssumedRole
=== PAUSE TestAccAWSDataSourceIAMSessionContext_notAssumedRole
=== RUN   TestAccAWSDataSourceIAMSessionContext_notAssumedRoleWithPath
=== PAUSE TestAccAWSDataSourceIAMSessionContext_notAssumedRoleWithPath
=== RUN   TestAccAWSDataSourceIAMSessionContext_notAssumedRoleUser
=== PAUSE TestAccAWSDataSourceIAMSessionContext_notAssumedRoleUser
=== RUN   TestAccAWSIAMRole_basic
=== PAUSE TestAccAWSIAMRole_basic
=== RUN   TestAccAWSIAMRole_basicWithDescription
=== PAUSE TestAccAWSIAMRole_basicWithDescription
=== RUN   TestAccAWSIAMRole_NameGenerated
=== PAUSE TestAccAWSIAMRole_NameGenerated
=== RUN   TestAccAWSIAMRole_NamePrefix
=== PAUSE TestAccAWSIAMRole_NamePrefix
=== RUN   TestAccAWSIAMRole_testNameChange
=== PAUSE TestAccAWSIAMRole_testNameChange
=== RUN   TestAccAWSIAMRole_badJSON
=== PAUSE TestAccAWSIAMRole_badJSON
=== RUN   TestAccAWSIAMRole_disappears
=== PAUSE TestAccAWSIAMRole_disappears
=== RUN   TestAccAWSIAMRole_force_detach_policies
=== PAUSE TestAccAWSIAMRole_force_detach_policies
=== RUN   TestAccAWSIAMRole_MaxSessionDuration
=== PAUSE TestAccAWSIAMRole_MaxSessionDuration
=== RUN   TestAccAWSIAMRole_PermissionsBoundary
=== PAUSE TestAccAWSIAMRole_PermissionsBoundary
=== RUN   TestAccAWSIAMRole_tags
=== PAUSE TestAccAWSIAMRole_tags
=== RUN   TestAccAWSIAMRole_policyBasicInline
=== PAUSE TestAccAWSIAMRole_policyBasicInline
=== RUN   TestAccAWSIAMRole_policyBasicInlineEmpty
=== PAUSE TestAccAWSIAMRole_policyBasicInlineEmpty
=== RUN   TestAccAWSIAMRole_policyBasicManaged
=== PAUSE TestAccAWSIAMRole_policyBasicManaged
=== RUN   TestAccAWSIAMRole_policyOutOfBandRemovalAddedBack_managedNonEmpty
=== PAUSE TestAccAWSIAMRole_policyOutOfBandRemovalAddedBack_managedNonEmpty
=== RUN   TestAccAWSIAMRole_policyOutOfBandRemovalAddedBack_inlineNonEmpty
=== PAUSE TestAccAWSIAMRole_policyOutOfBandRemovalAddedBack_inlineNonEmpty
=== RUN   TestAccAWSIAMRole_policyOutOfBandAdditionRemoved_managedNonEmpty
=== PAUSE TestAccAWSIAMRole_policyOutOfBandAdditionRemoved_managedNonEmpty
=== RUN   TestAccAWSIAMRole_policyOutOfBandAdditionRemoved_inlineNonEmpty
=== PAUSE TestAccAWSIAMRole_policyOutOfBandAdditionRemoved_inlineNonEmpty
=== RUN   TestAccAWSIAMRole_policyOutOfBandAdditionIgnored_inlineNonExistent
=== PAUSE TestAccAWSIAMRole_policyOutOfBandAdditionIgnored_inlineNonExistent
=== RUN   TestAccAWSIAMRole_policyOutOfBandAdditionIgnored_managedNonExistent
=== PAUSE TestAccAWSIAMRole_policyOutOfBandAdditionIgnored_managedNonExistent
=== RUN   TestAccAWSIAMRole_policyOutOfBandAdditionRemoved_inlineEmpty
=== PAUSE TestAccAWSIAMRole_policyOutOfBandAdditionRemoved_inlineEmpty
=== RUN   TestAccAWSIAMRole_policyOutOfBandAdditionRemoved_managedEmpty
=== PAUSE TestAccAWSIAMRole_policyOutOfBandAdditionRemoved_managedEmpty
=== CONT  TestAccAWSDataSourceIAMSessionContext_basic
=== CONT  TestAccAWSIAMRole_PermissionsBoundary
=== CONT  TestAccAWSIAMRole_policyBasicManaged
=== CONT  TestAccAWSIAMRole_policyOutOfBandRemovalAddedBack_inlineNonEmpty
=== CONT  TestAccAWSIAMRole_policyOutOfBandAdditionIgnored_managedNonExistent
=== CONT  TestAccAWSIAMRole_policyOutOfBandAdditionRemoved_managedEmpty
=== CONT  TestAccAWSIAMRole_policyOutOfBandAdditionRemoved_inlineEmpty
=== CONT  TestAccAWSIAMRole_policyOutOfBandAdditionIgnored_inlineNonExistent
=== CONT  TestAccAWSIAMRole_policyBasicInline
=== CONT  TestAccAWSIAMRole_policyOutOfBandAdditionRemoved_managedNonEmpty
=== CONT  TestAccAWSIAMRole_tags
=== CONT  TestAccAWSIAMRole_NameGenerated
=== CONT  TestAccAWSIAMRole_MaxSessionDuration
=== CONT  TestAccAWSIAMRole_force_detach_policies
=== CONT  TestAccAWSIAMRole_disappears
=== CONT  TestAccAWSIAMRole_policyOutOfBandAdditionRemoved_inlineNonEmpty
=== CONT  TestAccAWSIAMRole_badJSON
=== CONT  TestAccAWSIAMRole_testNameChange
=== CONT  TestAccAWSDataSourceIAMSessionContext_notAssumedRoleUser
=== CONT  TestAccAWSIAMRole_policyBasicInlineEmpty
--- PASS: TestAccAWSIAMRole_badJSON (9.94s)
=== CONT  TestAccAWSIAMRole_NamePrefix
--- PASS: TestAccAWSDataSourceIAMSessionContext_notAssumedRoleUser (28.70s)
=== CONT  TestAccAWSIAMRole_basicWithDescription
--- PASS: TestAccAWSIAMRole_disappears (35.27s)
=== CONT  TestAccAWSDataSourceIAMSessionContext_notAssumedRole
--- PASS: TestAccAWSIAMRole_policyBasicInlineEmpty (43.57s)
=== CONT  TestAccAWSIAMRole_basic
--- PASS: TestAccAWSDataSourceIAMSessionContext_basic (43.88s)
=== CONT  TestAccAWSDataSourceIAMSessionContext_notAssumedRoleWithPath
--- PASS: TestAccAWSIAMRole_NameGenerated (48.44s)
=== CONT  TestAccAWSDataSourceIAMSessionContext_withPath
--- PASS: TestAccAWSIAMRole_NamePrefix (39.97s)
=== CONT  TestAccAWSIAMRole_policyOutOfBandRemovalAddedBack_managedNonEmpty
--- PASS: TestAccAWSIAMRole_force_detach_policies (54.26s)
--- PASS: TestAccAWSIAMRole_policyOutOfBandAdditionIgnored_managedNonExistent (61.96s)
--- PASS: TestAccAWSDataSourceIAMSessionContext_notAssumedRole (32.92s)
--- PASS: TestAccAWSIAMRole_policyOutOfBandAdditionRemoved_inlineEmpty (74.61s)
--- PASS: TestAccAWSIAMRole_policyOutOfBandAdditionRemoved_managedEmpty (75.18s)
--- PASS: TestAccAWSIAMRole_tags (76.02s)
--- PASS: TestAccAWSDataSourceIAMSessionContext_notAssumedRoleWithPath (32.31s)
--- PASS: TestAccAWSIAMRole_policyOutOfBandRemovalAddedBack_inlineNonEmpty (76.70s)
--- PASS: TestAccAWSIAMRole_policyOutOfBandAdditionRemoved_inlineNonEmpty (77.17s)
--- PASS: TestAccAWSIAMRole_policyOutOfBandAdditionRemoved_managedNonEmpty (78.53s)
--- PASS: TestAccAWSIAMRole_MaxSessionDuration (80.01s)
--- PASS: TestAccAWSDataSourceIAMSessionContext_withPath (32.31s)
--- PASS: TestAccAWSIAMRole_basic (37.82s)
--- PASS: TestAccAWSIAMRole_testNameChange (82.19s)
--- PASS: TestAccAWSIAMRole_policyOutOfBandAdditionIgnored_inlineNonExistent (86.72s)
--- PASS: TestAccAWSIAMRole_policyBasicInline (99.18s)
--- PASS: TestAccAWSIAMRole_policyBasicManaged (99.43s)
--- PASS: TestAccAWSIAMRole_policyOutOfBandRemovalAddedBack_managedNonEmpty (51.05s)
--- PASS: TestAccAWSIAMRole_basicWithDescription (72.86s)
--- PASS: TestAccAWSIAMRole_PermissionsBoundary (118.23s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	121.414s

@ewbankkit
Copy link
Contributor

@caiodelgadonew Thanks for the contribution 🎉 👏.
I included changes from #12436 and #19532.

This was referenced Sep 10, 2021
Closed
Closed
@ewbankkit ewbankkit merged commit a1cfe8a into hashicorp:main Sep 10, 2021
@breathingdust breathingdust added this to the v3.59.0 milestone Sep 16, 2021
@github-actions
Copy link

This functionality has been released in v3.59.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/iam Issues and PRs that pertain to the iam service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.59.0
Development

Successfully merging this pull request may close these issues.
5 participants
@caiodelgadonew @ewbankkit @breathingdust @DrFaust92 @beyondbill