Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add quicksight group membership resource #20687

Merged
merged 16 commits into from
Sep 7, 2021
Merged

Add quicksight group membership resource #20687

merged 16 commits into from
Sep 7, 2021

Commits on Aug 12, 2021

  1. added group membership role from different fork

    @lacernetic
    lacernetic committed Aug 12, 2021
    Configuration menu
    Copy the full SHA
    f84f4da View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2021

  1. tests workings

    @lacernetic
    lacernetic committed Aug 23, 2021
    Configuration menu
    Copy the full SHA
    8f06be1 View commit details
    Browse the repository at this point in the history

  2. added documentation

    @lacernetic
    lacernetic committed Aug 23, 2021
    Configuration menu
    Copy the full SHA
    8c2fdeb View commit details
    Browse the repository at this point in the history

Commits on Aug 24, 2021

  1. Merge branch 'main' into f-quicksight_group_membership_resource

    @lacernetic
    lacernetic committed Aug 24, 2021
    Configuration menu
    Copy the full SHA
    c4d29a5 View commit details
    Browse the repository at this point in the history

  2. gomod and gosum

    @lacernetic
    lacernetic committed Aug 24, 2021
    Configuration menu
    Copy the full SHA
    50ef4ee View commit details
    Browse the repository at this point in the history

Commits on Aug 25, 2021

  1. removed changes to go.mod and go.sum

    @lacernetic
    lacernetic committed Aug 25, 2021
    Configuration menu
    Copy the full SHA
    5019ba0 View commit details
    Browse the repository at this point in the history

  2. actually fixed go.mod and go.sum

    @lacernetic
    lacernetic committed Aug 25, 2021
    Configuration menu
    Copy the full SHA
    3445d58 View commit details
    Browse the repository at this point in the history

  3. for real this time fixing go.sum and go.mod

    @lacernetic
    lacernetic committed Aug 25, 2021
    Configuration menu
    Copy the full SHA
    8a8e5bc View commit details
    Browse the repository at this point in the history

  4. added .changelog file

    @lacernetic
    lacernetic committed Aug 25, 2021
    Configuration menu
    Copy the full SHA
    22a539c View commit details
    Browse the repository at this point in the history

  5. changed crud to crud context

    @lacernetic
    lacernetic committed Aug 25, 2021
    Configuration menu
    Copy the full SHA
    fe8ab4e View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2021

  1. fixed lint errors: tests now have error check, group_memebership now … 

    …uses aws.stringvalue() to dereference, docs now uses terraform block
    @lacernetic
    lacernetic committed Aug 30, 2021
    Configuration menu
    Copy the full SHA
    6bfd162 View commit details
    Browse the repository at this point in the history

Commits on Sep 2, 2021

  1. changes according to review: CRUD without timeout added, group_name r… 

    …equired, more accurate errors, added finder file that checks if a group_membership exists
    @lacernetic
    lacernetic committed Sep 2, 2021
    Configuration menu
    Copy the full SHA
    d2c7106 View commit details
    Browse the repository at this point in the history

  2. added destroy check in test

    @lacernetic
    lacernetic committed Sep 2, 2021
    Configuration menu
    Copy the full SHA
    2c34bdd View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2021

  1. formatting

    @lacernetic
    lacernetic committed Sep 7, 2021
    Configuration menu
    Copy the full SHA
    3b0ee70 View commit details
    Browse the repository at this point in the history

  2. removed testing print

    @lacernetic
    lacernetic committed Sep 7, 2021
    Configuration menu
    Copy the full SHA
    e7923f8 View commit details
    Browse the repository at this point in the history

  3. added error check to fix test case, return after set id, changed warn… 

    … message to be more verbose, deleted testacccheckquicksightgroupmembershipdisappears, removed useless comments, changed state to state context
    @lacernetic
    lacernetic committed Sep 7, 2021
    Configuration menu
    Copy the full SHA
    d69cc39 View commit details
    Browse the repository at this point in the history