Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate from GitHub HashiBot pull_request_size_labeler behavior to GitHub Actions #19729

Merged
merged 1 commit into from
Jun 9, 2021
Merged

Migrate from GitHub HashiBot pull_request_size_labeler behavior to GitHub Actions #19729

merged 1 commit into from
Jun 9, 2021

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Jun 9, 2021

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #19356

Output from acceptance testing: N/A

@bflad bflad requested a review from a team as a code owner June 9, 2021 14:25
@ghost ghost added size/S Managed by automation to categorize the size of a PR. labels Jun 9, 2021
@github-actions github-actions bot added provider Pertains to the provider itself, rather than any interaction with AWS. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jun 9, 2021
anGie44
anGie44 approved these changes Jun 9, 2021
View reviewed changes
Copy link
Contributor

@anGie44 anGie44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

.github/workflows/pull_requests.yml
m_max_size: '150'
l_label: 'size/L'
l_max_size: '300'
xl_label: 'size/XL'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if we get a PR > size/XL (not that we really get that many), we'll need to manually label?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will label anything above 300 lines with size/XL. 😄 This action doesn't support XXL.

@bflad bflad merged commit 1c4b31a into main Jun 9, 2021
@bflad bflad deleted the td-hashibot-pr-size-labeling branch June 9, 2021 14:52
@github-actions github-actions bot added this to the v3.45.0 milestone Jun 9, 2021
github-actions bot pushed a commit that referenced this pull request Jun 9, 2021
Update CHANGELOG.md for #19729
eddcaff
@github-actions
Copy link

This functionality has been released in v3.45.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@anGie44 anGie44 anGie44 approved these changes

Assignees
No one assigned
Labels
provider Pertains to the provider itself, rather than any interaction with AWS. size/S Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.45.0
Development

Successfully merging this pull request may close these issues.

Migrate/Remove GitHub HashiBot Behaviors
2 participants
@bflad @anGie44