Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws_lambda_event_source_mapping: Support reading starting_position fields #19253

Merged
merged 10 commits into from
May 7, 2021
Merged

aws_lambda_event_source_mapping: Support reading starting_position fields #19253

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
0eb3494
Add starting_position and starting_position_timestamp for event sourc…
gmpify May 5, 2021
7337664
Use correct variable name
gmpify May 5, 2021
a29786d
Set starting_position to null instead of empty, to ensure it's backwa…
gmpify May 5, 2021
d0431d6
Remove note on documentation about replace after import
gmpify May 5, 2021
d54800f
Update tests to check import of both starting_position and starting_p…
gmpify May 5, 2021
8a04f07
Update MSK test as starting_position is required for that resource
gmpify May 5, 2021
14ba532
Add starting_position to MSK test, as it's required
gmpify May 5, 2021
2051ebc
Add changelog
gmpify May 5, 2021
9f43319
r/aws_lambda_event_source_mapping: No need for nil check when reading…
ewbankkit May 7, 2021
8d3e1b3
r/aws_lambda_event_source_mapping: Simplify acceptance test configura…
ewbankkit May 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .changelog/19253.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
```release-note:enhancement
resource/aws_lambda_event_source_mapping: Support reading `starting_position` and `starting_position_timestamp` attributes
```
7 changes: 7 additions & 0 deletions aws/resource_aws_lambda_event_source_mapping.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -323,6 +323,13 @@ func resourceAwsLambdaEventSourceMappingRead(d *schema.ResourceData, meta interf
return fmt.Errorf("error setting topics: %w", err)
}

d.Set("starting_position", eventSourceMappingConfiguration.StartingPosition)
if eventSourceMappingConfiguration.StartingPositionTimestamp != nil {
d.Set("starting_position_timestamp", aws.TimeValue(eventSourceMappingConfiguration.StartingPositionTimestamp).Format(time.RFC3339))
} else {
d.Set("starting_position_timestamp", nil)
}

state := aws.StringValue(eventSourceMappingConfiguration.State)

switch state {
Expand Down
Loading