Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removes IDRefreshName from acceptance tests for resources I-N #19131

Merged
merged 1 commit into from
May 3, 2021
Merged

Removes IDRefreshName from acceptance tests for resources I-N #19131

merged 1 commit into from
May 3, 2021

Conversation

gdavison
Copy link
Contributor

@gdavison gdavison commented Apr 27, 2021 •
edited
Loading

ID-only refresh tests are no longer needed now that import testing is available. Remove from the following resources:

  • aws_iam_group_policy
  • aws_iam_instance_profile
  • aws_iam_role_policy
  • aws_iam_role
  • aws_iam_user_policy
  • aws_instance
  • aws_internet_gateway
  • aws_key_pair
  • aws_lb_listener
  • aws_lb_target_group
  • aws_lb
  • aws_lightsail_instance
  • aws_nat_gateway
  • aws_network_acl
  • aws_network_interface_attachment
  • aws_network_interface

Relates #18354

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSIAMUserPolicy\|TestAccAWSLB\|TestAccAWSENI\|TestAccAWSIAMGroupPolicy\|TestAccAWSInstance\|TestAccAWSLBListener\|TestAccAWSNatGateway\|TestAccAWSIAMRole\|TestAccAWSInternetGateway\|TestAccAWSIAMInstanceProfile\|TestAccAWSNetworkInterfaceAttachment\|TestAccAWSLightsailInstance\|TestAccAWSKeyPair\|TestAccAWSNetworkAcl\|TestAccAWSLBTargetGroup\|TestAccAWSIAMRolePolicy'

--- PASS: TestAccAWSInstanceDataSource_AzUserData (95.50s)
--- PASS: TestAccAWSInstanceDataSource_secondaryPrivateIPs (100.62s)
--- PASS: TestAccAWSInstanceDataSource_EbsBlockDevice_KmsKeyId (102.39s)
--- PASS: TestAccAWSInstanceDataSource_rootInstanceStore (103.23s)
--- PASS: TestAccAWSInstanceDataSource_privateIP (103.81s)
--- PASS: TestAccAWSInstanceDataSource_RootBlockDevice_KmsKeyId (108.42s)
--- PASS: TestAccAWSInstanceDataSource_gp3ThroughputDevice (113.38s)
--- PASS: TestAccAWSInstanceDataSource_VPCSecurityGroups (113.54s)
--- PASS: TestAccAWSInstanceDataSource_basic (125.58s)
--- PASS: TestAccAWSInstanceDataSource_SecurityGroups (127.33s)
--- PASS: TestAccAWSInstanceDataSource_gp2IopsDevice (135.29s)
--- PASS: TestAccAWSInstanceDataSource_GetUserData (141.52s)
--- PASS: TestAccAWSInstanceDataSource_GetUserData_NoUserData (142.05s)
--- PASS: TestAccAWSInstanceDataSource_tags (149.56s)
--- PASS: TestAccAWSInstanceDataSource_PlacementGroup (150.18s)
--- PASS: TestAccAWSInstanceDataSource_blockDevices (154.76s)
--- PASS: TestAccAWSIAMGroupPolicy_disappears (33.40s)
--- PASS: TestAccAWSIAMGroupPolicyAttachment_basic (51.30s)
--- PASS: TestAccAWSInstanceDataSource_creditSpecification (71.30s)
--- PASS: TestAccAWSIAMInstanceProfile_withoutRole (38.25s)
--- PASS: TestAccAWSIAMInstanceProfile_basic (46.40s)
--- PASS: TestAccAWSIAMGroupPolicy_basic (68.62s)
--- PASS: TestAccAWSIAMInstanceProfile_namePrefix (42.17s)
--- PASS: TestAccAWSInstanceDataSource_keyPair (198.61s)
--- PASS: TestAccAWSIAMInstanceProfile_disappears (37.82s)
--- PASS: TestAccAWSIAMInstanceProfile_disappears_role (34.49s)
--- PASS: TestAccAWSInstanceDataSource_blockDeviceTags (99.16s)
--- PASS: TestAccAWSIAMRolePolicy_invalidJSON (5.67s)
--- PASS: TestAccAWSIAMGroupPolicy_namePrefix (68.68s)
--- PASS: TestAccAWSInstanceDataSource_metadataOptions (104.97s)
--- PASS: TestAccAWSIAMGroupPolicy_generatedName (65.99s)
--- PASS: TestAccAWSInstanceDataSource_getPasswordData_falseToTrue (207.95s)
--- PASS: TestAccAWSInstancesDataSource_tags (105.11s)
--- PASS: TestAccAWSIAMRole_badJSON (10.31s)
--- PASS: TestAccAWSInstancesDataSource_instanceStateNames (106.58s)
--- PASS: TestAccAWSInstanceDataSource_enclaveOptions (121.10s)
--- PASS: TestAccAWSIAMRolePolicy_Policy_InvalidResource (25.78s)
--- PASS: TestAccAWSInstancesDataSource_basic (124.49s)
--- PASS: TestAccAWSIAMRolePolicy_disappears (42.52s)
--- PASS: TestAccAWSInstanceDataSource_VPC (232.48s)
--- PASS: TestAccAWSInstanceDataSource_getPasswordData_trueToFalse (241.55s)
--- PASS: TestAccAWSIAMRolePolicy_basic (87.52s)
--- PASS: TestAccAWSIAMRole_disappears (53.29s)
--- PASS: TestAccAWSIAMRole_basic (63.12s)
--- PASS: TestAccAWSIAMRole_namePrefix (64.46s)
--- PASS: TestAccAWSIAMInstanceProfile_tags (131.37s)
--- PASS: TestAccAWSIAMRole_force_detach_policies (73.98s)
--- PASS: TestAccAWSIAMRole_policyBasicInlineEmpty (62.80s)
--- PASS: TestAccAWSIAMRolePolicy_namePrefix (108.75s)
--- PASS: TestAccAWSIAMRolePolicy_generatedName (110.86s)
--- PASS: TestAccAWSIAMRole_testNameChange (128.59s)
--- PASS: TestFetchRootDevice (0.00s)
    --- PASS: TestFetchRootDevice/device_name_in_mappings (0.00s)
    --- PASS: TestFetchRootDevice/device_name_not_in_mappings (0.00s)
    --- PASS: TestFetchRootDevice/no_images (0.00s)
--- PASS: TestAccAWSIAMRole_tags (122.70s)
--- PASS: TestAccAWSIAMUserPolicy_disappears (64.43s)
--- PASS: TestAccAWSIAMRole_policyOutOfBandRemovalAddedBack_managedNonEmpty (121.32s)
--- PASS: TestAccAWSIAMRole_MaxSessionDuration (141.78s)
--- PASS: TestAccAWSIAMRole_policyOutOfBandRemovalAddedBack_inlineNonEmpty (119.26s)
--- SKIP: TestAccAWSInstance_inEc2Classic (2.45s)
--- PASS: TestAccAWSIAMRole_policyOutOfBandAdditionRemoved_managedNonEmpty (122.79s)
--- PASS: TestAccAWSIAMRole_policyOutOfBandAdditionRemoved_inlineNonEmpty (118.04s)
--- PASS: TestAccAWSIAMRole_basicWithDescription (168.22s)
--- PASS: TestAccAWSIAMRole_policyOutOfBandAdditionIgnored_managedNonExistent (115.58s)
--- PASS: TestAccAWSIAMRole_policyOutOfBandAdditionRemoved_inlineEmpty (115.49s)
--- PASS: TestAccAWSIAMRole_policyOutOfBandAdditionRemoved_managedEmpty (114.36s)
--- PASS: TestAccAWSInstance_EbsBlockDevice_InvalidIopsForVolumeType (34.90s)
--- PASS: TestAccAWSInstance_EbsBlockDevice_InvalidThroughputForVolumeType (31.54s)
--- PASS: TestAccAWSIAMRole_policyBasicInline (174.91s)
--- PASS: TestAccAWSIAMRole_policyBasicManaged (178.02s)
--- PASS: TestAccAWSIAMUserPolicy_namePrefix (116.22s)
--- PASS: TestAccAWSIAMUserPolicy_basic (121.94s)
--- SKIP: TestAccAWSInstance_outpost (1.08s)
--- PASS: TestAccAWSInstance_GP2WithIopsValue (26.59s)
--- PASS: TestAccAWSIAMUserPolicy_generatedName (111.50s)
--- PASS: TestAccAWSIAMRole_policyOutOfBandAdditionIgnored_inlineNonExistent (158.47s)
--- PASS: TestAccAWSInstance_ipv6AddressCountAndSingleAddressCausesError (21.45s)
--- PASS: TestAccAWSIAMRole_PermissionsBoundary (226.01s)
--- PASS: TestAccAWSInstance_inDefaultVpcBySgId (111.21s)
--- PASS: TestAccAWSInstance_inDefaultVpcBySgName (116.75s)
--- PASS: TestAccAWSIAMUserPolicy_multiplePolicies (151.11s)
--- PASS: TestAccAWSInstance_GP2IopsDevice (92.28s)
--- PASS: TestAccAWSInstance_EbsBlockDevice_KmsKeyArn (120.24s)
--- PASS: TestAccAWSInstance_noAMIEphemeralDevices (83.29s)
--- PASS: TestAccAWSInstance_RootBlockDevice_KmsKeyArn (118.69s)
--- PASS: TestAccAWSInstance_basic (135.37s)
--- PASS: TestAccAWSInstance_ipv6_supportAddressCount (89.01s)
--- PASS: TestAccAWSInstance_userDataBase64 (131.42s)
--- PASS: TestAccAWSInstance_rootInstanceStore (119.34s)
--- PASS: TestAccAWSInstance_ipv6_supportAddressCountWithIpv4 (92.52s)
--- PASS: TestAccAWSInstance_placementGroup (106.42s)
--- PASS: TestAccAWSInstance_dedicatedInstance (118.53s)
--- PASS: TestAccAWSInstance_blockDevices (141.71s)
--- PASS: TestAccAWSInstance_disableApiTermination (123.67s)
--- PASS: TestAccAWSInstance_NetworkInstanceSecurityGroups (94.53s)
--- PASS: TestAccAWSInstance_NetworkInstanceVPCSecurityGroupIDs (90.72s)
--- PASS: TestAccAWSInstance_NetworkInstanceRemovingAllSecurityGroups (103.54s)
--- PASS: TestAccAWSInstance_atLeastOneOtherEbsVolume (202.15s)
--- PASS: TestAccAWSInstance_sourceDestCheck (159.34s)
--- PASS: TestAccAWSInstance_keyPairCheck (76.19s)
--- PASS: TestAccAWSInstance_privateIP (89.55s)
--- PASS: TestAccAWSInstance_Empty_PrivateIP (92.51s)
--- PASS: TestAccAWSInstance_associatePublicIPAndPrivateIP (100.70s)
--- PASS: TestAccAWSInstance_rootBlockDeviceMismatch (94.83s)
--- PASS: TestAccAWSInstance_EbsRootDevice_basic (98.94s)
--- PASS: TestAccAWSInstance_blockDeviceTags_volumeTags (170.92s)
--- PASS: TestAccAWSInstance_withIamInstanceProfilePath (146.00s)
--- PASS: TestAccAWSInstance_withIamInstanceProfile (154.39s)
--- PASS: TestAccAWSInstance_EbsRootDevice_ModifySize (138.92s)
--- PASS: TestAccAWSInstance_tags (221.80s)
--- PASS: TestAccAWSInstance_EbsRootDevice_ModifyIOPS_Io1 (133.73s)
--- PASS: TestAccAWSInstance_EbsRootDevice_ModifyType (136.95s)
--- PASS: TestAccAWSInstance_blockDeviceTags_withAttachedVolume (216.38s)
--- PASS: TestAccAWSInstance_changeInstanceType (166.37s)
--- PASS: TestAccAWSInstance_EbsRootDevice_ModifyIOPS_Io2 (137.51s)
--- PASS: TestAccAWSInstance_blockDeviceTags_ebsAndRoot (224.83s)
--- PASS: TestAccAWSInstance_EbsRootDevice_ModifyThroughput_Gp3 (143.43s)
--- PASS: TestAccAWSInstance_instanceProfileChange (234.98s)
--- FAIL: TestAccAWSInstance_addSecondaryInterface (97.14s)
--- PASS: TestAccAWSInstance_primaryNetworkInterfaceSourceDestCheck (107.12s)
--- PASS: TestAccAWSInstance_EbsRootDevice_ModifyDeleteOnTermination (151.68s)
--- PASS: TestAccAWSInstance_EbsRootDevice_MultipleBlockDevices_ModifySize (136.93s)
--- PASS: TestAccAWSInstance_NewNetworkInterface_EmptyPrivateIPAndSecondaryPrivateIPs (78.03s)
--- PASS: TestAccAWSInstance_EbsRootDevice_ModifyAll (183.16s)
--- PASS: TestAccAWSInstance_associatePublic_defaultPrivate (80.06s)
--- PASS: TestAccAWSInstance_forceNewAndTagsDrift (250.15s)
--- PASS: TestAccAWSInstance_addSecurityGroupNetworkInterface (142.11s)
--- PASS: TestAccAWSInstance_associatePublic_defaultPublic (94.30s)
--- PASS: TestAccAWSInstance_NewNetworkInterface_PrivateIPAndSecondaryPrivateIPs (107.67s)
--- PASS: TestAccAWSInstance_associatePublic_overridePublic (82.81s)
--- PASS: TestAccAWSInstance_EbsRootDevice_MultipleBlockDevices_ModifyDeleteOnTermination (191.71s)
--- PASS: TestAccAWSInstance_associatePublic_explicitPrivate (94.53s)
--- PASS: TestAccAWSInstance_NewNetworkInterface_PrivateIPAndSecondaryPrivateIPsUpdate (120.04s)
--- PASS: TestAccAWSInstance_EbsRootDevice_MultipleDynamicEBSBlockDevices (199.29s)
--- PASS: TestAccAWSInstance_CreditSpecification_Empty_NonBurstable (75.03s)
--- PASS: TestAccAWSInstance_associatePublic_overridePrivate (91.48s)
--- PASS: TestAccAWSInstance_primaryNetworkInterface (215.58s)
--- PASS: TestAccAWSInstance_creditSpecification_unspecifiedDefaultsToStandard (72.19s)
--- PASS: TestAccAWSInstance_creditSpecification_unknownCpuCredits_t2 (72.00s)
--- PASS: TestAccAWSInstance_NewNetworkInterface_PublicIPAndSecondaryPrivateIPs (183.97s)
--- PASS: TestAccAWSInstance_NewNetworkInterface_EmptyPrivateIPAndSecondaryPrivateIPsUpdate (176.63s)
--- PASS: TestAccAWSInstance_creditSpecification_unknownCpuCredits_t3 (73.86s)
--- PASS: TestAccAWSInstance_creditSpecification_standardCpuCredits (95.51s)
--- PASS: TestInstanceHostIDSchema (0.00s)
--- PASS: TestInstanceCpuCoreCountSchema (0.00s)
--- PASS: TestInstanceCpuThreadsPerCoreSchema (0.00s)
--- PASS: TestAccAWSInstance_creditSpecification_unlimitedCpuCredits (96.37s)
--- PASS: TestAccAWSInstance_CreditSpecification_UnspecifiedToEmpty_NonBurstable (127.39s)
--- PASS: TestAccAWSInstance_associatePublic_explicitPublic (201.76s)
--- PASS: TestAccAWSInstance_getPasswordData_falseToTrue (167.17s)
--- PASS: TestAccAWSInstance_creditSpecificationT3_standardCpuCredits (110.14s)
--- PASS: TestAccAWSInstance_creditSpecificationT3_unspecifiedDefaultsToUnlimited (112.31s)
--- PASS: TestAccAWSInstance_creditSpecification_isNotAppliedToNonBurstable (118.38s)
--- PASS: TestAccAWSInstance_creditSpecification_updateCpuCredits (133.80s)
--- PASS: TestAccAWSInstance_creditSpecificationT3_unlimitedCpuCredits (120.99s)
--- PASS: TestAccAWSInstance_creditSpecificationT3_updateCpuCredits (121.85s)
--- PASS: TestAccAWSInstance_UserData_EmptyStringToUnspecified (100.18s)
--- PASS: TestAccAWSInternetGateway_delete (65.35s)
--- PASS: TestAccAWSInternetGateway_basic (76.06s)
--- PASS: TestAccAWSKeyPair_basic (46.05s)
--- PASS: TestAccAWSKeyPair_generatedName (44.56s)
--- PASS: TestAccAWSInternetGateway_disappears (52.30s)
--- PASS: TestAccAWSInstance_UserData_UnspecifiedToEmptyString (110.90s)
--- PASS: TestAccAWSKeyPair_disappears (36.93s)
--- PASS: TestAccAWSKeyPair_namePrefix (45.87s)
--- PASS: TestAccAWSInstance_GP3RootBlockDevice (99.48s)
--- PASS: TestAccAWSLBCookieStickinessPolicy_disappears_ELB (35.36s)
--- PASS: TestAccAWSLBCookieStickinessPolicy_disappears (37.91s)
--- PASS: TestAccAWSLBCookieStickinessPolicy_basic (58.90s)
--- PASS: TestAccAWSInstance_creditSpecification_standardCpuCredits_t2Tot3Taint (176.79s)
--- PASS: TestAccAWSKeyPair_tags (84.96s)
--- PASS: TestAccAWSInstance_creditSpecification_unlimitedCpuCredits_t2Tot3Taint (176.34s)
--- PASS: TestAccAWSInstance_getPasswordData_trueToFalse (263.14s)
--- PASS: TestAccAWSInternetGateway_tags (100.43s)
--- PASS: TestAccAWSLBListenerRule_conditionAttributesCount (23.17s)
--- PASS: TestAccAWSLBListenerRule_conditionHttpHeader_invalid (1.72s)
--- PASS: TestAccAWSInstance_metadataOptions (189.93s)
--- PASS: TestAccAWSInstance_hibernation (217.75s)
--- PASS: TestAccAWSLBListenerRule_BackwardsCompatibility (162.35s)
--- PASS: TestAccAWSLBListenerRule_redirect (174.44s)
--- PASS: TestAccAWSLBListenerRule_cognito (178.73s)
--- PASS: TestAccAWSLBListenerRule_Action_Order_Recreates (172.66s)
--- PASS: TestAccAWSLBListenerRule_updateFixedResponse (200.07s)
--- PASS: TestAccAWSLBListenerRule_Action_Order (179.20s)
--- PASS: TestAccAWSLBListenerRule_oidc (181.71s)
--- PASS: TestAccAWSLBListenerRule_updateRulePriority (203.36s)
--- PASS: TestAccAWSLBListenerRule_fixedResponse (213.08s)
--- PASS: TestAccAWSInstance_disappears (332.81s)
--- PASS: TestAccAWSLBListenerRule_forwardWeighted (222.84s)
--- PASS: TestAccAWSLBListenerRule_conditionHostHeader (176.45s)
--- PASS: TestAccAWSLBListenerRule_conditionHttpHeader (176.44s)
--- PASS: TestAccAWSLBListenerRule_changeListenerRuleArnForcesNew (217.05s)
--- PASS: TestAccAWSLBListenerRule_basic (248.70s)
--- PASS: TestAccAWSLBListenerRule_conditionHttpRequestMethod (175.98s)
--- PASS: TestAccAWSLBListenerRule_conditionPathPattern (174.25s)
--- PASS: TestAccAWSLBListenerRule_conditionQueryString (165.71s)
--- PASS: TestAccAWSLBListenerRule_priority (268.79s)
--- PASS: TestAccAWSLBSSLNegotiationPolicy_basic (29.51s)
--- PASS: TestAccAWSLBListenerRule_conditionSourceIp (156.71s)
--- PASS: TestAccAWSLBSSLNegotiationPolicy_disappears (28.66s)
--- PASS: TestAccAWSLBListener_LoadBalancerArn_GatewayLoadBalancer (107.16s)
--- PASS: TestAccAWSInstance_enclaveOptions (433.39s)
--- PASS: TestAccAWSLBListenerRule_conditionUpdateMixed (180.41s)
--- PASS: TestAccAWSLBListener_BackwardsCompatibility (148.26s)
--- PASS: TestAccAWSLBTargetGroupAttachment_basic (55.22s)
--- PASS: TestLBTargetGroupCloudwatchSuffixFromARN (0.00s)
--- PASS: TestAccAWSLBListenerRule_conditionMultiple (164.06s)
--- PASS: TestAccAWSLBListener_basic (167.61s)
--- PASS: TestAccAWSLBListener_https (174.62s)
--- PASS: TestAccAWSLBListener_redirect (172.85s)
--- PASS: TestAccAWSLBTargetGroupAttachment_BackwardsCompatibility (73.20s)
--- PASS: TestAccAWSLBTargetGroupAttachment_disappears (77.98s)
--- PASS: TestAccAWSLBTargetGroupAttachment_Port (81.07s)
--- PASS: TestAccAWSLBListener_oidc (168.80s)
--- PASS: TestAccAWSLBTargetGroup_basicUdp (49.45s)
--- PASS: TestAccAWSLBTargetGroup_basic (49.94s)
--- PASS: TestAccAWSLBListener_fixedResponse (194.18s)
--- PASS: TestAccAWSLBTargetGroup_ProtocolVersion (50.66s)
--- PASS: TestAccAWSLBListener_cognito (193.84s)
--- PASS: TestAccAWSLBTargetGroupAttachment_ipAddress (86.47s)
--- PASS: TestAccAWSLBTargetGroup_withoutHealthcheck (47.13s)
--- PASS: TestAccAWSLBTargetGroupAttachment_lambda (72.83s)
--- PASS: TestAccAWSLBListener_DefaultAction_Order (187.44s)
--- PASS: TestAccAWSLBListener_DefaultAction_Order_Recreates (173.47s)
--- PASS: TestAccAWSLBListenerRule_conditionUpdateMultiple (230.37s)
--- PASS: TestAccAWSLBTargetGroup_Protocol_Tls (54.34s)
--- PASS: TestAccAWSLBTargetGroup_Protocol_Geneve (67.32s)
--- PASS: TestAccAWSLBTargetGroup_ProtocolVersion_GRPC_HealthCheck (55.75s)
--- PASS: TestAccAWSLBTargetGroup_BackwardsCompatibility (59.05s)
--- PASS: TestAccAWSLBTargetGroup_namePrefix (56.85s)
--- PASS: TestAccAWSLBTargetGroup_generatedName (56.69s)
--- PASS: TestAccAWSLBListener_forwardWeighted (267.96s)
--- PASS: TestAccAWSLBTargetGroup_Protocol_Tcp_HealthCheck_Protocol (102.85s)
--- PASS: TestAccAWSLBTargetGroup_ProtocolVersion_HTTP_GRPC_Update (107.55s)
--- PASS: TestAccAWSLBTargetGroup_TCP_HTTPHealthCheck (103.89s)
--- PASS: TestAccAWSLBTargetGroup_networkLB_TargetGroupWithProxy (104.01s)
--- PASS: TestAccAWSLBTargetGroup_defaults_application (59.82s)
--- PASS: TestLBCloudwatchSuffixFromARN (0.00s)
--- PASS: TestAccAWSLBTargetGroup_changeNameForceNew (106.83s)
--- PASS: TestAccAWSLBTargetGroup_changeProtocolForceNew (106.55s)
--- PASS: TestAccAWSLBTargetGroup_changePortForceNew (106.66s)
--- PASS: TestAccAWSLBTargetGroup_changeVpcForceNew (107.17s)
--- PASS: TestAccAWSLBTargetGroup_stickinessDefaultALB (59.40s)
--- SKIP: TestAccAWSLB_ALB_outpost (1.10s)
--- PASS: TestAccAWSLBTargetGroup_enableHealthCheck (103.11s)
--- PASS: TestAccAWSLBTargetGroup_networkLB_TargetGroup (157.54s)
--- PASS: TestAccAWSLBTargetGroup_updateHealthCheck (107.85s)
--- PASS: TestAccAWSLBTargetGroup_defaults_network (85.18s)
--- PASS: TestAccAWSLBListener_basicUdp (362.21s)
--- PASS: TestAccAWSLBTargetGroup_tags (141.08s)
--- PASS: TestAccAWSLBTargetGroup_stickinessInvalidNLB (61.43s)
--- PASS: TestAccAWSLBTargetGroup_stickinessValidALB (87.08s)
--- PASS: TestAccAWSLBTargetGroup_updateSticknessEnabled (127.60s)
--- PASS: TestAccAWSLBTargetGroup_preserveClientIPValid (73.06s)
--- PASS: TestAccAWSLBTargetGroup_stickinessInvalidALB (75.23s)
--- PASS: TestAccAWSLBTargetGroup_stickinessDefaultNLB (118.33s)
--- PASS: TestAccAWSLBListener_Protocol_Tls (378.37s)
--- PASS: TestAccAWSLBTargetGroup_stickinessValidNLB (139.08s)
--- PASS: TestAccAWSLB_ALB_basic (178.93s)
--- PASS: TestAccAWSLB_generatesNameForZeroValue (164.80s)
--- PASS: TestAccAWSLB_BackwardsCompatibility (179.09s)
--- FAIL: TestAccAWSLB_IPv6SubnetMapping (205.24s)
--- PASS: TestAccAWSLB_generatedName (184.63s)
--- PASS: TestAccAWSLB_namePrefix (175.90s)
--- PASS: TestAccAWSLB_NLB_basic (222.77s)
--- PASS: TestAccAWSLB_NLB_privateipv4address (219.92s)
--- PASS: TestAccAWSLB_LoadBalancerType_Gateway (233.54s)
--- PASS: TestAccAWSLB_noSecurityGroup (172.82s)
--- PASS: TestAccAWSLB_updatedSubnets (205.82s)
--- PASS: TestAccAWSLB_networkLoadbalancerEIP (258.76s)
--- PASS: TestAccAWSLB_updatedSecurityGroups (216.96s)
--- PASS: TestAccAWSLB_LoadBalancerType_Gateway_EnableCrossZoneLoadBalancing (272.09s)
--- PASS: TestAccAWSLightsailInstancePublicPorts_multiple (61.27s)
--- PASS: TestAccAWSLB_updatedIpAddressType (224.50s)
--- PASS: TestAccAWSLightsailInstancePublicPorts_cidrs (59.25s)
--- PASS: TestAccAWSLightsailInstance_basic (56.25s)
--- PASS: TestAccAWSLightsailInstancePublicPorts_basic (71.30s)
--- PASS: TestAccAWSLB_applicationLoadBalancer_updateHttp2 (240.41s)
--- PASS: TestAccAWSNetworkAclRule_missingParam (16.55s)
--- PASS: TestAccAWSLB_applicationLoadBalancer_updateDropInvalidHeaderFields (253.13s)
--- PASS: TestAccAWSNetworkAclRule_disappears (28.31s)
--- PASS: TestAccAWSNetworkAclRule_disappears_IngressEgressSameNumber (29.56s)
--- PASS: TestAccAWSNetworkAclRule_basic (36.83s)
--- PASS: TestAccAWSLB_applicationLoadBalancer_updateDeletionProtection (262.29s)
--- PASS: TestAccAWSNetworkAclRule_disappears_NetworkAcl (33.48s)
--- PASS: TestAccAWSLB_tags (279.15s)
--- PASS: TestAccAWSNetworkAclRule_ipv6 (43.92s)
--- PASS: TestAccAWSLightsailInstance_disapear (71.49s)
--- PASS: TestAccAWSNetworkAclRule_ipv6ICMP (45.43s)
--- PASS: TestAccAWSLightsailInstance_Tags (103.45s)
--- PASS: TestAccAWSLB_networkLoadbalancer_updateCrossZone (328.88s)
--- PASS: TestAccAWSNetworkAcl_disappears (51.23s)
--- PASS: TestAccAWSNetworkAcl_basic (54.77s)
--- PASS: TestAccAWSNetworkAclRule_ipv6VpcAssignGeneratedIpv6CidrBlockUpdate (75.85s)
--- PASS: TestAccAWSNetworkAclRule_allProtocol (73.72s)
--- PASS: TestAccAWSNetworkAclRule_tcpProtocol (77.20s)
--- PASS: TestAccAWSNetworkAcl_EgressAndIngressRules (56.03s)
--- PASS: TestAccAWSLightsailInstance_Name (144.33s)
--- PASS: TestAccAWSNetworkAcl_OnlyIngressRules_basic (69.60s)
--- PASS: TestAccAWSNetworkAcl_tags (124.42s)
--- PASS: TestAccAWSNetworkAcl_CaseSensitivityNoChanges (77.01s)
--- PASS: TestAccAWSNetworkAcl_OnlyEgressRules (76.63s)
--- PASS: TestAccAWSNetworkAcl_ipv6ICMPRules (60.51s)
--- PASS: TestAccAWSLB_networkLoadbalancer_subnet_change (254.60s)
--- PASS: TestAccAWSNetworkAcl_Egress_ConfigMode (142.86s)
--- PASS: TestAccAWSNetworkAcl_ipv6VpcRules (68.64s)
--- PASS: TestAccAWSNetworkAcl_ipv6Rules (77.17s)
--- PASS: TestAccAWSNetworkAcl_Ingress_ConfigMode (145.62s)
--- PASS: TestAccAWSNetworkAcl_espProtocol (60.53s)
--- PASS: TestAccAWSNetworkAcl_OnlyIngressRules_update (116.75s)
--- PASS: TestAccAWSNetworkAcl_SubnetChange (118.36s)
--- PASS: TestAccAWSNetworkAcl_Subnets (109.41s)
--- PASS: TestAccAWSNetworkAcl_SubnetsDelete (104.96s)
--- PASS: TestAccAWSLB_ALB_AccessLogs_Prefix (327.58s)
--- PASS: TestAccAWSENI_basic (73.23s)
--- PASS: TestAccAWSNatGateway_basic (250.52s)
--- PASS: TestAccAWSENI_disappears (78.82s)
--- PASS: TestAccAWSNetworkInterfaceAttachment_basic (116.31s)
--- PASS: TestAccAWSLB_ALB_AccessLogs (395.98s)
--- PASS: TestAccAWSENI_computedIPs (79.48s)
--- PASS: TestAccAWSENI_ipv6 (119.64s)
--- PASS: TestAccAWSENI_tags (118.49s)
--- PASS: TestAccAWSENI_updatedDescription (104.64s)
--- PASS: TestAccAWSNatGateway_tags (306.18s)
--- PASS: TestAccAWSENI_sourceDestCheck (111.41s)
--- PASS: TestAccAWSENI_ipv6_count (134.03s)
--- PASS: TestAccAWSLB_NLB_AccessLogs_Prefix (392.66s)
--- PASS: TestAccAWSENI_PrivateIpsCount (116.39s)
--- PASS: TestAccAWSENI_ignoreExternalAttachment (128.86s)
--- PASS: TestAccAWSENI_attached (139.93s)
--- PASS: TestAccAWSLB_NLB_AccessLogs (431.66s)

The two test failures are intermittent and unrelated to this change

@ghost ghost added size/XXL Managed by automation to categorize the size of a PR. service/ec2 Issues and PRs that pertain to the ec2 service. service/elbv2 Issues and PRs that pertain to the elbv2 service. service/iam Issues and PRs that pertain to the iam service. service/lightsail Issues and PRs that pertain to the lightsail service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Apr 27, 2021
@gdavison gdavison marked this pull request as ready for review April 29, 2021 00:06
@gdavison gdavison requested a review from a team as a code owner April 29, 2021 00:06
@ewbankkit ewbankkit self-assigned this Apr 29, 2021
ewbankkit
ewbankkit approved these changes Apr 29, 2021
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

@ewbankkit ewbankkit removed their assignment May 3, 2021
@gdavison gdavison merged commit 92abbe0 into main May 3, 2021
@gdavison gdavison deleted the remove-id-only-i-n branch May 3, 2021 23:37
@github-actions github-actions bot added this to the v3.39.0 milestone May 3, 2021
@ghost
Copy link

ghost commented May 7, 2021

This has been released in version 3.39.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@github-actions
Copy link

github-actions bot commented Jun 6, 2021

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
service/ec2 Issues and PRs that pertain to the ec2 service. service/elbv2 Issues and PRs that pertain to the elbv2 service. service/iam Issues and PRs that pertain to the iam service. service/lightsail Issues and PRs that pertain to the lightsail service. size/XXL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.39.0
Development

Successfully merging this pull request may close these issues.
2 participants
@gdavison @ewbankkit