linters: semgrep rule to replace AWSR002

[anGie44]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #18721
Preceded by #7926

Output from semgrep testing:

$ semgrep
ran 21 rules on 2451 files: 0 findings

[ewbankkit]

Running on "current" (4b72ef5) main:

% semgrep --config .semgrep.yml                     
running 20 rules...
100%|████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████|20/20
aws/resource_aws_elastic_beanstalk_application.go
severity:warning rule:helper-schema-ResourceData-Set-tags: (schema.ResourceData).Set() call with the tags key should include IgnoreConfig in the value
266:	tags = tags.IgnoreElasticbeanstalk().IgnoreConfig(ignoreTagsConfig)
267:
268:	//lintignore:AWSR002
269:	if err := d.Set("tags", tags.RemoveDefaultConfig(defaultTagsConfig).Map()); err != nil {
270:		return fmt.Errorf("error setting tags: %w", err)
271:	}

aws/resource_aws_elastic_beanstalk_application_version.go
severity:warning rule:helper-schema-ResourceData-Set-tags: (schema.ResourceData).Set() call with the tags key should include IgnoreConfig in the value
134:	tags = tags.IgnoreElasticbeanstalk().IgnoreConfig(ignoreTagsConfig)
135:
136:	//lintignore:AWSR002
137:	if err := d.Set("tags", tags.RemoveDefaultConfig(defaultTagsConfig).Map()); err != nil {
138:		return fmt.Errorf("error setting tags: %w", err)
139:	}

aws/resource_aws_elastic_beanstalk_environment.go
severity:warning rule:helper-schema-ResourceData-Set-tags: (schema.ResourceData).Set() call with the tags key should include IgnoreConfig in the value
627:	tags = tags.IgnoreElasticbeanstalk().IgnoreConfig(ignoreTagsConfig)
628:
629:	//lintignore:AWSR002
630:	if err := d.Set("tags", tags.RemoveDefaultConfig(defaultTagsConfig).Map()); err != nil {
631:		return fmt.Errorf("error setting tags: %w", err)
632:	}

aws/resource_aws_waf_rate_based_rule.go
severity:warning rule:helper-schema-ResourceData-Set-tags: (schema.ResourceData).Set() call with the tags key should include IgnoreConfig in the value
164:	tags := tagList.IgnoreAws().IgnoreConfig(ignoreTagsConfig)
165:
166:	//lintignore:AWSR002
167:	if err := d.Set("tags", tags.RemoveDefaultConfig(defaultTagsConfig).Map()); err != nil {
168:		return fmt.Errorf("error setting tags: %w", err)
169:	}

aws/resource_aws_wafregional_rate_based_rule.go
severity:warning rule:helper-schema-ResourceData-Set-tags: (schema.ResourceData).Set() call with the tags key should include IgnoreConfig in the value
164:	tags := tagList.IgnoreAws().IgnoreConfig(ignoreTagsConfig)
165:
166:	//lintignore:AWSR002
167:	if err := d.Set("tags", tags.RemoveDefaultConfig(defaultTagsConfig).Map()); err != nil {
168:		return fmt.Errorf("error setting tags: %w", err)
169:	}
ran 20 rules on 2451 files: 5 findings

[anGie44]

Running on "current" (4b72ef5) main:

Ohh interesting! I'll add a pattern for the IgnoreElasticBeanstalk and generalize the tags.IgnoreAws() so tagsList gets included. I'm not too sure if the entire rule though is optimal 😅 a lot of pattern-not conditions, I wonder if there's a better way to group them 🤔 ?

I noticed the rule wasn't catching changes in a data-source b/c of the original pattern the rule is looking for, so i've added separate rule for just data-sources

[YakDriver]

Excellent! 🎉

% semgrep
running 22 rules...
100%|█████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████|22/22
ran 22 rules on 2459 files: 0 findings

[ghost]

This has been released in version 3.38.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.