Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tech-debt: refactor iam data source and resource to use different Read methods #18846

Merged
merged 1 commit into from
Apr 14, 2021

Conversation

anGie44
Copy link
Contributor

@anGie44 anGie44 commented Apr 14, 2021

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #18819
Relates #7926

Output from acceptance testing (Commercial):

--- SKIP: TestAccAWSDataSourceIAMPolicyDocument_statementPrincipalIdentifiers_multiplePrincipalsGov (0.73s)
--- PASS: TestAccAWSDataSourceIAMPolicyDocument_sourceListConflicting (14.79s)
--- PASS: TestAccAWSDataSourceIAMPolicyDocument_overrideList (58.13s)
--- PASS: TestAccAWSDataSourceIAMPolicyDocument_sourceList (58.70s)
--- PASS: TestAccAWSDataSourceIAMPolicyDocument_sourceConflicting (58.95s)
--- PASS: TestAccAWSDataSourceIAMPolicyDocument_noStatementOverride (59.20s)
--- PASS: TestAccAWSDataSourceIAMPolicyDocument_statementPrincipalIdentifiers_multiplePrincipals (59.96s)
--- PASS: TestAccAWSDataSourceIAMPolicyDocument_override (59.77s)
--- PASS: TestAccAWSDataSourceIAMPolicyDocument_statementPrincipalIdentifiers_stringAndSlice (61.46s)
--- PASS: TestAccAWSDataSourceIAMPolicyDocument_basic (61.80s)
--- PASS: TestAccAWSDataSourceIAMPolicyDocument_noStatementMerge (62.00s)
--- PASS: TestAccAWSDataSourceIAMPolicyDocument_duplicateSid (65.73s)
--- PASS: TestAccAWSDataSourceIAMPolicy_basic (66.55s)
--- PASS: TestAccAWSIAMPolicy_basic (69.72s)
--- PASS: TestAccAWSIAMPolicy_description (61.42s)
--- PASS: TestAccAWSDataSourceIAMPolicyDocument_version20081017 (81.87s)
--- PASS: TestAccAWSDataSourceIAMPolicyDocument_source (84.87s)
--- PASS: TestAccAWSIAMPolicy_disappears (29.47s)
--- PASS: TestAccAWSIAMPolicyAttachment_Users_RenamedUser (93.55s)
--- PASS: TestAccAWSIAMPolicyAttachment_Groups_RenamedGroup (93.73s)
--- PASS: TestAccAWSIAMPolicyAttachment_Roles_RenamedRole (96.69s)
--- PASS: TestAccAWSIAMPolicy_namePrefix (37.23s)
--- PASS: TestAccAWSIAMPolicy_path (37.11s)
--- PASS: TestAccAWSIAMPolicyAttachment_basic (100.54s)
--- PASS: TestAccAWSIAMPolicy_policy (49.30s)
--- PASS: TestAccAWSIAMPolicy_tags (60.08s)
--- PASS: TestAccAWSIAMPolicyAttachment_paginatedEntities (287.60s)

@anGie44 anGie44 requested a review from a team as a code owner April 14, 2021 00:27
@ghost ghost added size/L Managed by automation to categorize the size of a PR. service/iam Issues and PRs that pertain to the iam service. labels Apr 14, 2021
@anGie44 anGie44 added the technical-debt Addresses areas of the codebase that need refactoring or redesign. label Apr 14, 2021
@bflad bflad self-assigned this Apr 14, 2021
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 🚀

Output from acceptance testing:

--- PASS: TestAccAWSIAMPolicy_disappears (12.90s)
--- PASS: TestAccAWSIAMPolicy_namePrefix (17.12s)
--- PASS: TestAccAWSIAMPolicy_description (17.17s)
--- PASS: TestAccAWSIAMPolicy_basic (17.22s)
--- PASS: TestAccAWSIAMPolicy_path (17.27s)
--- PASS: TestAccAWSIAMPolicy_policy (26.06s)
--- PASS: TestAccAWSIAMPolicy_tags (34.48s)

--- PASS: TestAccAWSDataSourceIAMPolicy_basic (15.43s)

@anGie44 anGie44 added this to the v3.37.0 milestone Apr 14, 2021
@anGie44 anGie44 merged commit cac493d into main Apr 14, 2021
@anGie44 anGie44 deleted the td-read-method-of-i-data-sources branch April 14, 2021 15:22
@ghost
Copy link

ghost commented Apr 16, 2021

This has been released in version 3.37.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented May 14, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators May 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/iam Issues and PRs that pertain to the iam service. size/L Managed by automation to categorize the size of a PR. technical-debt Addresses areas of the codebase that need refactoring or redesign.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants