Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests/r/waf: Add sweeper concurrency #18631

Merged
merged 18 commits into from
Jun 17, 2021
Merged

tests/r/waf: Add sweeper concurrency #18631

merged 18 commits into from
Jun 17, 2021

Conversation

YakDriver
Copy link
Member

@YakDriver YakDriver commented Apr 7, 2021 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #15334

Output from acceptance testing: N/A

@YakDriver YakDriver requested a review from a team as a code owner April 7, 2021 19:32
@ghost ghost added size/XL Managed by automation to categorize the size of a PR. service/waf Issues and PRs that pertain to the waf service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Apr 7, 2021
@YakDriver
Copy link
Member Author

I upped the ante a little with concurrent reads since each of those will hit AWS as well. Probably not 100% necessary but why not?

@YakDriver YakDriver mentioned this pull request Apr 8, 2021
Closed
@anGie44 anGie44 self-assigned this Jun 17, 2021
anGie44
anGie44 approved these changes Jun 17, 2021
View reviewed changes
Copy link
Contributor

@anGie44 anGie44 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 (going by the concurrent reads done in the dynmodb table sweeper, seems ok to have)

YakDriver added 18 commits June 17, 2021 16:03
@YakDriver
tests/r/waf_byte_match_set: Add sweeper concurrency
a19cb6d
@YakDriver
tests/r/waf_geo_match_set: Add sweeper concurrency
b22a9d5
@YakDriver
tests/r/waf_ipset: Add sweeper concurrency
c27563c
@YakDriver
tests/r/waf_byte_match_set: Add read concurrency
f3dbf44
@YakDriver
tests/r/waf_geo_match_set: Add read concurrency
6459516
@YakDriver
tests/r/waf_ipset: Add read concurrency
4644295
@YakDriver
tests/r/waf_rate_based_rule: Add sweeper concurrency
3671afd
@YakDriver
tests/r/waf_regex_match_set: Add sweeper concurrency
0af45b9
@YakDriver
tests/r/waf_regex_pattern_set: Add sweeper concurrency
d3f7266
@YakDriver
tests/r/waf_rule_group: Add sweeper concurrency
c0f254f
@YakDriver
tests/r/waf_rule: Add sweeper concurrency
4d59d82
@YakDriver
tests/r/waf_size_constraint_set: Add sweeper concurrency
c572b50
@YakDriver
tests/r/waf_sql_injection_match_set: Add sweeper concurrency
2404a91
@YakDriver
tests/r/waf_web_acl: Add read/sweeper concurrency
e4f592c
@YakDriver
tests/r/waf_xss_match_set: Add sweeper concurrency
1528e3f
@YakDriver
tests/r/waf: Consistent var list
482f2d1
@YakDriver
tests/r/waf: Use consistent var name
d216e99
@YakDriver
tests/r/waf: Remove unneeded len check
ab9605e
@YakDriver YakDriver added this to the v3.46.0 milestone Jun 17, 2021
@YakDriver YakDriver merged commit 87cbd86 into main Jun 17, 2021
@YakDriver YakDriver deleted the t-concsweep-waf branch June 17, 2021 22:30
@github-actions
Copy link

This functionality has been released in v3.46.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@anGie44 anGie44 anGie44 approved these changes

Assignees

@anGie44 anGie44

Labels
service/waf Issues and PRs that pertain to the waf service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.46.0
Development

Successfully merging this pull request may close these issues.
2 participants
@YakDriver @anGie44