Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add FIFO topic support for aws_sns_topic data source #18087

Closed
wants to merge 9 commits into from
Closed

[WIP] Add FIFO topic support for aws_sns_topic data source #18087

wants to merge 9 commits into from

Conversation

bitle
Copy link

@bitle bitle commented Mar 14, 2021

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccDataSourceAwsSnsTopic_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccDataSourceAwsSnsTopic_ -timeout 180m
=== RUN   TestAccDataSourceAwsSnsTopic_basic
=== PAUSE TestAccDataSourceAwsSnsTopic_basic
=== RUN   TestAccDataSourceAwsSnsTopic_fifo
=== PAUSE TestAccDataSourceAwsSnsTopic_fifo
=== CONT  TestAccDataSourceAwsSnsTopic_basic
=== CONT  TestAccDataSourceAwsSnsTopic_fifo
--- PASS: TestAccDataSourceAwsSnsTopic_basic (50.79s)
--- PASS: TestAccDataSourceAwsSnsTopic_fifo (53.95s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       56.413s

@ghost ghost added size/M Managed by automation to categorize the size of a PR. service/sns Issues and PRs that pertain to the sns service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Mar 14, 2021
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Mar 14, 2021
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @bitle 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Apr 14, 2021
@ewbankkit
Copy link
Contributor

@bitle Thanks for the contribution 👏.
I have included support for FIFO topics in the aws_sns_topic data source in #15828.

@ewbankkit ewbankkit closed this Apr 14, 2021
@ghost
Copy link

ghost commented May 14, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators May 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/sns Issues and PRs that pertain to the sns service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants