Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests/ec2/ebs: Rename tests #17893

Closed
wants to merge 3 commits into from
Closed

tests/ec2/ebs: Rename tests #17893

wants to merge 3 commits into from

Conversation

YakDriver
Copy link
Member

@YakDriver YakDriver commented Mar 3, 2021 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #17847

Output from acceptance testing: (N/A, handled by daily)

@YakDriver YakDriver requested a review from a team as a code owner March 3, 2021 02:47
@ghost ghost added size/M Managed by automation to categorize the size of a PR. service/ec2 Issues and PRs that pertain to the ec2 service. service/kms Issues and PRs that pertain to the kms service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Mar 3, 2021
breathingdust
breathingdust approved these changes Aug 17, 2021
View reviewed changes
Copy link
Member

@breathingdust breathingdust left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀 Though might be worth resolving the conversation in #17849 first before we merge

This was referenced Oct 14, 2021
Merged
Closed
@github-actions github-actions bot added this to the v3.64.0 milestone Oct 14, 2021
@github-actions
Copy link

github-actions bot commented Nov 4, 2021

This functionality has been released in v3.64.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@ewbankkit ewbankkit deleted the td-test-rename-ebs branch March 3, 2022 21:11
@ewbankkit ewbankkit restored the td-test-rename-ebs branch March 3, 2022 21:11
@ewbankkit ewbankkit deleted the td-test-rename-ebs branch March 3, 2022 21:27
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@breathingdust breathingdust breathingdust approved these changes

Assignees
No one assigned
Labels
service/ec2 Issues and PRs that pertain to the ec2 service. service/kms Issues and PRs that pertain to the kms service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.64.0
Development

Successfully merging this pull request may close these issues.
2 participants
@YakDriver @breathingdust