Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AppConfig service #17785

Merged
merged 1 commit into from
Apr 29, 2021
Merged

Conversation

shuheiktgw
Copy link
Collaborator

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #11973

Output from acceptance testing:

None

For a first step, I've added the AppConfig service. Thank you for your review!

@shuheiktgw shuheiktgw requested a review from a team as a code owner February 23, 2021 23:26
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. labels Feb 23, 2021
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Feb 23, 2021
@ewbankkit
Copy link
Contributor

@shuheiktgw Thanks for the contribution.
Could you please also add the new service to infrastructure/repository/labels-service.tf.

@shuheiktgw
Copy link
Collaborator Author

Thank you for your review, @ewbankkit! Somehow it seems appconfig has been already added!

@ewbankkit
Copy link
Contributor

@shuheiktgw Yes it is, I must have been looking at an older version 😄.

Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ryandeivert
Copy link
Contributor

hi @ewbankkit it looks like this is approved and pending merge -- the following is dependent on this and awaiting merge of this PR:

#18032

@bflad bflad removed the needs-triage Waiting for first response or review from a maintainer. label Apr 29, 2021
@bflad bflad self-assigned this Apr 29, 2021
@bflad bflad merged commit a8ff8a1 into hashicorp:main Apr 29, 2021
@github-actions github-actions bot added this to the v3.38.0 milestone Apr 29, 2021
@ghost
Copy link

ghost commented Apr 30, 2021

This has been released in version 3.38.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants