-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
aws_ec2_carrier_gateway: Correct the ARN account id #17736
aws_ec2_carrier_gateway: Correct the ARN account id #17736
Conversation
@ewbankkit, can you assist? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSEc2CarrierGateway_' ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 2 -run=TestAccAWSEc2CarrierGateway_ -timeout 120m
=== RUN TestAccAWSEc2CarrierGateway_basic
=== PAUSE TestAccAWSEc2CarrierGateway_basic
=== RUN TestAccAWSEc2CarrierGateway_disappears
=== PAUSE TestAccAWSEc2CarrierGateway_disappears
=== RUN TestAccAWSEc2CarrierGateway_Tags
=== PAUSE TestAccAWSEc2CarrierGateway_Tags
=== CONT TestAccAWSEc2CarrierGateway_basic
=== CONT TestAccAWSEc2CarrierGateway_Tags
=== CONT TestAccAWSEc2CarrierGateway_disappears
--- PASS: TestAccAWSEc2CarrierGateway_basic (30.41s)
--- PASS: TestAccAWSEc2CarrierGateway_disappears (20.41s)
--- PASS: TestAccAWSEc2CarrierGateway_Tags (72.71s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 72.837s
@shuheiktgw Thanks for the contribution. |
@ewbankkit |
LGTM 🚀 Thanks @shuheiktgw! Verified Acceptance Tests in Commercial (us-west-2) make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSEc2CarrierGateway_' ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 2 -run=TestAccAWSEc2CarrierGateway_ -timeout 120m
=== RUN TestAccAWSEc2CarrierGateway_basic
=== PAUSE TestAccAWSEc2CarrierGateway_basic
=== RUN TestAccAWSEc2CarrierGateway_disappears
=== PAUSE TestAccAWSEc2CarrierGateway_disappears
=== RUN TestAccAWSEc2CarrierGateway_Tags
=== PAUSE TestAccAWSEc2CarrierGateway_Tags
=== CONT TestAccAWSEc2CarrierGateway_basic
=== CONT TestAccAWSEc2CarrierGateway_Tags
--- PASS: TestAccAWSEc2CarrierGateway_basic (22.67s)
=== CONT TestAccAWSEc2CarrierGateway_disappears
--- PASS: TestAccAWSEc2CarrierGateway_disappears (15.41s)
--- PASS: TestAccAWSEc2CarrierGateway_Tags (53.61s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 57.217s Verified Acceptance Tests in GovCloud (us-gov-west-1) make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSEc2CarrierGateway_' ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 2 -run=TestAccAWSEc2CarrierGateway_ -timeout 120m
=== RUN TestAccAWSEc2CarrierGateway_basic
=== PAUSE TestAccAWSEc2CarrierGateway_basic
=== RUN TestAccAWSEc2CarrierGateway_disappears
=== PAUSE TestAccAWSEc2CarrierGateway_disappears
=== RUN TestAccAWSEc2CarrierGateway_Tags
=== PAUSE TestAccAWSEc2CarrierGateway_Tags
=== CONT TestAccAWSEc2CarrierGateway_basic
=== CONT TestAccAWSEc2CarrierGateway_Tags
resource_aws_ec2_carrier_gateway_test.go:246: skipping since no Wavelength Zones are available
=== CONT TestAccAWSEc2CarrierGateway_basic
resource_aws_ec2_carrier_gateway_test.go:246: skipping since no Wavelength Zones are available
--- SKIP: TestAccAWSEc2CarrierGateway_basic (0.91s)
=== CONT TestAccAWSEc2CarrierGateway_disappears
--- SKIP: TestAccAWSEc2CarrierGateway_Tags (0.91s)
=== CONT TestAccAWSEc2CarrierGateway_disappears
resource_aws_ec2_carrier_gateway_test.go:246: skipping since no Wavelength Zones are available
--- SKIP: TestAccAWSEc2CarrierGateway_disappears (0.16s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 3.917s |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
Community Note
Relates #16978
Output from acceptance testing:
I couldn't access the wavelength zone, so would anybody run the ACC tests instead?