Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws_ec2_carrier_gateway: Correct the ARN account id #17736

Merged

Conversation

shuheiktgw
Copy link
Collaborator

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #16978

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSEc2CarrierGateway_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSEc2CarrierGateway_ -timeout 120m
=== RUN   TestAccAWSEc2CarrierGateway_basic
=== PAUSE TestAccAWSEc2CarrierGateway_basic
=== RUN   TestAccAWSEc2CarrierGateway_disappears
=== PAUSE TestAccAWSEc2CarrierGateway_disappears
=== RUN   TestAccAWSEc2CarrierGateway_Tags
=== PAUSE TestAccAWSEc2CarrierGateway_Tags
=== CONT  TestAccAWSEc2CarrierGateway_basic
=== CONT  TestAccAWSEc2CarrierGateway_Tags
=== CONT  TestAccAWSEc2CarrierGateway_disappears
=== CONT  TestAccAWSEc2CarrierGateway_basic
    resource_aws_ec2_carrier_gateway_test.go:246: skipping since no Wavelength Zones are available
--- SKIP: TestAccAWSEc2CarrierGateway_basic (2.88s)
=== CONT  TestAccAWSEc2CarrierGateway_disappears
    resource_aws_ec2_carrier_gateway_test.go:246: skipping since no Wavelength Zones are available
--- SKIP: TestAccAWSEc2CarrierGateway_disappears (2.88s)
=== CONT  TestAccAWSEc2CarrierGateway_Tags
    resource_aws_ec2_carrier_gateway_test.go:246: skipping since no Wavelength Zones are available
--- SKIP: TestAccAWSEc2CarrierGateway_Tags (2.89s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	4.936s

I couldn't access the wavelength zone, so would anybody run the ACC tests instead?

@shuheiktgw shuheiktgw requested a review from a team as a code owner February 20, 2021 23:25
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. service/ec2 Issues and PRs that pertain to the ec2 service. labels Feb 20, 2021
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Feb 20, 2021
@DrFaust92
Copy link
Collaborator

@ewbankkit, can you assist?

@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Feb 21, 2021
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSEc2CarrierGateway_' ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 2 -run=TestAccAWSEc2CarrierGateway_ -timeout 120m
=== RUN   TestAccAWSEc2CarrierGateway_basic
=== PAUSE TestAccAWSEc2CarrierGateway_basic
=== RUN   TestAccAWSEc2CarrierGateway_disappears
=== PAUSE TestAccAWSEc2CarrierGateway_disappears
=== RUN   TestAccAWSEc2CarrierGateway_Tags
=== PAUSE TestAccAWSEc2CarrierGateway_Tags
=== CONT  TestAccAWSEc2CarrierGateway_basic
=== CONT  TestAccAWSEc2CarrierGateway_Tags
=== CONT  TestAccAWSEc2CarrierGateway_disappears
--- PASS: TestAccAWSEc2CarrierGateway_basic (30.41s)
--- PASS: TestAccAWSEc2CarrierGateway_disappears (20.41s)
--- PASS: TestAccAWSEc2CarrierGateway_Tags (72.71s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	72.837s

@ewbankkit
Copy link
Contributor

@shuheiktgw Thanks for the contribution.
Could you please also update this documentation in website/docs/index.html.markdown to remove the affected resources and data sources.

@shuheiktgw
Copy link
Collaborator Author

@ewbankkit ec2_carrier_gateway does not seem to be listed in the document!

@breathingdust
Copy link
Member

LGTM 🚀 Thanks @shuheiktgw!

Verified Acceptance Tests in Commercial (us-west-2)

make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSEc2CarrierGateway_' ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 2 -run=TestAccAWSEc2CarrierGateway_ -timeout 120m
=== RUN   TestAccAWSEc2CarrierGateway_basic
=== PAUSE TestAccAWSEc2CarrierGateway_basic
=== RUN   TestAccAWSEc2CarrierGateway_disappears
=== PAUSE TestAccAWSEc2CarrierGateway_disappears
=== RUN   TestAccAWSEc2CarrierGateway_Tags
=== PAUSE TestAccAWSEc2CarrierGateway_Tags
=== CONT  TestAccAWSEc2CarrierGateway_basic
=== CONT  TestAccAWSEc2CarrierGateway_Tags
--- PASS: TestAccAWSEc2CarrierGateway_basic (22.67s)
=== CONT  TestAccAWSEc2CarrierGateway_disappears
--- PASS: TestAccAWSEc2CarrierGateway_disappears (15.41s)
--- PASS: TestAccAWSEc2CarrierGateway_Tags (53.61s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	57.217s

Verified Acceptance Tests in GovCloud (us-gov-west-1)

make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSEc2CarrierGateway_' ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 2 -run=TestAccAWSEc2CarrierGateway_ -timeout 120m
=== RUN   TestAccAWSEc2CarrierGateway_basic
=== PAUSE TestAccAWSEc2CarrierGateway_basic
=== RUN   TestAccAWSEc2CarrierGateway_disappears
=== PAUSE TestAccAWSEc2CarrierGateway_disappears
=== RUN   TestAccAWSEc2CarrierGateway_Tags
=== PAUSE TestAccAWSEc2CarrierGateway_Tags
=== CONT  TestAccAWSEc2CarrierGateway_basic
=== CONT  TestAccAWSEc2CarrierGateway_Tags
    resource_aws_ec2_carrier_gateway_test.go:246: skipping since no Wavelength Zones are available
=== CONT  TestAccAWSEc2CarrierGateway_basic
    resource_aws_ec2_carrier_gateway_test.go:246: skipping since no Wavelength Zones are available
--- SKIP: TestAccAWSEc2CarrierGateway_basic (0.91s)
=== CONT  TestAccAWSEc2CarrierGateway_disappears
--- SKIP: TestAccAWSEc2CarrierGateway_Tags (0.91s)
=== CONT  TestAccAWSEc2CarrierGateway_disappears
    resource_aws_ec2_carrier_gateway_test.go:246: skipping since no Wavelength Zones are available
--- SKIP: TestAccAWSEc2CarrierGateway_disappears (0.16s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	3.917s

@breathingdust breathingdust merged commit 3174772 into hashicorp:main Mar 18, 2021
@ghost
Copy link

ghost commented Apr 17, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Apr 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/ec2 Issues and PRs that pertain to the ec2 service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants