Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

F/aws ebs snapshot #17730

Closed
wants to merge 10,000 commits into from
Closed

Conversation

nikhil-goenka
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #17491

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSEBSSnapshot_Outpost'
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSEBSSnapshot_Outpost -timeout 120m
=== RUN   TestAccAWSEBSSnapshot_Outpost
=== PAUSE TestAccAWSEBSSnapshot_Outpost
=== CONT  TestAccAWSEBSSnapshot_Outpost
    data_source_aws_outposts_outposts_test.go:66: skipping since no Outposts found
--- SKIP: TestAccAWSEBSSnapshot_Outpost (4.86s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	8.878s
...

@nikhil-goenka nikhil-goenka requested a review from a team as a code owner February 20, 2021 16:28
@ghost ghost added size/M Managed by automation to categorize the size of a PR. service/ec2 Issues and PRs that pertain to the ec2 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Feb 20, 2021
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Feb 20, 2021
@FireballDWF
Copy link

@nikhil-goenka Could you please resolve the conflicting file, then I'll help push for this to get reviewed

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. service/autoscaling Issues and PRs that pertain to the autoscaling service. service/cloudformation Issues and PRs that pertain to the cloudformation service. labels Sep 2, 2021
nikhil-goenka and others added 20 commits September 2, 2021 09:54
…orp#20701)

As shown in hashicorp#20493 the documentation does not accurately reflect the current observed behaviour of this provider. The docs say that metadata_options.http_endpoint is optional, but the provider gives an error if http_endpoint is omitted.
@github-actions github-actions bot added the service/securityhub Issues and PRs that pertain to the securityhub service. label Sep 2, 2021
@breathingdust breathingdust added service/outposts Issues and PRs that pertain to the outposts service. and removed needs-triage Waiting for first response or review from a maintainer. labels Sep 8, 2021
@FireballDWF
Copy link

@nikhil-goenka please fix the failing check, once all checks pass, I'll request a review

@zhelding
Copy link
Contributor

Pull request #21306 has significantly refactored the AWS Provider codebase. As a result, most PRs opened prior to the refactor now have merge conflicts that must be resolved before proceeding.

Specifically, PR #21306 relocated the code for all AWS resources and data sources from a single aws directory to a large number of separate directories in internal/service, each corresponding to a particular AWS service. This separation of code has also allowed for us to simplify the names of underlying functions -- while still avoiding namespace collisions.

We recognize that many pull requests have been open for some time without yet being addressed by our maintainers. Therefore, we want to make it clear that resolving these conflicts in no way affects the prioritization of a particular pull request. Once a pull request has been prioritized for review, the necessary changes will be made by a maintainer -- either directly or in collaboration with the pull request author.

For a more complete description of this refactor, including examples of how old filepaths and function names correspond to their new counterparts: please refer to issue #20000.

For a quick guide on how to amend your pull request to resolve the merge conflicts resulting from this refactor and bring it in line with our new code patterns: please refer to our Service Package Refactor Pull Request Guide.

@ewbankkit
Copy link
Contributor

Superseded by #22342.

@ewbankkit ewbankkit closed this Dec 31, 2021
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. service/autoscaling Issues and PRs that pertain to the autoscaling service. service/cloudformation Issues and PRs that pertain to the cloudformation service. service/ec2 Issues and PRs that pertain to the ec2 service. service/outposts Issues and PRs that pertain to the outposts service. service/securityhub Issues and PRs that pertain to the securityhub service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

outpost_arn support for aws_ebs_snapshot
7 participants