-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
data source aws_ec2_transit_gateway_route_tables #17587
data source aws_ec2_transit_gateway_route_tables #17587
Conversation
Use dot internal instead of dot local
… is not even slightly my first language. This is to resolve 12373 which I would like to resolve for selfish reasons as it affects me. It seemed like a good place to start. The new data source "aws_ec2_transit_gateway_route_tables" is modelled after "aws_route_tables". The code is shamelessly plagiarized from the aws_route_tables and the aws_transit_gateway_route_table resources. I've included tests which I think are right, but I'm not sure on protocol for running them. The code compiles. Which is a good start.
…_transit_gateway_route_table
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome @mrobinson-anaplan 👋
It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.
Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.
Thanks again, and welcome to the community! 😃
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
Greetings. This is my first attempt to contribute to any public terraform provider and go is not even slightly my first language.
This is to resolve 12373 which I would like to resolve for selfish reasons as it affects me. It seemed like a good place to start contributing as I'm a heavy user of the really rather excellent provider.
The new data source "aws_ec2_transit_gateway_route_tables" is modelled after "aws_route_tables". The code is shamelessly plagiarised from the aws_route_tables and the aws_transit_gateway_route_table data sources.
Community Note
Relates OR Closes #12373
Output from acceptance testing: