Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/aws_apigatewayv2_route: Better documentation for 'authorization_type' and 'target' attributes #17500

Merged
merged 1 commit into from
Feb 10, 2021
Merged

r/aws_apigatewayv2_route: Better documentation for 'authorization_type' and 'target' attributes #17500

merged 1 commit into from
Feb 10, 2021

Conversation

ewbankkit
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #12972.
Closes #17497.

Output from acceptance testing:

n/a

@ewbankkit ewbankkit requested a review from a team as a code owner February 7, 2021 22:25
@ghost ghost added size/S Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/apigatewayv2 Issues and PRs that pertain to the apigatewayv2 service. labels Feb 7, 2021
DrFaust92
DrFaust92 approved these changes Feb 7, 2021
View reviewed changes
Copy link
Collaborator

@DrFaust92 DrFaust92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@breathingdust
Copy link
Member

LGTM, thanks @ewbankkit 🚀

@breathingdust breathingdust merged commit 4a4ced5 into hashicorp:main Feb 10, 2021
@github-actions github-actions bot added this to the v3.28.0 milestone Feb 10, 2021
@ewbankkit ewbankkit deleted the d-aws_apigatewayv2_route-better-descriptions branch February 10, 2021 16:59
@ghost
Copy link

ghost commented Feb 12, 2021

This has been released in version 3.28.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Mar 12, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Mar 12, 2021
@DrFaust92 DrFaust92 removed their assignment Jun 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@DrFaust92 DrFaust92 DrFaust92 approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. service/apigatewayv2 Issues and PRs that pertain to the apigatewayv2 service. size/S Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v3.28.0
3 participants
@ewbankkit @breathingdust @DrFaust92