Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates terrafmt to 0.3.0 + function parameter fix #17451

Merged
merged 3 commits into from
Feb 6, 2021
Merged

Conversation

gdavison
Copy link
Contributor

@gdavison gdavison commented Feb 4, 2021

Updates terrafmt to v0.3.0 + function parameter fix katbyte/terrafmt#41

@gdavison gdavison requested a review from a team as a code owner February 4, 2021 06:07
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. labels Feb 4, 2021
@gdavison gdavison added the linter Pertains to changes to or issues with the various linters. label Feb 4, 2021
github.com/pavius/impi v0.0.3 // indirect
github.com/terraform-linters/tflint v0.20.3
)

replace github.com/katbyte/terrafmt => github.com/gdavison/terrafmt v0.2.1-0.20201026181004-a896893cd6af
replace github.com/katbyte/terrafmt => github.com/gdavison/terrafmt v0.3.1-0.20210204054728-84242796be99
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to get off this fork yet?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Soon, hopefully. It's using an actual Go parser instead of string matching to extract the Terraform blocks.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay -- for whatever reason dependabot isn't happy with this type of Go module replacement setup.

Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once rebased and/or tidied again 🚀

@ghost ghost added size/M Managed by automation to categorize the size of a PR. and removed size/XS Managed by automation to categorize the size of a PR. labels Feb 5, 2021
@ghost ghost added size/L Managed by automation to categorize the size of a PR. and removed size/M Managed by automation to categorize the size of a PR. labels Feb 5, 2021
@gdavison gdavison merged commit a080b4e into main Feb 6, 2021
@gdavison gdavison deleted the update-terrafmt branch February 6, 2021 00:00
@github-actions github-actions bot added this to the v3.28.0 milestone Feb 6, 2021
@ghost
Copy link

ghost commented Feb 12, 2021

This has been released in version 3.28.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Mar 8, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Mar 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
linter Pertains to changes to or issues with the various linters. size/L Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants