Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/aws_db_instance Bugfix: Pass db_subnet_group_name in restore_to_point_in_time (Issue #16821) #16830

Merged
merged 1 commit into from
Dec 18, 2020
Merged

r/aws_db_instance Bugfix: Pass db_subnet_group_name in restore_to_point_in_time (Issue #16821) #16830

merged 1 commit into from
Dec 18, 2020

Conversation

cyrusv
Copy link
Contributor

@cyrusv cyrusv commented Dec 17, 2020 •
edited
Loading

Resolves a misspelling in #15969

Resolves #16821

Release note for CHANGELOG:

BUG FIXES:

  • resource/aws_db_instance: db_subnet_group_name passed correctly now

@cyrusv cyrusv requested a review from a team as a code owner December 17, 2020 21:22
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. service/rds Issues and PRs that pertain to the rds service. labels Dec 17, 2020
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Dec 17, 2020
@cyrusv cyrusv mentioned this pull request Dec 17, 2020
Closed
@cyrusv cyrusv changed the title #16821 Fix spelling of db_subnet_group_name in restore_to_point_in_time #16821 Bugfix: Pass db_subnet_group_name in restore_to_point_in_time for RDS Dec 17, 2020
github-actions[bot]
github-actions bot reviewed Dec 17, 2020
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @cyrusv 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@cyrusv cyrusv changed the title #16821 Bugfix: Pass db_subnet_group_name in restore_to_point_in_time for RDS r/aws_db_instance Bugfix: Pass db_subnet_group_name in restore_to_point_in_time Dec 17, 2020
@cyrusv cyrusv changed the title r/aws_db_instance Bugfix: Pass db_subnet_group_name in restore_to_point_in_time r/aws_db_instance Bugfix: Pass db_subnet_group_name in restore_to_point_in_time (Issue #16821) Dec 18, 2020
@cyrusv
Copy link
Contributor Author

cyrusv commented Dec 18, 2020

@YakDriver -- I think this resolves a small bug in #15969 -- can you take a look?

@anGie44 anGie44 added bug Addresses a defect in current functionality. and removed needs-triage Waiting for first response or review from a maintainer. labels Dec 18, 2020
anGie44
anGie44 approved these changes Dec 18, 2020
View reviewed changes
Copy link
Contributor

@anGie44 anGie44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR @cyrusv ! LGTM 🚀

@anGie44 anGie44 added this to the v3.22.0 milestone Dec 18, 2020
@anGie44 anGie44 merged commit c84391e into hashicorp:master Dec 18, 2020
anGie44 added a commit that referenced this pull request Dec 18, 2020
@anGie44
Update CHANGELOG for #16830
ad5f5c3
@cyrusv cyrusv deleted the cyrus-restore-rds-db-subnet-group branch December 18, 2020 01:57
@cyrusv
Copy link
Contributor Author

cyrusv commented Dec 18, 2020

Thanks, @anGie44! Does this not get backported as bigfix against all minor versions after 3.15.0?

@anGie44
Copy link
Contributor

anGie44 commented Dec 18, 2020

Hi @cyrusv 👋 For a fix like this, it will only be added to the most recent major version. In general, we only make exceptions in cases of a discovered security vulnerability/high community demand for which backporting may be the most reasonable course. Due to the high touch nature of provider development and the extensive regression testing required to ensure stability, maintaining multiple versions of the provider is not sustainable at this time.

@ghost
Copy link

ghost commented Dec 18, 2020

This has been released in version 3.22.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Jan 17, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Jan 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@anGie44 anGie44 anGie44 approved these changes

Assignees
No one assigned
Labels
bug Addresses a defect in current functionality. service/rds Issues and PRs that pertain to the rds service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v3.22.0
Development

Successfully merging this pull request may close these issues.

RDS Not Passing db_subnet_group_name with restore_to_point_in_time
2 participants
@cyrusv @anGie44