Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Resource: aws_ec2_transit_gateway_prefix_list_reference #16823

Merged
merged 4 commits into from
Feb 4, 2021

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Dec 17, 2020

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #16572

Release note for CHANGELOG:

* **New Resource:** `aws_ec2_transit_gateway_prefix_list_reference`

Output from acceptance testing in AWS Commercial:

--- PASS: TestAccAwsEc2TransitGatewayPrefixListReference_disappears (214.31s)
--- PASS: TestAccAwsEc2TransitGatewayPrefixListReference_basic (217.12s)
--- PASS: TestAccAwsEc2TransitGatewayPrefixListReference_disappears_TransitGateway (219.77s)
--- PASS: TestAccAwsEc2TransitGatewayPrefixListReference_TransitGatewayAttachmentId (397.05s)

Output from acceptance testing in AWS GovCloud (US) (requires #16806):

=== CONT  TestAccAwsEc2TransitGatewayPrefixListReference_disappears
    resource_aws_ec2_transit_gateway_prefix_list_reference_test.go:50: Step 1/1 error: Error running apply:
        Error: error creating EC2 Managed Prefix List: InvalidAction: The action CreateManagedPrefixList is not valid for this web service.
        	status code: 400, request id: b632eede-aa51-48b3-9c29-f8fad25b70df


=== CONT  TestAccAwsEc2TransitGatewayPrefixListReference_basic
    resource_aws_ec2_transit_gateway_prefix_list_reference_test.go:21: Step 1/2 error: Error running apply:
        Error: error creating EC2 Managed Prefix List: InvalidAction: The action CreateManagedPrefixList is not valid for this web service.
        	status code: 400, request id: 8fd4a192-5d26-480a-b433-d100f298f22c


=== CONT  TestAccAwsEc2TransitGatewayPrefixListReference_disappears_TransitGateway
    resource_aws_ec2_transit_gateway_prefix_list_reference_test.go:72: Step 1/1 error: Error running apply:
        Error: error creating EC2 Managed Prefix List: InvalidAction: The action CreateManagedPrefixList is not valid for this web service.
        	status code: 400, request id: 487b9b04-0018-480a-ad62-a79701b4a00d


=== CONT  TestAccAwsEc2TransitGatewayPrefixListReference_TransitGatewayAttachmentId
    resource_aws_ec2_transit_gateway_prefix_list_reference_test.go:94: Step 1/2 error: Error running apply:
        Error: error creating EC2 Managed Prefix List: InvalidAction: The action CreateManagedPrefixList is not valid for this web service.
        	status code: 400, request id: b2d0afb9-033e-425d-a5a3-17e595f16a29


--- FAIL: TestAccAwsEc2TransitGatewayPrefixListReference_disappears (208.76s)
--- FAIL: TestAccAwsEc2TransitGatewayPrefixListReference_basic (208.88s)
--- FAIL: TestAccAwsEc2TransitGatewayPrefixListReference_disappears_TransitGateway (209.22s)
--- FAIL: TestAccAwsEc2TransitGatewayPrefixListReference_TransitGatewayAttachmentId (308.30s)

@bflad bflad added new-resource Introduces a new resource. service/ec2 Issues and PRs that pertain to the ec2 service. labels Dec 17, 2020
@bflad bflad requested a review from a team as a code owner December 17, 2020 18:40
@ghost ghost added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Dec 17, 2020
Base automatically changed from master to main January 23, 2021 01:00
bflad added a commit that referenced this pull request Jan 27, 2021
@YakDriver YakDriver self-assigned this Feb 4, 2021
bflad and others added 4 commits February 4, 2021 10:51
Reference: #16572

Output from acceptance testing in AWS Commercial:

```
--- PASS: TestAccAwsEc2TransitGatewayPrefixListReference_disappears (214.31s)
--- PASS: TestAccAwsEc2TransitGatewayPrefixListReference_basic (217.12s)
--- PASS: TestAccAwsEc2TransitGatewayPrefixListReference_disappears_TransitGateway (219.77s)
--- PASS: TestAccAwsEc2TransitGatewayPrefixListReference_TransitGatewayAttachmentId (397.05s)
```
…iable to fix terrafmt issue

Output from acceptance testing:

```
--- PASS: TestAccAwsEc2TransitGatewayPrefixListReference_TransitGatewayAttachmentId (403.66s)
```
@YakDriver YakDriver force-pushed the f-aws_ec2_transit_gateway_prefix_list_reference branch from 7da149a to cbb9388 Compare February 4, 2021 16:05
Copy link
Member

@YakDriver YakDriver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🎉

I rebased and added the testAccPreCheckEc2ManagedPrefixList() prechecks.

GovCloud:

--- SKIP: TestAccAwsEc2TransitGatewayPrefixListReference_disappears_TransitGateway (1.92s)
--- SKIP: TestAccAwsEc2TransitGatewayPrefixListReference_disappears (1.92s)
--- SKIP: TestAccAwsEc2TransitGatewayPrefixListReference_TransitGatewayAttachmentId (1.93s)
--- SKIP: TestAccAwsEc2TransitGatewayPrefixListReference_basic (2.14s)

us-west-2:

--- PASS: TestAccAwsEc2TransitGatewayPrefixListReference_disappears (190.45s)
--- PASS: TestAccAwsEc2TransitGatewayPrefixListReference_basic (193.57s)
--- PASS: TestAccAwsEc2TransitGatewayPrefixListReference_disappears_TransitGateway (210.45s)
--- PASS: TestAccAwsEc2TransitGatewayPrefixListReference_TransitGatewayAttachmentId (420.62s)

@bflad bflad merged commit 6877834 into main Feb 4, 2021
@bflad bflad deleted the f-aws_ec2_transit_gateway_prefix_list_reference branch February 4, 2021 16:42
@github-actions github-actions bot added this to the v3.27.0 milestone Feb 4, 2021
github-actions bot pushed a commit that referenced this pull request Feb 4, 2021
@ghost
Copy link

ghost commented Feb 5, 2021

This has been released in version 3.27.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Mar 6, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Mar 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. new-resource Introduces a new resource. provider Pertains to the provider itself, rather than any interaction with AWS. service/ec2 Issues and PRs that pertain to the ec2 service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Managing EC2 Transit Gateway Prefix List References
2 participants