#507: aws_db_instance: Add support for in-place identifier update

[dee-kryvenko]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #507

Release note for CHANGELOG:

BUG FIXES:

- resource /aws_db_instance: **BACKWARD INCOMPATIBLE** now uses `resource_id` as `id` instead of `identifier` - this change allows for in-place updates for `identifier` (previously it would want to re-create the resource as reported in #507).

Output from acceptance testing:

$ make testacc ACCTEST_PARALLELISM=5 TESTARGS='-run=TestAccAWSDBInstance_identifierUpdate'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 5 -run=TestAccAWSDBInstance_identifierUpdate -timeout 120m
=== RUN   TestAccAWSDBInstance_identifierUpdate
=== PAUSE TestAccAWSDBInstance_identifierUpdate
=== CONT  TestAccAWSDBInstance_identifierUpdate
--- PASS: TestAccAWSDBInstance_identifierUpdate (620.57s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       623.500s

I did run all the TestAccAWSDBInstance tests but I don't have a single output for all of them at once. I had to fix a lot of tests and I were re-running them one-by-one. The single test that is failing is TestAccAWSDBInstance_S3Import (due to #13391) and also TestAccAWSDBInstance_ec2Classic is skipped since I do not have access to an Classic EC2 enabled account.

[github-actions]

Welcome @dee-kryvenko 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

[dee-kryvenko]

I'm not sure why goreleaser has failed - I do not see a smoking gun in the logs

[dee-kryvenko]

Any chance I could celebrate my first contribution to aws provider on Christmas?

That is 2020 Christmas, not 2021 or any further. Just saying...

cc @anGie44 (you were to merge the last PR to this resource)

[Kaisbn]

Hi!
goreleaser seems to have timed-out. Maybe the test needs to be re-run?

Any chance this can be merged soon?

[bedge]

This has been stalled here for a year with no constructive comments from upstream.
I'm starting to think terraform just makes thing harder.
Seriously, no "rename"?
@teamterraform is there some other plan in the works for RDS rename?

[zhelding]

Pull request #21306 has significantly refactored the AWS Provider codebase. As a result, most PRs opened prior to the refactor now have merge conflicts that must be resolved before proceeding.

Specifically, PR #21306 relocated the code for all AWS resources and data sources from a single aws directory to a large number of separate directories in internal/service, each corresponding to a particular AWS service. This separation of code has also allowed for us to simplify the names of underlying functions -- while still avoiding namespace collisions.

We recognize that many pull requests have been open for some time without yet being addressed by our maintainers. Therefore, we want to make it clear that resolving these conflicts in no way affects the prioritization of a particular pull request. Once a pull request has been prioritized for review, the necessary changes will be made by a maintainer -- either directly or in collaboration with the pull request author.

For a more complete description of this refactor, including examples of how old filepaths and function names correspond to their new counterparts: please refer to issue #20000.

For a quick guide on how to amend your pull request to resolve the merge conflicts resulting from this refactor and bring it in line with our new code patterns: please refer to our Service Package Refactor Pull Request Guide.

[dee-kryvenko]

@zhelding #21306 seems to be some recent development. My PR was opened almost a year ago. I did a few attempts to keep it up to date. I'm not going to waste my time. No one seems to be interested in this change, I'm not even sure your message is not automatic notification.

[github-actions]

This functionality has been released in v5.0.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.