-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests/resource/workspaces_directory: Fix hardcoded region #16602
Conversation
e2452a9
to
54ca703
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this case, I think lint ignoring is fine and we should prefer to keep the region name in the configuration for clarity, since it looks like the local
is written to be expanded in the future. 👍 (I have not done any research to see if there is a better solution to the "acceptable AZs for WorkSpaces" problem.)
54ca703
to
cff7df0
Compare
@bflad I try to avoid lint ignoring big blocks of config since offending stuff can be inserted anywhere in the config. But, not sure what else to do here. It's "fixed." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, (although the test on this branch is failing for unrelated reasons fixed on the main branch).
Output from acceptance testing in AWS Commercial:
=== CONT TestAccAwsWorkspacesDirectory_basic
resource_aws_workspaces_directory_test.go:63: Step 1/2 error: Check failed: 1 error occurred:
* Check 16/24 error: aws_workspaces_directory.main: Attribute 'tags.%' expected "0", got "1"
Output from acceptance testing in AWS GovCloud (US):
--- SKIP: TestAccAwsWorkspacesDirectory_basic (2.26s)
This has been released in version 3.24.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks! |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
Community Note
Relates #12995 Phase 2
Release note for CHANGELOG:
Acceptance Tests in GovCloud
Acceptance Tests in
us-west-2
Acceptance Tests in
us-east-1