Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests/resource/workspaces_directory: Fix hardcoded region #16602

Merged
merged 3 commits into from
Jan 11, 2021

Conversation

YakDriver
Copy link
Member

@YakDriver YakDriver commented Dec 4, 2020

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #12995 Phase 2

Release note for CHANGELOG:

NONE

Acceptance Tests in GovCloud

--- SKIP: TestAccAwsWorkspacesDirectory_basic (2.36s)

Acceptance Tests in us-west-2

--- PASS: TestAccAwsWorkspacesDirectory_basic (615.53s)

Acceptance Tests in us-east-1

--- PASS: TestAccAwsWorkspacesDirectory_basic (911.57s)

@YakDriver YakDriver requested a review from a team as a code owner December 4, 2020 20:20
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. service/workspaces Issues and PRs that pertain to the workspaces service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Dec 4, 2020
@YakDriver YakDriver added the partition/aws-us-gov Pertains to the aws-us-gov partition. label Dec 4, 2020
@YakDriver YakDriver force-pushed the t-gov-hardreg-workspaces branch from e2452a9 to 54ca703 Compare December 7, 2020 15:23
bflad
bflad previously requested changes Jan 6, 2021
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this case, I think lint ignoring is fine and we should prefer to keep the region name in the configuration for clarity, since it looks like the local is written to be expanded in the future. 👍 (I have not done any research to see if there is a better solution to the "acceptable AZs for WorkSpaces" problem.)

@bflad bflad self-assigned this Jan 6, 2021
@YakDriver YakDriver force-pushed the t-gov-hardreg-workspaces branch from 54ca703 to cff7df0 Compare January 8, 2021 21:59
@YakDriver
Copy link
Member Author

@bflad I try to avoid lint ignoring big blocks of config since offending stuff can be inserted anywhere in the config. But, not sure what else to do here. It's "fixed."

Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, (although the test on this branch is failing for unrelated reasons fixed on the main branch).

Output from acceptance testing in AWS Commercial:

=== CONT  TestAccAwsWorkspacesDirectory_basic
    resource_aws_workspaces_directory_test.go:63: Step 1/2 error: Check failed: 1 error occurred:
        	* Check 16/24 error: aws_workspaces_directory.main: Attribute 'tags.%' expected "0", got "1"

Output from acceptance testing in AWS GovCloud (US):

--- SKIP: TestAccAwsWorkspacesDirectory_basic (2.26s)

@YakDriver YakDriver added this to the v3.24.0 milestone Jan 11, 2021
@YakDriver YakDriver merged commit 295ea76 into master Jan 11, 2021
@YakDriver YakDriver deleted the t-gov-hardreg-workspaces branch January 11, 2021 22:26
@ghost
Copy link

ghost commented Jan 15, 2021

This has been released in version 3.24.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Feb 11, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Feb 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
partition/aws-us-gov Pertains to the aws-us-gov partition. service/workspaces Issues and PRs that pertain to the workspaces service. size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants