Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests/vpc: Fix hardcoded regions, clean up EC2 public/private suffixes #16582

Merged
merged 9 commits into from
Jan 20, 2021
Merged

tests/vpc: Fix hardcoded regions, clean up EC2 public/private suffixes #16582

merged 9 commits into from
Jan 20, 2021

Conversation

YakDriver
Copy link
Member

@YakDriver YakDriver commented Dec 4, 2020 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #12995 Phase 2

Next level: GovCloud & us-west-2 & us-east-1

Release note for CHANGELOG:

NONE

Tests:

TestAccAWSDefaultVpcDhcpOptions_|TestAccAWSDHCPOptions_|TestAccAWSDHCPOptionsAssociation_|TestAccAWSEIP_|TestAccAWSEIPAssociation_|TestAccAWSENI_|TestAccDataSourceAWSEIP_

GovCloud

--- PASS: TestAccAWSDefaultVpcDhcpOptions_basic (20.86s)
--- PASS: TestAccAWSDHCPOptions_basic (26.84s)
--- PASS: TestAccAWSDHCPOptions_deleteOptions (19.57s)
--- PASS: TestAccAWSDHCPOptions_disappears (42.21s)
--- PASS: TestAccAWSDHCPOptions_tags (54.19s)
--- PASS: TestAccAWSDHCPOptionsAssociation_basic (48.96s)
--- PASS: TestAccAWSDHCPOptionsAssociation_disappears_dhcp (64.31s)
--- PASS: TestAccAWSDHCPOptionsAssociation_disappears_vpc (50.97s)
--- PASS: TestAccAWSEIP_associated_user_private_ip (249.39s)
--- PASS: TestAccAWSEIP_basic (23.44s)
--- PASS: TestAccAWSEIP_disappears (15.88s)
--- PASS: TestAccAWSEIP_instance (106.13s)
--- PASS: TestAccAWSEIP_Instance_Reassociate (133.61s)
--- PASS: TestAccAWSEIP_NetworkBorderGroup (22.50s)
--- PASS: TestAccAWSEIP_networkInterface (107.73s)
--- PASS: TestAccAWSEIP_notAssociated (126.50s)
--- PASS: TestAccAWSEIP_PublicIpv4Pool_default (23.43s)
--- PASS: TestAccAWSEIP_tags_Vpc (33.81s)
--- PASS: TestAccAWSEIP_twoEIPsOneNetworkInterface (83.99s)
--- PASS: TestAccAWSEIPAssociation_basic (227.77s)
--- PASS: TestAccAWSEIPAssociation_disappears (135.52s)
--- PASS: TestAccAWSEIPAssociation_instance (100.76s)
--- PASS: TestAccAWSEIPAssociation_networkInterface (74.36s)
--- PASS: TestAccAWSEIPAssociation_spotInstance (120.16s)
--- PASS: TestAccAWSENI_attached (214.61s)
--- PASS: TestAccAWSENI_basic (95.42s)
--- PASS: TestAccAWSENI_computedIPs (87.01s)
--- PASS: TestAccAWSENI_disappears (66.31s)
--- PASS: TestAccAWSENI_ignoreExternalAttachment (149.95s)
--- PASS: TestAccAWSENI_ipv6 (161.58s)
--- PASS: TestAccAWSENI_ipv6_count (185.21s)
--- PASS: TestAccAWSENI_PrivateIpsCount (157.46s)
--- PASS: TestAccAWSENI_sourceDestCheck (162.54s)
--- PASS: TestAccAWSENI_tags (128.62s)
--- PASS: TestAccAWSENI_updatedDescription (111.58s)
--- PASS: TestAccDataSourceAwsEip_Filter (35.84s)
--- PASS: TestAccDataSourceAwsEip_Id (18.10s)
--- PASS: TestAccDataSourceAwsEip_Instance (142.23s)
--- PASS: TestAccDataSourceAwsEip_NetworkInterface (73.41s)
--- PASS: TestAccDataSourceAwsEip_PublicIP_VPC (17.17s)
--- PASS: TestAccDataSourceAwsEip_Tags (21.98s)
--- SKIP: TestAccAWSEIP_CustomerOwnedIpv4Pool (2.77s)
--- SKIP: TestAccAWSEIP_Ec2Classic (2.70s)
--- SKIP: TestAccAWSEIP_PublicIpv4Pool_custom (0.00s)
--- SKIP: TestAccAWSEIP_tags_Ec2Classic (2.70s)
--- SKIP: TestAccAWSEIPAssociation_ec2Classic (0.00s)
--- SKIP: TestAccDataSourceAWSEIP_CustomerOwnedIpv4Pool (1.11s)
--- SKIP: TestAccDataSourceAwsEip_PublicIP_EC2Classic (0.00s)

us-west-2

--- PASS: TestAccAWSDefaultVpcDhcpOptions_basic (11.89s)
--- PASS: TestAccAWSDHCPOptions_basic (13.81s)
--- PASS: TestAccAWSDHCPOptions_deleteOptions (9.81s)
--- PASS: TestAccAWSDHCPOptions_disappears (9.86s)
--- PASS: TestAccAWSDHCPOptions_tags (32.46s)
--- PASS: TestAccAWSDHCPOptionsAssociation_basic (24.23s)
--- PASS: TestAccAWSDHCPOptionsAssociation_disappears_dhcp (23.61s)
--- PASS: TestAccAWSDHCPOptionsAssociation_disappears_vpc (18.78s)
--- PASS: TestAccAWSEIP_associated_user_private_ip (242.77s)
--- PASS: TestAccAWSEIP_basic (19.82s)
--- PASS: TestAccAWSEIP_disappears (14.46s)
--- PASS: TestAccAWSEIP_Ec2Classic (118.48s)
--- PASS: TestAccAWSEIP_instance (97.02s)
--- PASS: TestAccAWSEIP_Instance_Reassociate (134.04s)
--- PASS: TestAccAWSEIP_NetworkBorderGroup (15.69s)
--- PASS: TestAccAWSEIP_networkInterface (84.15s)
--- PASS: TestAccAWSEIP_notAssociated (133.95s)
--- PASS: TestAccAWSEIP_PublicIpv4Pool_default (15.62s)
--- PASS: TestAccAWSEIP_tags_Ec2Classic (4.84s)
--- PASS: TestAccAWSEIP_tags_Vpc (29.52s)
--- PASS: TestAccAWSEIP_twoEIPsOneNetworkInterface (83.55s)
--- PASS: TestAccAWSEIPAssociation_basic (157.28s)
--- PASS: TestAccAWSEIPAssociation_disappears (110.46s)
--- PASS: TestAccAWSEIPAssociation_ec2Classic (229.44s)
--- PASS: TestAccAWSEIPAssociation_instance (95.72s)
--- PASS: TestAccAWSEIPAssociation_networkInterface (69.70s)
--- PASS: TestAccAWSEIPAssociation_spotInstance (339.81s)
--- PASS: TestAccAWSENI_attached (129.09s)
--- PASS: TestAccAWSENI_basic (66.81s)
--- PASS: TestAccAWSENI_computedIPs (65.57s)
--- PASS: TestAccAWSENI_disappears (59.69s)
--- PASS: TestAccAWSENI_ignoreExternalAttachment (122.98s)
--- PASS: TestAccAWSENI_ipv6 (121.53s)
--- PASS: TestAccAWSENI_ipv6_count (145.22s)
--- PASS: TestAccAWSENI_PrivateIpsCount (118.18s)
--- PASS: TestAccAWSENI_sourceDestCheck (116.05s)
--- PASS: TestAccAWSENI_tags (117.32s)
--- PASS: TestAccAWSENI_updatedDescription (100.08s)
--- PASS: TestAccDataSourceAwsEip_Filter (19.38s)
--- PASS: TestAccDataSourceAwsEip_Id (13.60s)
--- PASS: TestAccDataSourceAwsEip_Instance (158.76s)
--- PASS: TestAccDataSourceAwsEip_NetworkInterface (72.54s)
--- PASS: TestAccDataSourceAwsEip_PublicIP_EC2Classic (8.68s)
--- PASS: TestAccDataSourceAwsEip_PublicIP_VPC (19.07s)
--- PASS: TestAccDataSourceAwsEip_Tags (19.26s)
--- SKIP: TestAccAWSEIP_CustomerOwnedIpv4Pool (1.48s)
--- SKIP: TestAccAWSEIP_PublicIpv4Pool_custom (0.00s)
--- SKIP: TestAccDataSourceAWSEIP_CustomerOwnedIpv4Pool (1.58s)

us-east-1


--- PASS: TestAccAWSDefaultVpcDhcpOptions_basic (12.51s)
--- PASS: TestAccAWSDHCPOptions_basic (10.60s)
--- PASS: TestAccAWSDHCPOptions_deleteOptions (9.80s)
--- PASS: TestAccAWSDHCPOptions_disappears (10.80s)
--- PASS: TestAccAWSDHCPOptions_tags (31.88s)
--- PASS: TestAccAWSDHCPOptionsAssociation_basic (21.74s)
--- PASS: TestAccAWSDHCPOptionsAssociation_disappears_dhcp (38.74s)
--- PASS: TestAccAWSDHCPOptionsAssociation_disappears_vpc (26.03s)
--- PASS: TestAccAWSEIP_associated_user_private_ip (432.82s)
--- PASS: TestAccAWSEIP_basic (9.47s)
--- PASS: TestAccAWSEIP_disappears (11.40s)
--- PASS: TestAccAWSEIP_Ec2Classic (99.80s)
--- PASS: TestAccAWSEIP_instance (83.65s)
--- PASS: TestAccAWSEIP_Instance_Reassociate (97.33s)
--- PASS: TestAccAWSEIP_NetworkBorderGroup (16.12s)
--- PASS: TestAccAWSEIP_networkInterface (63.60s)
--- PASS: TestAccAWSEIP_notAssociated (122.94s)
--- PASS: TestAccAWSEIP_PublicIpv4Pool_default (15.83s)
--- PASS: TestAccAWSEIP_tags_Ec2Classic (8.65s)
--- PASS: TestAccAWSEIP_tags_Vpc (13.43s)
--- PASS: TestAccAWSEIP_twoEIPsOneNetworkInterface (64.70s)
--- PASS: TestAccAWSEIPAssociation_disappears (103.91s)
--- PASS: TestAccAWSEIPAssociation_ec2Classic (98.84s)
--- PASS: TestAccAWSEIPAssociation_instance (318.94s)
--- PASS: TestAccAWSEIPAssociation_networkInterface (55.09s)
--- PASS: TestAccAWSEIPAssociation_spotInstance (319.11s)
--- PASS: TestAccAWSENI_attached (119.13s)
--- PASS: TestAccAWSENI_basic (52.12s)
--- PASS: TestAccAWSENI_computedIPs (55.00s)
--- PASS: TestAccAWSENI_disappears (48.85s)
--- PASS: TestAccAWSENI_ignoreExternalAttachment (85.51s)
--- PASS: TestAccAWSENI_ipv6 (95.56s)
--- PASS: TestAccAWSENI_ipv6_count (108.60s)
--- PASS: TestAccAWSENI_PrivateIpsCount (107.86s)
--- PASS: TestAccAWSENI_sourceDestCheck (96.71s)
--- PASS: TestAccAWSENI_tags (93.01s)
--- PASS: TestAccAWSENI_updatedDescription (92.09s)
--- PASS: TestAccDataSourceAwsEip_Filter (14.14s)
--- PASS: TestAccDataSourceAwsEip_Id (9.88s)
--- PASS: TestAccDataSourceAwsEip_Instance (147.14s)
--- PASS: TestAccDataSourceAwsEip_NetworkInterface (58.76s)
--- PASS: TestAccDataSourceAwsEip_PublicIP_EC2Classic (12.97s)
--- PASS: TestAccDataSourceAwsEip_PublicIP_VPC (18.53s)
--- PASS: TestAccDataSourceAwsEip_Tags (8.62s)
--- SKIP: TestAccAWSEIP_CustomerOwnedIpv4Pool (1.48s)
--- SKIP: TestAccAWSEIP_PublicIpv4Pool_custom (0.00s)
--- SKIP: TestAccAWSEIPAssociation_basic (0.46s)
--- SKIP: TestAccDataSourceAWSEIP_CustomerOwnedIpv4Pool (1.34s)

@YakDriver YakDriver requested a review from a team as a code owner December 4, 2020 00:08
@ghost ghost added size/M Managed by automation to categorize the size of a PR. service/ec2 Issues and PRs that pertain to the ec2 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Dec 4, 2020
@YakDriver YakDriver added the partition/aws-us-gov Pertains to the aws-us-gov partition. label Dec 4, 2020
@YakDriver YakDriver force-pushed the t-gov-hardregion-vpc branch 2 times, most recently from 476136b to 35979ce Compare December 4, 2020 03:37
@ghost ghost added size/L Managed by automation to categorize the size of a PR. and removed size/M Managed by automation to categorize the size of a PR. labels Dec 4, 2020
@YakDriver YakDriver force-pushed the t-gov-hardregion-vpc branch 2 times, most recently from b819c30 to 3a9f7d1 Compare December 4, 2020 04:07
@YakDriver YakDriver mentioned this pull request Dec 4, 2020
Closed
bflad
bflad reviewed Dec 4, 2020
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be good to adjust the configurations to be self-contained while we are adjusting them here. 👍

aws/resource_aws_eip_association_test.go Outdated Show resolved Hide resolved
aws/resource_aws_eip_association_test.go Outdated Show resolved Hide resolved
@YakDriver YakDriver mentioned this pull request Dec 4, 2020
Closed
@bflad
Copy link
Contributor

bflad commented Jan 6, 2021

PR needs rebase 👍

@bflad bflad self-assigned this Jan 6, 2021
@YakDriver YakDriver force-pushed the t-gov-hardregion-vpc branch from 3a9f7d1 to cef0e3d Compare January 8, 2021 20:53
@ghost ghost added size/XL Managed by automation to categorize the size of a PR. and removed size/L Managed by automation to categorize the size of a PR. labels Jan 8, 2021
@YakDriver
Copy link
Member Author

@bflad Tests after fixes:

us-west-2

--- PASS: TestAccAWSDefaultVpcDhcpOptions_basic (13.74s)
--- PASS: TestAccAWSDHCPOptions_basic (24.36s)
--- PASS: TestAccAWSDHCPOptions_deleteOptions (18.23s)
--- PASS: TestAccAWSDHCPOptions_disappears (17.84s)
--- PASS: TestAccAWSDHCPOptions_tags (42.35s)
--- PASS: TestAccAWSDHCPOptionsAssociation_basic (28.86s)
--- PASS: TestAccAWSDHCPOptionsAssociation_disappears_dhcp (24.21s)
--- PASS: TestAccAWSDHCPOptionsAssociation_disappears_vpc (20.86s)
--- PASS: TestAccAWSEIP_associated_user_private_ip (238.42s)
--- PASS: TestAccAWSEIP_basic (27.69s)
--- PASS: TestAccAWSEIP_CarrierIP (22.88s)
--- PASS: TestAccAWSEIP_disappears (13.65s)
--- PASS: TestAccAWSEIP_Ec2Classic (201.99s)
--- PASS: TestAccAWSEIP_instance (134.51s)
--- PASS: TestAccAWSEIP_Instance_Reassociate (142.50s)
--- PASS: TestAccAWSEIP_NetworkBorderGroup (28.70s)
--- PASS: TestAccAWSEIP_networkInterface (80.20s)
--- PASS: TestAccAWSEIP_notAssociated (169.99s)
--- PASS: TestAccAWSEIP_PublicIpv4Pool_default (24.63s)
--- PASS: TestAccAWSEIP_tags_Ec2Classic (7.47s)
--- PASS: TestAccAWSEIP_tags_Vpc (25.91s)
--- PASS: TestAccAWSEIP_twoEIPsOneNetworkInterface (77.68s)
--- PASS: TestAccAWSEIPAssociation_basic (201.48s)
--- PASS: TestAccAWSEIPAssociation_disappears (107.60s)
--- PASS: TestAccAWSEIPAssociation_ec2Classic (221.23s)
--- PASS: TestAccAWSEIPAssociation_instance (130.00s)
--- PASS: TestAccAWSEIPAssociation_networkInterface (71.80s)
--- PASS: TestAccAWSEIPAssociation_spotInstance (117.62s)
--- PASS: TestAccAWSENI_attached (157.19s)
--- PASS: TestAccAWSENI_basic (64.48s)
--- PASS: TestAccAWSENI_computedIPs (66.02s)
--- PASS: TestAccAWSENI_disappears (61.68s)
--- PASS: TestAccAWSENI_ignoreExternalAttachment (110.49s)
--- PASS: TestAccAWSENI_ipv6 (127.44s)
--- PASS: TestAccAWSENI_ipv6_count (156.12s)
--- PASS: TestAccAWSENI_PrivateIpsCount (137.29s)
--- PASS: TestAccAWSENI_sourceDestCheck (133.47s)
--- PASS: TestAccAWSENI_tags (122.45s)
--- PASS: TestAccAWSENI_updatedDescription (103.41s)
--- PASS: TestAccDataSourceAWSEIP_CarrierIP (20.24s)
--- PASS: TestAccDataSourceAWSEIP_Filter (17.02s)
--- PASS: TestAccDataSourceAWSEIP_Id (22.04s)
--- PASS: TestAccDataSourceAWSEIP_Instance (173.48s)
--- PASS: TestAccDataSourceAWSEIP_NetworkInterface (67.75s)
--- PASS: TestAccDataSourceAWSEIP_PublicIP_EC2Classic (10.96s)
--- PASS: TestAccDataSourceAWSEIP_PublicIP_VPC (18.94s)
--- PASS: TestAccDataSourceAWSEIP_Tags (12.79s)
--- SKIP: TestAccAWSEIP_CustomerOwnedIpv4Pool (0.95s)
--- SKIP: TestAccAWSEIP_PublicIpv4Pool_custom (0.00s)
--- SKIP: TestAccDataSourceAWSEIP_CustomerOwnedIpv4Pool (1.82s)

GovCloud

--- PASS: TestAccAWSDefaultVpcDhcpOptions_basic (18.07s)
--- PASS: TestAccAWSDHCPOptions_basic (26.70s)
--- PASS: TestAccAWSDHCPOptions_deleteOptions (21.93s)
--- PASS: TestAccAWSDHCPOptions_disappears (21.72s)
--- PASS: TestAccAWSDHCPOptions_tags (59.64s)
--- PASS: TestAccAWSDHCPOptionsAssociation_basic (30.53s)
--- PASS: TestAccAWSDHCPOptionsAssociation_disappears_dhcp (34.86s)
--- PASS: TestAccAWSDHCPOptionsAssociation_disappears_vpc (25.54s)
--- PASS: TestAccAWSEIP_associated_user_private_ip (217.23s)
--- PASS: TestAccAWSEIP_basic (30.43s)
--- PASS: TestAccAWSEIP_disappears (21.53s)
--- PASS: TestAccAWSEIP_instance (104.71s)
--- PASS: TestAccAWSEIP_Instance_Reassociate (137.89s)
--- PASS: TestAccAWSEIP_NetworkBorderGroup (18.34s)
--- PASS: TestAccAWSEIP_networkInterface (88.23s)
--- PASS: TestAccAWSEIP_notAssociated (138.67s)
--- PASS: TestAccAWSEIP_PublicIpv4Pool_default (18.41s)
--- PASS: TestAccAWSEIP_tags_Vpc (46.19s)
--- PASS: TestAccAWSEIP_twoEIPsOneNetworkInterface (88.15s)
--- PASS: TestAccAWSEIPAssociation_basic (183.02s)
--- PASS: TestAccAWSEIPAssociation_disappears (133.99s)
--- PASS: TestAccAWSEIPAssociation_instance (118.26s)
--- PASS: TestAccAWSEIPAssociation_networkInterface (74.00s)
--- PASS: TestAccAWSEIPAssociation_spotInstance (95.99s)
--- PASS: TestAccAWSENI_attached (136.39s)
--- PASS: TestAccAWSENI_basic (65.86s)
--- PASS: TestAccAWSENI_computedIPs (67.85s)
--- PASS: TestAccAWSENI_disappears (58.50s)
--- PASS: TestAccAWSENI_ignoreExternalAttachment (137.73s)
--- PASS: TestAccAWSENI_ipv6 (117.21s)
--- PASS: TestAccAWSENI_ipv6_count (137.99s)
--- PASS: TestAccAWSENI_PrivateIpsCount (125.61s)
--- PASS: TestAccAWSENI_sourceDestCheck (118.61s)
--- PASS: TestAccAWSENI_tags (113.75s)
--- PASS: TestAccAWSENI_updatedDescription (95.59s)
--- PASS: TestAccDataSourceAWSEIP_Filter (27.10s)
--- PASS: TestAccDataSourceAWSEIP_Id (14.88s)
--- PASS: TestAccDataSourceAWSEIP_Instance (134.99s)
--- PASS: TestAccDataSourceAWSEIP_NetworkInterface (71.04s)
--- PASS: TestAccDataSourceAWSEIP_PublicIP_VPC (18.25s)
--- PASS: TestAccDataSourceAWSEIP_Tags (22.38s)
--- SKIP: TestAccAWSEIP_CarrierIP (0.37s)
--- SKIP: TestAccAWSEIP_CustomerOwnedIpv4Pool (1.05s)
--- SKIP: TestAccAWSEIP_Ec2Classic (2.52s)
--- SKIP: TestAccAWSEIP_PublicIpv4Pool_custom (0.00s)
--- SKIP: TestAccAWSEIP_tags_Ec2Classic (0.00s)
--- SKIP: TestAccAWSEIPAssociation_ec2Classic (2.52s)
--- SKIP: TestAccDataSourceAWSEIP_CarrierIP (1.65s)
--- SKIP: TestAccDataSourceAWSEIP_CustomerOwnedIpv4Pool (1.29s)
--- SKIP: TestAccDataSourceAWSEIP_PublicIP_EC2Classic (0.00s)

@YakDriver YakDriver requested a review from bflad January 8, 2021 21:35
bflad
bflad approved these changes Jan 20, 2021
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 🚀

Output from acceptance testing:

--- PASS: TestAccAWSDefaultVpcDhcpOptions_basic (35.81s)

--- PASS: TestAccAWSDHCPOptions_basic (31.97s)
--- PASS: TestAccAWSDHCPOptions_deleteOptions (23.73s)
--- PASS: TestAccAWSDHCPOptions_disappears (24.62s)
--- PASS: TestAccAWSDHCPOptions_tags (56.80s)

--- PASS: TestAccAWSDHCPOptionsAssociation_basic (19.33s)
--- PASS: TestAccAWSDHCPOptionsAssociation_disappears_dhcp (22.95s)
--- PASS: TestAccAWSDHCPOptionsAssociation_disappears_vpc (16.56s)

--- FAIL: TestAccAWSEIP_Instance_Reassociate (319.41s) # unrelated; quota
--- FAIL: TestAccAWSEIP_NetworkBorderGroup (16.60s) # unrelated; quota
--- FAIL: TestAccAWSEIP_PublicIpv4Pool_default (41.14s) # unrelated; quota
--- PASS: TestAccAWSEIP_associated_user_private_ip (209.75s)
--- PASS: TestAccAWSEIP_basic (44.41s)
--- PASS: TestAccAWSEIP_CarrierIP (40.76s)
--- PASS: TestAccAWSEIP_disappears (23.98s)
--- PASS: TestAccAWSEIP_Ec2Classic (239.21s)
--- PASS: TestAccAWSEIP_instance (97.75s)
--- PASS: TestAccAWSEIP_networkInterface (97.34s)
--- PASS: TestAccAWSEIP_notAssociated (147.34s)
--- PASS: TestAccAWSEIP_tags_Ec2Classic (23.29s)
--- PASS: TestAccAWSEIP_tags_Vpc (57.91s)
--- PASS: TestAccAWSEIP_twoEIPsOneNetworkInterface (97.35s)
--- SKIP: TestAccAWSEIP_CustomerOwnedIpv4Pool (1.55s)
--- SKIP: TestAccAWSEIP_PublicIpv4Pool_custom (0.00s)

--- PASS: TestAccAWSEIPAssociation_basic (197.20s)
--- PASS: TestAccAWSEIPAssociation_disappears (117.31s)
--- PASS: TestAccAWSEIPAssociation_ec2Classic (254.86s)
--- PASS: TestAccAWSEIPAssociation_instance (115.70s)
--- PASS: TestAccAWSEIPAssociation_networkInterface (93.34s)
--- PASS: TestAccAWSEIPAssociation_spotInstance (110.76s)

--- PASS: TestAccAWSENI_attached (113.97s)
--- PASS: TestAccAWSENI_basic (64.18s)
--- PASS: TestAccAWSENI_computedIPs (69.64s)
--- PASS: TestAccAWSENI_disappears (59.41s)
--- PASS: TestAccAWSENI_ignoreExternalAttachment (140.02s)
--- PASS: TestAccAWSENI_ipv6 (117.78s)
--- PASS: TestAccAWSENI_ipv6_count (125.94s)
--- PASS: TestAccAWSENI_PrivateIpsCount (110.51s)
--- PASS: TestAccAWSENI_sourceDestCheck (108.07s)
--- PASS: TestAccAWSENI_tags (113.92s)
--- PASS: TestAccAWSENI_updatedDescription (94.69s)

--- PASS: TestAccDataSourceAWSEIP_CarrierIP (37.86s)
--- PASS: TestAccDataSourceAWSEIP_Filter (36.61s)
--- PASS: TestAccDataSourceAWSEIP_Id (37.93s)
--- PASS: TestAccDataSourceAWSEIP_Instance (173.05s)
--- PASS: TestAccDataSourceAWSEIP_NetworkInterface (88.01s)
--- PASS: TestAccDataSourceAWSEIP_PublicIP_EC2Classic (43.54s)
--- PASS: TestAccDataSourceAWSEIP_PublicIP_VPC (36.95s)
--- PASS: TestAccDataSourceAWSEIP_Tags (37.69s)
--- SKIP: TestAccDataSourceAWSEIP_CustomerOwnedIpv4Pool (1.73s)

@YakDriver YakDriver merged commit 45c62cd into master Jan 20, 2021
@YakDriver YakDriver deleted the t-gov-hardregion-vpc branch January 20, 2021 19:51
@YakDriver YakDriver added this to the v3.25.0 milestone Jan 20, 2021
@ghost
Copy link

ghost commented Jan 22, 2021

This has been released in version 3.25.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Feb 20, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Feb 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees

@bflad bflad

Labels
partition/aws-us-gov Pertains to the aws-us-gov partition. service/ec2 Issues and PRs that pertain to the ec2 service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.25.0
Development

Successfully merging this pull request may close these issues.
2 participants
@YakDriver @bflad