Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

d/aws_codeartifact_repository_endpoint: Support for NuGet #16422

Merged
merged 1 commit into from
Nov 25, 2020
Merged

d/aws_codeartifact_repository_endpoint: Support for NuGet #16422

merged 1 commit into from
Nov 25, 2020

Conversation

ewbankkit
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #16405.

Release note for CHANGELOG:

data-source/aws_codeartifact_repository_endpoint: Add `nuget` as a supported format

Output from acceptance testing:

$  make testacc TEST=./aws TESTARGS='-run=TestAccAWSCodeArtifactRepositoryEndpointDataSource_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSCodeArtifactRepositoryEndpointDataSource_ -timeout 120m
=== RUN   TestAccAWSCodeArtifactRepositoryEndpointDataSource_basic
--- PASS: TestAccAWSCodeArtifactRepositoryEndpointDataSource_basic (60.97s)
=== RUN   TestAccAWSCodeArtifactRepositoryEndpointDataSource_owner
--- PASS: TestAccAWSCodeArtifactRepositoryEndpointDataSource_owner (18.77s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	79.800s

@ewbankkit ewbankkit requested a review from a team as a code owner November 24, 2020 22:04
@ghost ghost added size/S Managed by automation to categorize the size of a PR. service/codeartifact Issues and PRs that pertain to the codeartifact service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Nov 24, 2020
DrFaust92
DrFaust92 approved these changes Nov 25, 2020
View reviewed changes
Copy link
Collaborator

@DrFaust92 DrFaust92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

--- PASS: TestAccAWSCodeArtifactRepositoryEndpointDataSource_basic (195.14s)
--- PASS: TestAccAWSCodeArtifactRepositoryEndpointDataSource_owner (58.40s)

@bflad bflad self-assigned this Nov 25, 2020
@bflad bflad added this to the v3.18.0 milestone Nov 25, 2020
@bflad bflad added the documentation Introduces or discusses updates to documentation. label Nov 25, 2020
bflad
bflad approved these changes Nov 25, 2020
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 🚀 Unrelatedly, this acceptance testing should be using resource.ParallelTest instead of resource.Test 😄

--- PASS: TestAccAWSCodeArtifactRepositoryEndpointDataSource_basic (59.57s)
--- PASS: TestAccAWSCodeArtifactRepositoryEndpointDataSource_owner (16.86s)

@bflad bflad merged commit 5bc18ce into hashicorp:master Nov 25, 2020
bflad added a commit that referenced this pull request Nov 25, 2020
@bflad
Update CHANGELOG for #16422
831869f
@ewbankkit ewbankkit deleted the f-aws_codeartifact_repository_endpoint-nuget branch November 25, 2020 21:11
@ghost
Copy link

ghost commented Nov 25, 2020

This has been released in version 3.18.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Dec 26, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Dec 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

@DrFaust92 DrFaust92 DrFaust92 approved these changes

Assignees

@bflad bflad

Labels
documentation Introduces or discusses updates to documentation. service/codeartifact Issues and PRs that pertain to the codeartifact service. size/S Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.18.0
Development

Successfully merging this pull request may close these issues.

AWS CodeArtifact now supports NuGet
3 participants
@ewbankkit @bflad @DrFaust92