Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_cloudwatch_event_target - add support for dead letter queue #16366

Closed
wants to merge 8 commits into from
Closed

r/aws_cloudwatch_event_target - add support for dead letter queue #16366

wants to merge 8 commits into from

Conversation

b-b3rn4rd
Copy link

@b-b3rn4rd b-b3rn4rd commented Nov 22, 2020

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #15836

Release note for CHANGELOG:

resource_aws_cloudwatch_event_target - add support for `dead_letter_config` and `retry_policy` parameters 

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSCloudWatchEventTarget_full'
--- PASS: TestAccAWSCloudWatchEventTarget_full (116.03s)

$ make testacc TESTARGS='-run=TestAccAWSCloudWatchEventTarget_basic'
--- PASS: TestAccAWSCloudWatchEventTarget_basic (127.58s)

@b-b3rn4rd b-b3rn4rd requested a review from a team as a code owner November 22, 2020 11:10
@ghost ghost added size/M Managed by automation to categorize the size of a PR. service/cloudwatchevents tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Nov 22, 2020
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Nov 22, 2020
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @b-b3rn4rd 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@b-b3rn4rd
Copy link
Author

b-b3rn4rd commented Nov 30, 2020

Hi Team,
Any chances of this getting reviewed, sometime soonish ? we would like to start using dead letter queue for the eventbridge in our project

Base automatically changed from master to main January 23, 2021 00:59
@sthulb
Copy link
Contributor

sthulb commented Mar 15, 2021

This should be closed, it was added by me in a later PR (#17241).

@sthulb sthulb closed this Apr 8, 2021
@ghost
Copy link

ghost commented May 8, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators May 8, 2021
@breathingdust breathingdust removed the needs-triage Waiting for first response or review from a maintainer. label Sep 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

resource/aws_cloudwatch_event_target: Add support for dead letter queue
3 participants