Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/storagegateway_nfs_file_share - add support for notification_policy + validations #16340

Merged
merged 6 commits into from
Nov 23, 2020
Merged

r/storagegateway_nfs_file_share - add support for notification_policy + validations #16340

merged 6 commits into from
Nov 23, 2020

Conversation

DrFaust92
Copy link
Collaborator

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Release note for CHANGELOG:

resource_aws_storagegateway_nfs_file_share - add support for `notification_policy`.
resource_aws_storagegateway_nfs_file_share - add plan time validation for `client_list`, `nfs_file_share_defaults. directory_mode`, `nfs_file_share_defaults. file_mode`, `nfs_file_share_defaults. group_id`, `nfs_file_share_defaults. owner_id`

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'
--- PASS: TestAccAWSStorageGatewayNfsFileShare_notificationPolicy (536.01s)
--- PASS: TestAccAWSStorageGatewayNfsFileShare_ClientList (530.15s)
--- PASS: TestAccAWSStorageGatewayNfsFileShare_basic (331.81s)

@DrFaust92 DrFaust92 requested a review from a team as a code owner November 20, 2020 10:43
@ghost ghost added size/L Managed by automation to categorize the size of a PR. service/storagegateway Issues and PRs that pertain to the storagegateway service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Nov 20, 2020
@DrFaust92 DrFaust92 added the enhancement Requests to existing resources that expand the functionality or scope. label Nov 20, 2020
ewbankkit
ewbankkit reviewed Nov 20, 2020
View reviewed changes
aws/internal/service/storagegateway/waiter/waiter.go
Comment on lines +37 to +38
Pending: []string{"BOOTSTRAPPING", "CREATING", "RESTORING", "UPDATING"},
Target: []string{"AVAILABLE"},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Define these as constants?

@ewbankkit
Copy link
Contributor

Verified acceptance tests:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSStorageGatewayNfsFileShare_' ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 2 -run=TestAccAWSStorageGatewayNfsFileShare_ -timeout 120m
=== RUN   TestAccAWSStorageGatewayNfsFileShare_basic
=== PAUSE TestAccAWSStorageGatewayNfsFileShare_basic
=== RUN   TestAccAWSStorageGatewayNfsFileShare_tags
=== PAUSE TestAccAWSStorageGatewayNfsFileShare_tags
=== RUN   TestAccAWSStorageGatewayNfsFileShare_fileShareName
=== PAUSE TestAccAWSStorageGatewayNfsFileShare_fileShareName
=== RUN   TestAccAWSStorageGatewayNfsFileShare_ClientList
=== PAUSE TestAccAWSStorageGatewayNfsFileShare_ClientList
=== RUN   TestAccAWSStorageGatewayNfsFileShare_DefaultStorageClass
=== PAUSE TestAccAWSStorageGatewayNfsFileShare_DefaultStorageClass
=== RUN   TestAccAWSStorageGatewayNfsFileShare_GuessMIMETypeEnabled
=== PAUSE TestAccAWSStorageGatewayNfsFileShare_GuessMIMETypeEnabled
=== RUN   TestAccAWSStorageGatewayNfsFileShare_KMSEncrypted
=== PAUSE TestAccAWSStorageGatewayNfsFileShare_KMSEncrypted
=== RUN   TestAccAWSStorageGatewayNfsFileShare_KMSKeyArn
=== PAUSE TestAccAWSStorageGatewayNfsFileShare_KMSKeyArn
=== RUN   TestAccAWSStorageGatewayNfsFileShare_NFSFileShareDefaults
=== PAUSE TestAccAWSStorageGatewayNfsFileShare_NFSFileShareDefaults
=== RUN   TestAccAWSStorageGatewayNfsFileShare_ObjectACL
=== PAUSE TestAccAWSStorageGatewayNfsFileShare_ObjectACL
=== RUN   TestAccAWSStorageGatewayNfsFileShare_ReadOnly
=== PAUSE TestAccAWSStorageGatewayNfsFileShare_ReadOnly
=== RUN   TestAccAWSStorageGatewayNfsFileShare_RequesterPays
=== PAUSE TestAccAWSStorageGatewayNfsFileShare_RequesterPays
=== RUN   TestAccAWSStorageGatewayNfsFileShare_Squash
=== PAUSE TestAccAWSStorageGatewayNfsFileShare_Squash
=== RUN   TestAccAWSStorageGatewayNfsFileShare_notificationPolicy
=== PAUSE TestAccAWSStorageGatewayNfsFileShare_notificationPolicy
=== RUN   TestAccAWSStorageGatewayNfsFileShare_cacheAttributes
=== PAUSE TestAccAWSStorageGatewayNfsFileShare_cacheAttributes
=== RUN   TestAccAWSStorageGatewayNfsFileShare_disappears
=== PAUSE TestAccAWSStorageGatewayNfsFileShare_disappears
=== CONT  TestAccAWSStorageGatewayNfsFileShare_basic
=== CONT  TestAccAWSStorageGatewayNfsFileShare_disappears
--- PASS: TestAccAWSStorageGatewayNfsFileShare_disappears (233.49s)
=== CONT  TestAccAWSStorageGatewayNfsFileShare_cacheAttributes
--- PASS: TestAccAWSStorageGatewayNfsFileShare_basic (238.55s)
=== CONT  TestAccAWSStorageGatewayNfsFileShare_notificationPolicy
--- PASS: TestAccAWSStorageGatewayNfsFileShare_cacheAttributes (335.94s)
=== CONT  TestAccAWSStorageGatewayNfsFileShare_Squash
--- PASS: TestAccAWSStorageGatewayNfsFileShare_notificationPolicy (341.44s)
=== CONT  TestAccAWSStorageGatewayNfsFileShare_RequesterPays
--- PASS: TestAccAWSStorageGatewayNfsFileShare_RequesterPays (291.63s)
=== CONT  TestAccAWSStorageGatewayNfsFileShare_ReadOnly
--- PASS: TestAccAWSStorageGatewayNfsFileShare_Squash (306.69s)
=== CONT  TestAccAWSStorageGatewayNfsFileShare_ObjectACL
--- PASS: TestAccAWSStorageGatewayNfsFileShare_ObjectACL (281.98s)
=== CONT  TestAccAWSStorageGatewayNfsFileShare_NFSFileShareDefaults
--- PASS: TestAccAWSStorageGatewayNfsFileShare_ReadOnly (286.71s)
=== CONT  TestAccAWSStorageGatewayNfsFileShare_KMSKeyArn
--- PASS: TestAccAWSStorageGatewayNfsFileShare_NFSFileShareDefaults (286.21s)
=== CONT  TestAccAWSStorageGatewayNfsFileShare_KMSEncrypted
--- PASS: TestAccAWSStorageGatewayNfsFileShare_KMSKeyArn (348.52s)
=== CONT  TestAccAWSStorageGatewayNfsFileShare_GuessMIMETypeEnabled
--- PASS: TestAccAWSStorageGatewayNfsFileShare_KMSEncrypted (229.35s)
=== CONT  TestAccAWSStorageGatewayNfsFileShare_DefaultStorageClass
--- PASS: TestAccAWSStorageGatewayNfsFileShare_GuessMIMETypeEnabled (276.49s)
=== CONT  TestAccAWSStorageGatewayNfsFileShare_ClientList
--- PASS: TestAccAWSStorageGatewayNfsFileShare_DefaultStorageClass (266.54s)
=== CONT  TestAccAWSStorageGatewayNfsFileShare_fileShareName
--- PASS: TestAccAWSStorageGatewayNfsFileShare_ClientList (364.37s)
=== CONT  TestAccAWSStorageGatewayNfsFileShare_tags
--- PASS: TestAccAWSStorageGatewayNfsFileShare_fileShareName (295.96s)
--- PASS: TestAccAWSStorageGatewayNfsFileShare_tags (312.26s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	2460.046s

@ghost ghost added size/XL Managed by automation to categorize the size of a PR. and removed size/L Managed by automation to categorize the size of a PR. labels Nov 22, 2020
ewbankkit
ewbankkit approved these changes Nov 23, 2020
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSStorageGatewayNfsFileShare_' ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 2 -run=TestAccAWSStorageGatewayNfsFileShare_ -timeout 120m
=== RUN   TestAccAWSStorageGatewayNfsFileShare_basic
=== PAUSE TestAccAWSStorageGatewayNfsFileShare_basic
=== RUN   TestAccAWSStorageGatewayNfsFileShare_tags
=== PAUSE TestAccAWSStorageGatewayNfsFileShare_tags
=== RUN   TestAccAWSStorageGatewayNfsFileShare_fileShareName
=== PAUSE TestAccAWSStorageGatewayNfsFileShare_fileShareName
=== RUN   TestAccAWSStorageGatewayNfsFileShare_ClientList
=== PAUSE TestAccAWSStorageGatewayNfsFileShare_ClientList
=== RUN   TestAccAWSStorageGatewayNfsFileShare_DefaultStorageClass
=== PAUSE TestAccAWSStorageGatewayNfsFileShare_DefaultStorageClass
=== RUN   TestAccAWSStorageGatewayNfsFileShare_GuessMIMETypeEnabled
=== PAUSE TestAccAWSStorageGatewayNfsFileShare_GuessMIMETypeEnabled
=== RUN   TestAccAWSStorageGatewayNfsFileShare_KMSEncrypted
=== PAUSE TestAccAWSStorageGatewayNfsFileShare_KMSEncrypted
=== RUN   TestAccAWSStorageGatewayNfsFileShare_KMSKeyArn
=== PAUSE TestAccAWSStorageGatewayNfsFileShare_KMSKeyArn
=== RUN   TestAccAWSStorageGatewayNfsFileShare_NFSFileShareDefaults
=== PAUSE TestAccAWSStorageGatewayNfsFileShare_NFSFileShareDefaults
=== RUN   TestAccAWSStorageGatewayNfsFileShare_ObjectACL
=== PAUSE TestAccAWSStorageGatewayNfsFileShare_ObjectACL
=== RUN   TestAccAWSStorageGatewayNfsFileShare_ReadOnly
=== PAUSE TestAccAWSStorageGatewayNfsFileShare_ReadOnly
=== RUN   TestAccAWSStorageGatewayNfsFileShare_RequesterPays
=== PAUSE TestAccAWSStorageGatewayNfsFileShare_RequesterPays
=== RUN   TestAccAWSStorageGatewayNfsFileShare_Squash
=== PAUSE TestAccAWSStorageGatewayNfsFileShare_Squash
=== RUN   TestAccAWSStorageGatewayNfsFileShare_notificationPolicy
=== PAUSE TestAccAWSStorageGatewayNfsFileShare_notificationPolicy
=== RUN   TestAccAWSStorageGatewayNfsFileShare_cacheAttributes
=== PAUSE TestAccAWSStorageGatewayNfsFileShare_cacheAttributes
=== RUN   TestAccAWSStorageGatewayNfsFileShare_disappears
=== PAUSE TestAccAWSStorageGatewayNfsFileShare_disappears
=== CONT  TestAccAWSStorageGatewayNfsFileShare_basic
=== CONT  TestAccAWSStorageGatewayNfsFileShare_ObjectACL
--- PASS: TestAccAWSStorageGatewayNfsFileShare_basic (217.28s)
=== CONT  TestAccAWSStorageGatewayNfsFileShare_disappears
--- PASS: TestAccAWSStorageGatewayNfsFileShare_ObjectACL (288.34s)
=== CONT  TestAccAWSStorageGatewayNfsFileShare_cacheAttributes
--- PASS: TestAccAWSStorageGatewayNfsFileShare_disappears (236.07s)
=== CONT  TestAccAWSStorageGatewayNfsFileShare_notificationPolicy
--- PASS: TestAccAWSStorageGatewayNfsFileShare_cacheAttributes (406.30s)
=== CONT  TestAccAWSStorageGatewayNfsFileShare_Squash
--- PASS: TestAccAWSStorageGatewayNfsFileShare_notificationPolicy (339.72s)
=== CONT  TestAccAWSStorageGatewayNfsFileShare_RequesterPays
--- PASS: TestAccAWSStorageGatewayNfsFileShare_Squash (284.16s)
=== CONT  TestAccAWSStorageGatewayNfsFileShare_ReadOnly
--- PASS: TestAccAWSStorageGatewayNfsFileShare_RequesterPays (258.34s)
=== CONT  TestAccAWSStorageGatewayNfsFileShare_GuessMIMETypeEnabled
--- PASS: TestAccAWSStorageGatewayNfsFileShare_ReadOnly (285.87s)
=== CONT  TestAccAWSStorageGatewayNfsFileShare_NFSFileShareDefaults
--- PASS: TestAccAWSStorageGatewayNfsFileShare_GuessMIMETypeEnabled (263.26s)
=== CONT  TestAccAWSStorageGatewayNfsFileShare_KMSKeyArn
--- PASS: TestAccAWSStorageGatewayNfsFileShare_NFSFileShareDefaults (295.89s)
=== CONT  TestAccAWSStorageGatewayNfsFileShare_KMSEncrypted
--- PASS: TestAccAWSStorageGatewayNfsFileShare_KMSKeyArn (323.53s)
=== CONT  TestAccAWSStorageGatewayNfsFileShare_ClientList
--- PASS: TestAccAWSStorageGatewayNfsFileShare_KMSEncrypted (227.39s)
=== CONT  TestAccAWSStorageGatewayNfsFileShare_DefaultStorageClass
--- PASS: TestAccAWSStorageGatewayNfsFileShare_ClientList (373.48s)
=== CONT  TestAccAWSStorageGatewayNfsFileShare_fileShareName
--- PASS: TestAccAWSStorageGatewayNfsFileShare_DefaultStorageClass (273.43s)
=== CONT  TestAccAWSStorageGatewayNfsFileShare_tags
--- PASS: TestAccAWSStorageGatewayNfsFileShare_fileShareName (283.37s)
--- PASS: TestAccAWSStorageGatewayNfsFileShare_tags (296.06s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	2357.520s

@breathingdust breathingdust added this to the v3.17.0 milestone Nov 23, 2020
@breathingdust
Copy link
Member

LGTM 🚀 Thanks @DrFaust92 for the contribution!

Verified Acceptance Tests in Commercial (us-west-2)

make testacc TEST=./aws TESTARGS='-run=TestAccAWSStorageGatewayNfsFileShare_' ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 2 -run=TestAccAWSStorageGatewayNfsFileShare_ -timeout 120m
=== RUN   TestAccAWSStorageGatewayNfsFileShare_basic
=== PAUSE TestAccAWSStorageGatewayNfsFileShare_basic
=== RUN   TestAccAWSStorageGatewayNfsFileShare_tags
=== PAUSE TestAccAWSStorageGatewayNfsFileShare_tags
=== RUN   TestAccAWSStorageGatewayNfsFileShare_fileShareName
=== PAUSE TestAccAWSStorageGatewayNfsFileShare_fileShareName
=== RUN   TestAccAWSStorageGatewayNfsFileShare_ClientList
=== PAUSE TestAccAWSStorageGatewayNfsFileShare_ClientList
=== RUN   TestAccAWSStorageGatewayNfsFileShare_DefaultStorageClass
=== PAUSE TestAccAWSStorageGatewayNfsFileShare_DefaultStorageClass
=== RUN   TestAccAWSStorageGatewayNfsFileShare_GuessMIMETypeEnabled
=== PAUSE TestAccAWSStorageGatewayNfsFileShare_GuessMIMETypeEnabled
=== RUN   TestAccAWSStorageGatewayNfsFileShare_KMSEncrypted
=== PAUSE TestAccAWSStorageGatewayNfsFileShare_KMSEncrypted
=== RUN   TestAccAWSStorageGatewayNfsFileShare_KMSKeyArn
=== PAUSE TestAccAWSStorageGatewayNfsFileShare_KMSKeyArn
=== RUN   TestAccAWSStorageGatewayNfsFileShare_NFSFileShareDefaults
=== PAUSE TestAccAWSStorageGatewayNfsFileShare_NFSFileShareDefaults
=== RUN   TestAccAWSStorageGatewayNfsFileShare_ObjectACL
=== PAUSE TestAccAWSStorageGatewayNfsFileShare_ObjectACL
=== RUN   TestAccAWSStorageGatewayNfsFileShare_ReadOnly
=== PAUSE TestAccAWSStorageGatewayNfsFileShare_ReadOnly
=== RUN   TestAccAWSStorageGatewayNfsFileShare_RequesterPays
=== PAUSE TestAccAWSStorageGatewayNfsFileShare_RequesterPays
=== RUN   TestAccAWSStorageGatewayNfsFileShare_Squash
=== PAUSE TestAccAWSStorageGatewayNfsFileShare_Squash
=== RUN   TestAccAWSStorageGatewayNfsFileShare_notificationPolicy
=== PAUSE TestAccAWSStorageGatewayNfsFileShare_notificationPolicy
=== RUN   TestAccAWSStorageGatewayNfsFileShare_cacheAttributes
=== PAUSE TestAccAWSStorageGatewayNfsFileShare_cacheAttributes
=== RUN   TestAccAWSStorageGatewayNfsFileShare_disappears
=== PAUSE TestAccAWSStorageGatewayNfsFileShare_disappears
=== CONT  TestAccAWSStorageGatewayNfsFileShare_basic
=== CONT  TestAccAWSStorageGatewayNfsFileShare_NFSFileShareDefaults
--- PASS: TestAccAWSStorageGatewayNfsFileShare_basic (305.01s)
=== CONT  TestAccAWSStorageGatewayNfsFileShare_Squash
--- PASS: TestAccAWSStorageGatewayNfsFileShare_NFSFileShareDefaults (373.23s)
=== CONT  TestAccAWSStorageGatewayNfsFileShare_disappears
--- PASS: TestAccAWSStorageGatewayNfsFileShare_Squash (276.83s)
=== CONT  TestAccAWSStorageGatewayNfsFileShare_cacheAttributes
--- PASS: TestAccAWSStorageGatewayNfsFileShare_disappears (251.05s)
=== CONT  TestAccAWSStorageGatewayNfsFileShare_RequesterPays
--- PASS: TestAccAWSStorageGatewayNfsFileShare_RequesterPays (288.88s)
=== CONT  TestAccAWSStorageGatewayNfsFileShare_ReadOnly
--- PASS: TestAccAWSStorageGatewayNfsFileShare_cacheAttributes (353.15s)
=== CONT  TestAccAWSStorageGatewayNfsFileShare_ObjectACL
--- PASS: TestAccAWSStorageGatewayNfsFileShare_ReadOnly (265.26s)
=== CONT  TestAccAWSStorageGatewayNfsFileShare_DefaultStorageClass
--- PASS: TestAccAWSStorageGatewayNfsFileShare_ObjectACL (287.25s)
=== CONT  TestAccAWSStorageGatewayNfsFileShare_KMSKeyArn
--- PASS: TestAccAWSStorageGatewayNfsFileShare_DefaultStorageClass (303.15s)
=== CONT  TestAccAWSStorageGatewayNfsFileShare_KMSEncrypted
2020/11/23 14:21:53 [DEBUG] Authorizing security group {
  Description: "Managed by Terraform",
  GroupId: "sg-0fe7b1221ab1ac6a9",
  GroupName: "terraform-2020112322215170130000001f",
  OwnerId: "187416307283",
  Tags: [{
      Key: "Name",
      Value: "tf-acc-test-2155832415105969931"
    }],
  VpcId: "vpc-046450f29017c404b"
} egress rule: []*ec2.IpPermission{{
  FromPort: 0,
  IpProtocol: "-1",
  IpRanges: [{
      CidrIp: "0.0.0.0/0"
    }],
  ToPort: 0
}}
--- PASS: TestAccAWSStorageGatewayNfsFileShare_KMSKeyArn (341.54s)
=== CONT  TestAccAWSStorageGatewayNfsFileShare_GuessMIMETypeEnabled
--- PASS: TestAccAWSStorageGatewayNfsFileShare_KMSEncrypted (223.99s)
=== CONT  TestAccAWSStorageGatewayNfsFileShare_notificationPolicy
--- PASS: TestAccAWSStorageGatewayNfsFileShare_GuessMIMETypeEnabled (270.10s)
=== CONT  TestAccAWSStorageGatewayNfsFileShare_fileShareName
--- PASS: TestAccAWSStorageGatewayNfsFileShare_notificationPolicy (383.88s)
=== CONT  TestAccAWSStorageGatewayNfsFileShare_ClientList
--- PASS: TestAccAWSStorageGatewayNfsFileShare_fileShareName (278.67s)
=== CONT  TestAccAWSStorageGatewayNfsFileShare_tags
--- PASS: TestAccAWSStorageGatewayNfsFileShare_tags (272.67s)
--- PASS: TestAccAWSStorageGatewayNfsFileShare_ClientList (324.73s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	2416.054s

Verified Acceptance Tests in GovCloud (us-gov-west-1)

make testacc TEST=./aws TESTARGS='-run=TestAccAWSStorageGatewayNfsFileShare_' ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 2 -run=TestAccAWSStorageGatewayNfsFileShare_ -timeout 120m
=== RUN   TestAccAWSStorageGatewayNfsFileShare_basic
=== PAUSE TestAccAWSStorageGatewayNfsFileShare_basic
=== RUN   TestAccAWSStorageGatewayNfsFileShare_tags
=== PAUSE TestAccAWSStorageGatewayNfsFileShare_tags
=== RUN   TestAccAWSStorageGatewayNfsFileShare_fileShareName
=== PAUSE TestAccAWSStorageGatewayNfsFileShare_fileShareName
=== RUN   TestAccAWSStorageGatewayNfsFileShare_ClientList
=== PAUSE TestAccAWSStorageGatewayNfsFileShare_ClientList
=== RUN   TestAccAWSStorageGatewayNfsFileShare_DefaultStorageClass
=== PAUSE TestAccAWSStorageGatewayNfsFileShare_DefaultStorageClass
=== RUN   TestAccAWSStorageGatewayNfsFileShare_GuessMIMETypeEnabled
=== PAUSE TestAccAWSStorageGatewayNfsFileShare_GuessMIMETypeEnabled
=== RUN   TestAccAWSStorageGatewayNfsFileShare_KMSEncrypted
=== PAUSE TestAccAWSStorageGatewayNfsFileShare_KMSEncrypted
=== RUN   TestAccAWSStorageGatewayNfsFileShare_KMSKeyArn
=== PAUSE TestAccAWSStorageGatewayNfsFileShare_KMSKeyArn
=== RUN   TestAccAWSStorageGatewayNfsFileShare_NFSFileShareDefaults
=== PAUSE TestAccAWSStorageGatewayNfsFileShare_NFSFileShareDefaults
=== RUN   TestAccAWSStorageGatewayNfsFileShare_ObjectACL
=== PAUSE TestAccAWSStorageGatewayNfsFileShare_ObjectACL
=== RUN   TestAccAWSStorageGatewayNfsFileShare_ReadOnly
=== PAUSE TestAccAWSStorageGatewayNfsFileShare_ReadOnly
=== RUN   TestAccAWSStorageGatewayNfsFileShare_RequesterPays
=== PAUSE TestAccAWSStorageGatewayNfsFileShare_RequesterPays
=== RUN   TestAccAWSStorageGatewayNfsFileShare_Squash
=== PAUSE TestAccAWSStorageGatewayNfsFileShare_Squash
=== RUN   TestAccAWSStorageGatewayNfsFileShare_notificationPolicy
=== PAUSE TestAccAWSStorageGatewayNfsFileShare_notificationPolicy
=== RUN   TestAccAWSStorageGatewayNfsFileShare_cacheAttributes
=== PAUSE TestAccAWSStorageGatewayNfsFileShare_cacheAttributes
=== RUN   TestAccAWSStorageGatewayNfsFileShare_disappears
=== PAUSE TestAccAWSStorageGatewayNfsFileShare_disappears
=== CONT  TestAccAWSStorageGatewayNfsFileShare_basic
=== CONT  TestAccAWSStorageGatewayNfsFileShare_disappears
--- PASS: TestAccAWSStorageGatewayNfsFileShare_basic (237.99s)
=== CONT  TestAccAWSStorageGatewayNfsFileShare_NFSFileShareDefaults
--- PASS: TestAccAWSStorageGatewayNfsFileShare_disappears (273.75s)
=== CONT  TestAccAWSStorageGatewayNfsFileShare_cacheAttributes
--- PASS: TestAccAWSStorageGatewayNfsFileShare_NFSFileShareDefaults (292.65s)
=== CONT  TestAccAWSStorageGatewayNfsFileShare_notificationPolicy
--- PASS: TestAccAWSStorageGatewayNfsFileShare_cacheAttributes (351.67s)
=== CONT  TestAccAWSStorageGatewayNfsFileShare_Squash
--- PASS: TestAccAWSStorageGatewayNfsFileShare_notificationPolicy (353.98s)
=== CONT  TestAccAWSStorageGatewayNfsFileShare_RequesterPays
--- PASS: TestAccAWSStorageGatewayNfsFileShare_Squash (268.61s)
=== CONT  TestAccAWSStorageGatewayNfsFileShare_ReadOnly
--- PASS: TestAccAWSStorageGatewayNfsFileShare_RequesterPays (276.06s)
=== CONT  TestAccAWSStorageGatewayNfsFileShare_ObjectACL
--- PASS: TestAccAWSStorageGatewayNfsFileShare_ReadOnly (274.11s)
=== CONT  TestAccAWSStorageGatewayNfsFileShare_DefaultStorageClass
--- PASS: TestAccAWSStorageGatewayNfsFileShare_ObjectACL (262.10s)
=== CONT  TestAccAWSStorageGatewayNfsFileShare_KMSKeyArn
--- PASS: TestAccAWSStorageGatewayNfsFileShare_DefaultStorageClass (271.66s)
=== CONT  TestAccAWSStorageGatewayNfsFileShare_KMSEncrypted
--- PASS: TestAccAWSStorageGatewayNfsFileShare_KMSEncrypted (210.03s)
=== CONT  TestAccAWSStorageGatewayNfsFileShare_GuessMIMETypeEnabled
--- PASS: TestAccAWSStorageGatewayNfsFileShare_KMSKeyArn (358.02s)
=== CONT  TestAccAWSStorageGatewayNfsFileShare_fileShareName
--- PASS: TestAccAWSStorageGatewayNfsFileShare_GuessMIMETypeEnabled (251.01s)
=== CONT  TestAccAWSStorageGatewayNfsFileShare_ClientList
--- PASS: TestAccAWSStorageGatewayNfsFileShare_fileShareName (238.28s)
=== CONT  TestAccAWSStorageGatewayNfsFileShare_tags
2020/11/23 15:26:03 [DEBUG] Reading Storage Gateway NFS File Share: {
  FileShareARNList: ["arn:aws-us-gov:storagegateway:us-gov-west-1:357342307427:share/share-15FB8C63"]
}
--- PASS: TestAccAWSStorageGatewayNfsFileShare_ClientList (339.22s)
--- PASS: TestAccAWSStorageGatewayNfsFileShare_tags (252.00s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	2275.138s

@breathingdust breathingdust merged commit fbf325f into hashicorp:master Nov 23, 2020
breathingdust added a commit that referenced this pull request Nov 23, 2020
@breathingdust
Update CHANGELOG.md for #16340
88a68f8
@ghost
Copy link

ghost commented Nov 24, 2020

This has been released in version 3.17.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Dec 24, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Dec 24, 2020
@DrFaust92 DrFaust92 deleted the r/storagegateway_nfs_file_share_notif branch April 15, 2021 10:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/storagegateway Issues and PRs that pertain to the storagegateway service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.17.0
Development

Successfully merging this pull request may close these issues.
3 participants
@DrFaust92 @ewbankkit @breathingdust