Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds custom event bus support to EventBridge permission resource #15922

Merged
merged 3 commits into from
Nov 5, 2020

Conversation

gdavison
Copy link
Contributor

Adds custom event bus support to EventBridge permission resource.

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #9330

Release note for CHANGELOG:

* resource/aws_cloudwatch_event_permission: Add `event_bus_name`

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSCloudWatchEventPermission_'

--- PASS: TestAccAWSCloudWatchEventPermission_EventBusName (177.11s)
--- PASS: TestAccAWSCloudWatchEventPermission_Multiple (210.04s)
--- PASS: TestAccAWSCloudWatchEventPermission_Action (211.18s)
--- PASS: TestAccAWSCloudWatchEventPermission_Condition (221.85s)
--- PASS: TestAccAWSCloudWatchEventPermission_basic (244.34s)
--- PASS: TestAccAWSCloudWatchEventPermission_Disappears (257.24s)

@gdavison gdavison requested a review from a team October 29, 2020 21:19
@ghost ghost added size/L Managed by automation to categorize the size of a PR. service/cloudwatchevents documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Oct 29, 2020
Copy link
Contributor

@anGie44 anGie44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Output of tests (commercial):

--- PASS: TestAccAWSCloudWatchEventPermission_EventBusName (17.42s)
--- PASS: TestAccAWSCloudWatchEventPermission_Action (19.03s)
--- PASS: TestAccAWSCloudWatchEventPermission_Multiple (24.19s)
--- PASS: TestAccAWSCloudWatchEventPermission_Condition (25.41s)
--- PASS: TestAccAWSCloudWatchEventPermission_basic (33.37s)
--- PASS: TestAccAWSCloudWatchEventPermission_Disappears (132.89s)

@gdavison gdavison merged commit 66d57fe into master Nov 5, 2020
@gdavison gdavison deleted the add-eventbus-to-cloudwatch-event-permission branch November 5, 2020 23:44
gdavison added a commit that referenced this pull request Nov 5, 2020
@gdavison gdavison added this to the v3.14.0 milestone Nov 5, 2020
@ghost
Copy link

ghost commented Nov 6, 2020

This has been released in version 3.14.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Dec 6, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Dec 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants