-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds file path conditional checks for acceptance tests linters #15533
Conversation
# Substitute as latest release | ||
VERSION=$(git describe --abbrev=0 --match='v*.*.*' --tags || echo -n "v99.99.99") | ||
go build -o ${TF_PLUGIN_CACHE_DIR}/${GOOS}_${GOARCH}/terraform-provider-aws_${VERSION}_x4 . | ||
run: go build -o terraform-plugin-dir/terraform-provider-aws_v99.99.99_x5 . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How is terraform-plugin-dir
being picked up? 😄 This is passing right now because its just downloading the latest released provider version (- Downloading plugin for provider "aws" (hashicorp/aws) 3.9.0...
in the logs), which works fine most of the time, but wouldn't work for new examples with unreleased resources.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I noticed that when I was testing. That was also the behaviour before this change, so I figured I'd leave it and fix later. Part of the problem is that at least one of the examples uses additional providers, causing problems with terraform init -plugin-dir=terraform-plugin-dir
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, it was easy…
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than the small suggestion for cleanup, let's do it. 🚀
Co-authored-by: Brian Flad <[email protected]>
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
Adds file path conditional checks for acceptance tests linters. Runs terraform validation when
tflint
is updatedRelates #15342
Release note for CHANGELOG:
Output from acceptance testing:
N/A