Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds file path conditional checks for acceptance tests linters #15533

Merged
merged 6 commits into from
Oct 14, 2020
Merged

Adds file path conditional checks for acceptance tests linters #15533

merged 6 commits into from
Oct 14, 2020

Conversation

gdavison
Copy link
Contributor

@gdavison gdavison commented Oct 6, 2020 •
edited
Loading

Adds file path conditional checks for acceptance tests linters. Runs terraform validation when tflint is updated

Relates #15342

Release note for CHANGELOG:

NONE

Output from acceptance testing:

N/A

@ghost ghost added size/XS Managed by automation to categorize the size of a PR. provider Pertains to the provider itself, rather than any interaction with AWS. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Oct 6, 2020
@ghost ghost added size/S Managed by automation to categorize the size of a PR. and removed size/XS Managed by automation to categorize the size of a PR. labels Oct 7, 2020
@gdavison gdavison marked this pull request as ready for review October 7, 2020 21:09
@gdavison gdavison requested a review from a team October 7, 2020 21:09
bflad
bflad reviewed Oct 7, 2020
View reviewed changes
.github/workflows/examples.yml
# Substitute as latest release
VERSION=$(git describe --abbrev=0 --match='v*.*.*' --tags || echo -n "v99.99.99")
go build -o ${TF_PLUGIN_CACHE_DIR}/${GOOS}_${GOARCH}/terraform-provider-aws_${VERSION}_x4 .
run: go build -o terraform-plugin-dir/terraform-provider-aws_v99.99.99_x5 .
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How is terraform-plugin-dir being picked up? 😄 This is passing right now because its just downloading the latest released provider version (- Downloading plugin for provider "aws" (hashicorp/aws) 3.9.0... in the logs), which works fine most of the time, but wouldn't work for new examples with unreleased resources.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I noticed that when I was testing. That was also the behaviour before this change, so I figured I'd leave it and fix later. Part of the problem is that at least one of the examples uses additional providers, causing problems with terraform init -plugin-dir=terraform-plugin-dir.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, it was easy…

bflad
bflad approved these changes Oct 14, 2020
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the small suggestion for cleanup, let's do it. 🚀

@gdavison gdavison merged commit b485d38 into master Oct 14, 2020
@gdavison gdavison deleted the tflint-dependency-renovate branch October 14, 2020 22:34
@breathingdust breathingdust added the linter Pertains to changes to or issues with the various linters. label Oct 27, 2020
@ghost
Copy link

ghost commented Nov 14, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Nov 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees
No one assigned
Labels
linter Pertains to changes to or issues with the various linters. provider Pertains to the provider itself, rather than any interaction with AWS. size/S Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gdavison @bflad @breathingdust