New resource: Timestream Write database resource

[yardensachs]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #15421

Release note for CHANGELOG:

FEATURES:
- **New Resource:** `aws_timestreamwrite_database`

Output from acceptance testing:

make testacc TESTARGS='-run=TestAccAWSTimestreamWriteDatabase_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSTimestreamWriteDatabase_ -timeout 120m
=== RUN   TestAccAWSTimestreamWriteDatabase_basic
=== PAUSE TestAccAWSTimestreamWriteDatabase_basic
=== RUN   TestAccAWSTimestreamWriteDatabase_kmsKey
=== PAUSE TestAccAWSTimestreamWriteDatabase_kmsKey
=== RUN   TestAccAWSTimestreamWriteDatabase_Tags
=== PAUSE TestAccAWSTimestreamWriteDatabase_Tags
=== CONT  TestAccAWSTimestreamWriteDatabase_basic
=== CONT  TestAccAWSTimestreamWriteDatabase_Tags
=== CONT  TestAccAWSTimestreamWriteDatabase_kmsKey
--- PASS: TestAccAWSTimestreamWriteDatabase_basic (17.00s)
--- PASS: TestAccAWSTimestreamWriteDatabase_kmsKey (18.86s)
--- PASS: TestAccAWSTimestreamWriteDatabase_Tags (40.68s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	43.229s

[yardensachs]

This PR is 2 out of 2 PRs, split from #15444 per @DrFaust92 request
Earlier PR was #15451

[yardensachs]

Also, this is my first ever Go code I wrote.
Please be gentle 😇

[DrFaust92]

Hey @yardensachs,
Some comments

[DrFaust92]

small nit, otherwise looking good. ill let maintainers take over for now as I cant run tests to verify at the moment

[yardensachs]

@bflad How can I get someone to run tests so I can merge?
Is it just a time factor until someone does it?

[yardensachs]

ok, Im assuming its a matter of time till it does

[yardensachs]

@DrFaust92 thanks, do you know how long does it usually take for these types of PRs to be reviewed?
I don't mind, just don't want to miss a review so I keep refreshing every few hours 😅

[DrFaust92]

Hey,

PRs are usually prioritized by importance (bugs and such) and community interest.

Keep in mind there are 600+ PRs to go over.

The provider team publishes a Roadmap every few months for topic they will focus on.

Also See: FAQ.

Hope this eases the uncertainty.

[yardensachs]

@DrFaust92 Thanks for explaining.

So does this mean that this PR potentially can wait months to be merged?

[anGie44]

Hi @yardensachs , thank you for this PR! Overall looked really great, I've only refactored a bit to update to using new Terraform Plugin SDK functions like <operation>WithTimeout and new testing conventions + new changelog process in the repo. I aim to get this is into the next release 👍

Output of acceptance tests (commercial):

--- PASS: TestAccAWSTimestreamWriteDatabase_basic (18.50s)
--- PASS: TestAccAWSTimestreamWriteDatabase_kmsKey (20.98s)
--- PASS: TestAccAWSTimestreamWriteDatabase_Tags (41.22s)
--- PASS: TestAccAWSTimestreamWriteDatabase_updateKmsKey (43.54s)

Output of acceptance tests (GovCloud):

--- SKIP: TestAccAWSTimestreamWriteDatabase_updateKmsKey (21.31s)
--- SKIP: TestAccAWSTimestreamWriteDatabase_Tags (23.66s)
--- SKIP: TestAccAWSTimestreamWriteDatabase_kmsKey (24.28s)
--- SKIP: TestAccAWSTimestreamWriteDatabase_basic (24.43s)

[ghost]

This has been released in version 3.40.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.