Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws_eks_node_group: allow name to be optional #15407

Closed
wants to merge 1 commit into from
Closed

aws_eks_node_group: allow name to be optional #15407

wants to merge 1 commit into from

Conversation

troyready
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Not all node group properties can be updated via the API, making many changes require a replacement of the resource. To make this seamless with create_before_destroy (instead of generating a "already exists with name" error), Terraform should allow for the name to be automatically computed.

Release note for CHANGELOG:

aws_eks_node_group: allow name to be automatically computed

Output from acceptance testing:

$ make testacc TESTARGS='-run=func TestAccAWSEksNodeGroup_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=func TestAccAWSEksNodeGroup_basic -timeout 120m
=== RUN   TestAccAWSIoTTopicRule_step_functions
=== PAUSE TestAccAWSIoTTopicRule_step_functions
=== CONT  TestAccAWSIoTTopicRule_step_functions
--- PASS: TestAccAWSIoTTopicRule_step_functions (35.18s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	35.216s

not all node group properties can be updated via the API, making many
changes require a replacement of the resource. To make this seamless
with create_before_destroy, Terraform should allow for the name to be
automatically computed.
@troyready troyready requested a review from a team September 30, 2020 20:08
@ghost ghost added size/S Managed by automation to categorize the size of a PR. service/eks Issues and PRs that pertain to the eks service. documentation Introduces or discusses updates to documentation. labels Sep 30, 2020
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Sep 30, 2020
@mfreebairn-r7
Copy link

Are there any mods available to review & approve this? Need this to enable easily updating my cluster instance types without leaving me with 0 compute

Base automatically changed from master to main January 23, 2021 00:59
@breathingdust breathingdust requested a review from a team as a code owner January 23, 2021 00:59
@Skaronator
Copy link

There are currently 2 PRs fixing the exact same issue we have: This one & #13938

@breathingdust @bflad
Is there any chance to get one of them reviewed & merged? I'm not a golang developer but since the code in both PRs are almost Identical they should be fine. 😘

@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label May 12, 2021
@ewbankkit
Copy link
Contributor

@troyready Thanks for the contribution 👏.
I am going to close this PR as a duplicate of #13938 solely because the linked PR has an acceptance test.
I will try including your commit so that you will get joint attribution.

@ewbankkit ewbankkit closed this May 12, 2021
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 12, 2021
@troyready troyready deleted the aws_eks_node_group_allow_name_prefix branch September 16, 2021 17:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. service/eks Issues and PRs that pertain to the eks service. size/S Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants