Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MSK Node Data source #15163

Closed
wants to merge 2 commits into from
Closed

Conversation

dblooman
Copy link
Contributor

@dblooman dblooman commented Sep 15, 2020

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #15731

Release note for CHANGELOG:

New Data Source: aws_msk_node

Output from acceptance testing:

make testacc TESTARGS='-run=TestAccAWSMskNodes_ClientIp'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSMskNodes_ClientIp -timeout 120m
=== RUN   TestAccAWSMskNodes_ClientIp
=== PAUSE TestAccAWSMskNodes_ClientIp
=== CONT  TestAccAWSMskNodes_ClientIp
--- PASS: TestAccAWSMskNodes_ClientIp (1242.97s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       1245.482s

@dblooman dblooman requested a review from a team September 15, 2020 21:18
@ghost ghost added size/L Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/kafka Issues and PRs that pertain to the kafka service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. needs-triage Waiting for first response or review from a maintainer. labels Sep 15, 2020
@anGie44 anGie44 added new-data-source Introduces a new data source. enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. provider Pertains to the provider itself, rather than any interaction with AWS. labels Sep 17, 2020
@ghost ghost added the provider Pertains to the provider itself, rather than any interaction with AWS. label Oct 15, 2020
@dblooman dblooman force-pushed the msk_nodes_data_source branch 2 times, most recently from 7a41f3b to 85ee58a Compare October 15, 2020 14:48
@dblooman
Copy link
Contributor Author

@anGie44

@anGie44
Copy link
Contributor

anGie44 commented Oct 19, 2020

Hi @dblooman, thank you for opening this PR! Since I don't see a related issue already created by the community, would you mind creating one so we can keep track of the community support for this new data source? We use the community reactions for the internal team to prioritize requests. Once the issue is created, we will continue to monitor the community interest in the feature, and once enough support is demonstrated, the team will queue this PR up for review.

@anGie44 anGie44 removed the provider Pertains to the provider itself, rather than any interaction with AWS. label Oct 19, 2020
Base automatically changed from master to main January 23, 2021 00:59
@breathingdust breathingdust requested a review from a team as a code owner January 23, 2021 00:59
@marcelobartsch-jt
Copy link

any chance we can get this into the providers? this is something we really we need , currently we are using a dirty hack with dns data , for , count and other tricks to get the names nodes when we could have used this to make it a lot simpler.

@dblooman
Copy link
Contributor Author

gonna close this as it doesn't look likely to get merged

@dblooman dblooman closed this Jul 23, 2021
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. new-data-source Introduces a new data source. service/kafka Issues and PRs that pertain to the kafka service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

data source aws_msk_node
3 participants