Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests/provider: Update resource testing to 0.12 syntax (V Resources) #14704

Merged
merged 1 commit into from
Sep 11, 2020
Merged

tests/provider: Update resource testing to 0.12 syntax (V Resources) #14704

merged 1 commit into from
Sep 11, 2020

Conversation

YakDriver
Copy link
Member

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Related: #8950, #14417

Release note for CHANGELOG:

NONE

Output from acceptance testing: Handled via daily acceptance testing

@YakDriver YakDriver requested a review from a team August 17, 2020 21:44
@ghost ghost added size/XL Managed by automation to categorize the size of a PR. service/ec2 Issues and PRs that pertain to the ec2 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Aug 17, 2020
@YakDriver YakDriver added the partition/aws-us-gov Pertains to the aws-us-gov partition. label Aug 18, 2020
@bflad bflad self-assigned this Aug 21, 2020
@bflad
Copy link
Contributor

bflad commented Aug 21, 2020

Ah looks like some of the other good testing fixes caused merge conflicts here, do you mind a quick update? Thanks so much. 👍

@YakDriver
Copy link
Member Author

Good to go!

bflad
bflad suggested changes Sep 10, 2020
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two new test failures, but otherwise looks good. 👍

aws/resource_aws_vpc_test.go Outdated Show resolved Hide resolved
aws/resource_aws_vpc_endpoint_test.go Outdated Show resolved Hide resolved
@YakDriver YakDriver added this to the v3.7.0 milestone Sep 11, 2020
@YakDriver YakDriver merged commit 5a7db30 into master Sep 11, 2020
@YakDriver YakDriver deleted the t-012-syntax-and-fmt-v branch September 11, 2020 21:19
@ghost
Copy link

ghost commented Sep 17, 2020

This has been released in version 3.7.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Oct 12, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Oct 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees

@bflad bflad

Labels
partition/aws-us-gov Pertains to the aws-us-gov partition. service/ec2 Issues and PRs that pertain to the ec2 service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.7.0
Development

Successfully merging this pull request may close these issues.
2 participants
@YakDriver @bflad