Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

service/wafv2: update web_acl and rule_group documentation #14160

Merged
merged 2 commits into from
Jul 15, 2020
Merged

service/wafv2: update web_acl and rule_group documentation #14160

merged 2 commits into from
Jul 15, 2020

Conversation

anGie44
Copy link
Contributor

@anGie44 anGie44 commented Jul 13, 2020 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #14120, #14094

Release note for CHANGELOG:

service/wafv2: update web_acl and rule_group documentation

Output from acceptance testing:

N/A

@anGie44 anGie44 requested a review from a team July 13, 2020 14:36
@ghost ghost added size/M Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/wafv2 Issues and PRs that pertain to the wafv2 service. labels Jul 13, 2020
@anGie44 anGie44 changed the title service/wafv2: update web_acl rule_group documentation service/wafv2: update web_acl and rule_group documentation Jul 13, 2020
@anGie44 anGie44 force-pushed the td-wafv2-webacl-documentaton branch from 19793b5 to de3be5e Compare July 13, 2020 14:52
bflad
bflad approved these changes Jul 15, 2020
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one small omission 🚀

website/docs/r/wafv2_rule_group.html.markdown Outdated Show resolved Hide resolved
@anGie44 anGie44 force-pushed the td-wafv2-webacl-documentaton branch from b7537bb to 390f1a9 Compare July 15, 2020 17:07
@anGie44 anGie44 merged commit def3ab0 into master Jul 15, 2020
@anGie44 anGie44 deleted the td-wafv2-webacl-documentaton branch July 15, 2020 20:29
@ghost
Copy link

ghost commented Aug 15, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Aug 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. service/wafv2 Issues and PRs that pertain to the wafv2 service. size/M Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anGie44 @bflad