Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove hardcoded AMI IDs from launch_config data source #14147

Merged
merged 1 commit into from
Jul 15, 2020
Merged

Remove hardcoded AMI IDs from launch_config data source #14147

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions aws/data_source_aws_launch_configuration_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,10 +52,10 @@ func TestAccAWSLaunchConfigurationDataSource_securityGroups(t *testing.T) {
}

func testAccLaunchConfigurationDataSourceConfig_basic(rInt int) string {
return fmt.Sprintf(`
return testAccLatestAmazonLinuxHvmEbsAmiConfig() + fmt.Sprintf(`
resource "aws_launch_configuration" "foo" {
name = "terraform-test-%d"
image_id = "ami-21f78e11"
image_id = data.aws_ami.amzn-ami-minimal-hvm-ebs.id
instance_type = "m1.small"
associate_public_ip_address = true
user_data = "foobar-user-data"
Expand Down Expand Up @@ -90,7 +90,7 @@ data "aws_launch_configuration" "foo" {
}

func testAccLaunchConfigurationDataSourceConfig_securityGroups(rInt int) string {
return fmt.Sprintf(`
return testAccLatestAmazonLinuxHvmEbsAmiConfig() + fmt.Sprintf(`
resource "aws_vpc" "test" {
cidr_block = "10.1.0.0/16"
}
Expand All @@ -102,7 +102,7 @@ resource "aws_security_group" "test" {

resource "aws_launch_configuration" "test" {
name = "terraform-test-%d"
image_id = "ami-21f78e11"
image_id = data.aws_ami.amzn-ami-minimal-hvm-ebs.id
instance_type = "m1.small"
security_groups = ["${aws_security_group.test.id}"]
}
Expand Down