Support multiple baselines on SSM Patch Group

[melbit-michaelw]

This commit modifies the Id for an SSM Patch Group to be the Patch Group Name joined to the BaselineId by a ":". This allows an SSM Patch Group to support multiple baselines.

Please note that pre-existing patch groups will be recreated due to the change in Id (this happens without issue in my testing as the AWS API call succeeds even if the patch group already has that baseline applied).

If necessary, I can look into State Migration to handle that, but it looked quite complicated compared to my very beginner level of Go knowledge.

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #9603

Release note for CHANGELOG:

resource/aws_ssm_patch_group: Support multiple baselines (one per OS) on an SSM patch group 

Output from acceptance testing:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSSSMPatchGroup'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSSSMPatchGroup -timeout 120m
=== RUN   TestAccAWSSSMPatchGroup_basic
=== PAUSE TestAccAWSSSMPatchGroup_basic
=== CONT  TestAccAWSSSMPatchGroup_basic
--- PASS: TestAccAWSSSMPatchGroup_basic (29.14s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       30.406s

[jdheyburn]

This looks good 👍 . I'll try to clone your repo and give it a go later this week. In the meantime I've some comments on readability

[jdheyburn]

I've built the provider locally and confirmed the fix given the replicate steps in the linked issue. Happy for it to be merge.

Thanks for getting round to looking at this 🎉

[melbit-michaelw]

@bflad - Apologies for mentioning you directly, but this pull request appears to have been overlooked. Is there anything I can do in order to get it reviewed and hopefully merged ?

[melbit-michaelw]

@anGie44 , @YakDriver - Again, really sorry to mention you directly, but this PR hasn't progressed in months. Is there something more I need to do in order for it to be reviewed ?

[anGie44]

Hi @melbit-michaelw , thank you for raising this PR! Since these changes are included in #15213, I'm going to close this in favor of the other PR which includes pagination support. Please refer there for updates 👍

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!